vldb_check: Check for volume lock inconsistencies
[openafs.git] / src / vlserver / vldb_check.c
index 7177beb..87efccb 100644 (file)
@@ -1,12 +1,28 @@
 /*
  * Copyright 2000, International Business Machines Corporation and others.
  * All Rights Reserved.
- * 
+ *
  * This software has been released under the terms of the IBM Public
  * License.  For details, see the LICENSE file in the top-level source
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
+#include <afsconfig.h>
+#include <afs/param.h>
+
+#include <roken.h>
+
+#ifdef AFS_NT40_ENV
+#include <WINNT/afsevent.h>
+#endif
+
+#include <ubik.h>
+#include <afs/afsutil.h>
+#include <afs/cmd.h>
+
+#include "vlserver.h"
+#include "vldbint.h"
+
 /* Read a VLDB file and verify it for correctness */
 
 #define VL  0x001              /* good volume entry */
 #define REFBK 0x4000            /* linked from something (BK) */
 #define REFN  0x8000            /* linked from something (name) */
 
-#define vldbread(x,y,z) vldbio(x,y,z,0)
-#define vldbwrite(x,y,z) vldbio(x,y,z,1)
-
-#include <afsconfig.h>
-#include <afs/param.h>
+#define MULTRW 0x10000         /* multiply-chained (RW) */
+#define MULTRO 0x20000         /* multiply-chained (RO) */
+#define MULTBK 0x40000         /* multiply-chained (BK) */
+#define MULTN  0x80000         /* multiply-chained (name) */
 
-RCSID
-    ("$Header$");
+#define MISRWH 0x100000          /* mischained (RW) */
+#define MISROH 0x200000          /* mischained (RO) */
+#define MISBKH 0x400000          /* mischained (BK) */
+#define MISNH  0x800000          /* mischained (name) */
 
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <errno.h>
-#include <string.h>
-#ifdef AFS_NT40_ENV
-#include <winsock2.h>
-#include <WINNT/afsevent.h>
-#include <io.h>
-#else
-#include <sys/socket.h>
-#include <netdb.h>
-#include <netinet/in.h>
-#endif
-
-#include "vlserver.h"
-#include "vldbint.h"
-#include <ubik.h>
-#include <afs/afsutil.h>
-#include <afs/cmd.h>
+#define VLDB_CHECK_NO_VLDB_CHECK_ERROR 0
+#define VLDB_CHECK_WARNING  1
+#define VLDB_CHECK_ERROR    2
+#define VLDB_CHECK_FATAL    4
+#define vldbread(x,y,z) vldbio(x,y,z,0)
+#define vldbwrite(x,y,z) vldbio(x,y,z,1)
 
-#define ADDR(x) (x/sizeof(struct nvlentry))
+#define HDRSIZE 64
+#define ADDR(x) ((x)/sizeof(struct nvlentry))
+#define OFFSET(addr) ((addr) + HDRSIZE)
 
 int fd;
-int listentries, listservers, listheader, listuheader, verbose;
+int listentries, listservers, listheader, listuheader, verbose, quiet;
 
 int fix = 0;
+int passes = 0;
+/* if quiet, don't send anything to stdout */
+int quiet = 0;
+/*  error level. 0 = no error, 1 = warning, 2 = error, 4 = fatal */
+int error_level  = 0;
 
 struct er {
     long addr;
     int type;
 } *record;
+afs_int32 maxentries;
 int serveraddrs[MAXSERVERID + 2];
+u_char serverxref[MAXSERVERID + 2];  /**< to resolve cross-linked mh entries */
+int serverref[MAXSERVERID + 2];      /**< which addrs are referenced by vl entries */
 
-#if 0
-int
-writeUbikHeader()
+struct mhinfo {
+    afs_uint32 addr;                   /**< vldb file record */
+    char orphan[VL_MHSRV_PERBLK];      /**< unreferenced mh enties */
+} mhinfo[VL_MAX_ADDREXTBLKS];
+
+
+/*  Used to control what goes to stdout based on quiet flag */
+void
+quiet_println(const char *fmt,...) {
+    va_list args;
+    if (!quiet) {
+        va_start(args, fmt);
+        vfprintf(stdout, fmt, args);
+        va_end(args);
+    }
+}
+
+/*  Used to set the error level and ship messages to stderr */
+void
+log_error(int eval, const char *fmt, ...)
 {
-    /* Bump the version number?? We could cheat and push a new db... */
+    va_list args;
+    if (error_level < eval) error_level  = eval ;  /*  bump up the severity */
+    va_start(args, fmt);
+    vfprintf(stderr, fmt, args);
+    va_end(args);
+
+    if (error_level  == VLDB_CHECK_FATAL) exit(VLDB_CHECK_FATAL);
 }
-#endif
 
-#define HDRSIZE 64
+
 int
-readUbikHeader()
+readUbikHeader(void)
 {
     int offset, r;
     struct ubik_hdr uheader;
 
     offset = lseek(fd, 0, 0);
     if (offset != 0) {
-       printf("error: lseek to 0 failed: %d %d\n", offset, errno);
-       return (-1);
+       log_error(VLDB_CHECK_FATAL,"error: lseek to 0 failed: %d %d\n", offset, errno);
+       return (VLDB_CHECK_FATAL);
     }
 
     /* now read the info */
     r = read(fd, &uheader, sizeof(uheader));
     if (r != sizeof(uheader)) {
-       printf("error: read of %d bytes failed: %d %d\n", sizeof(uheader), r,
+       log_error(VLDB_CHECK_FATAL,"error: read of %lu bytes failed: %d %d\n", sizeof(uheader), r,
               errno);
-       return (-1);
+       return (VLDB_CHECK_FATAL);
     }
 
     uheader.magic = ntohl(uheader.magic);
-    uheader.size = ntohl(uheader.size);
+    uheader.size = ntohs(uheader.size);
     uheader.version.epoch = ntohl(uheader.version.epoch);
     uheader.version.counter = ntohl(uheader.version.counter);
 
     if (listuheader) {
-       printf("Ubik Header\n");
-       printf("   Magic           = 0x%x\n", uheader.magic);
-       printf("   Size            = %u\n", uheader.size);
-       printf("   Version.epoch   = %u\n", uheader.version.epoch);
-       printf("   Version.counter = %u\n", uheader.version.counter);
+       quiet_println("Ubik Header\n");
+       quiet_println("   Magic           = 0x%x\n", uheader.magic);
+       quiet_println("   Size            = %u\n", uheader.size);
+       quiet_println("   Version.epoch   = %u\n", uheader.version.epoch);
+       quiet_println("   Version.counter = %u\n", uheader.version.counter);
     }
 
     if (uheader.size != HDRSIZE)
-       printf("Ubik header size is %u (should be %u)\n", uheader.size,
+       log_error(VLDB_CHECK_WARNING,"VLDB_CHECK_WARNING: Ubik header size is %u (should be %u)\n", uheader.size,
               HDRSIZE);
     if (uheader.magic != UBIK_MAGIC)
-       printf("Ubik header magic is 0x%x (should be 0x%x)\n", uheader.magic,
+       log_error(VLDB_CHECK_ERROR,"Ubik header magic is 0x%x (should be 0x%x)\n", uheader.magic,
               UBIK_MAGIC);
 
     return (0);
 }
 
 int
-vldbio(int position, char *buffer, int size, int rdwr)
+vldbio(int position, void *buffer, int size, int rdwr)
 {
     int offset, r, p;
 
     /* seek to the correct spot. skip ubik stuff */
-    p = position + HDRSIZE;
+    p = OFFSET(position);
     offset = lseek(fd, p, 0);
     if (offset != p) {
-       printf("error: lseek to %d failed: %d %d\n", p, offset, errno);
+       log_error(VLDB_CHECK_FATAL,"error: lseek to %d failed: %d %d\n", p, offset, errno);
        return (-1);
     }
 
-    if (rdwr == 1) 
+    if (rdwr == 1)
        r = write(fd, buffer, size);
-    else 
+    else
        r = read(fd, buffer, size);
 
     if (r != size) {
-       printf("error: %s of %d bytes failed: %d %d\n", rdwr==1?"write":"read",
+       log_error(VLDB_CHECK_FATAL,"error: %s of %d bytes failed: %d %d\n", rdwr==1?"write":"read",
               size, r, errno);
        return (-1);
     }
@@ -176,9 +211,9 @@ NameHash(char *volname)
 }
 
 afs_int32
-IdHash(afs_int32 volid)
+IdHash(afs_uint32 volid)
 {
-    return ((abs(volid)) % HASHSIZE);
+    return (volid % HASHSIZE);
 }
 
 #define LEGALCHARS ".ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_"
@@ -192,15 +227,31 @@ InvalidVolname(char *volname)
     slen = strlen(volname);
     if (slen >= VL_MAXNAMELEN)
        return 1;
+    if (slen == 0)
+       return 1;
     return (slen != strspn(volname, map));
 }
 
+int
+validVolumeAddr(afs_uint32 fileOffset)
+{
+    if (ADDR(fileOffset) >= maxentries) {
+       /* Are we in range */
+       return 0;
+    }
+    /*
+     * We cannot test whether the offset is aligned
+     * since the vl entries are not in a regular array
+     */
+    return 1;
+}
+
 void
 readheader(struct vlheader *headerp)
 {
     int i, j;
 
-    vldbread(0, headerp, sizeof(*headerp));
+    vldbread(0, (char *)headerp, sizeof(*headerp));
 
     headerp->vital_header.vldbversion =
        ntohl(headerp->vital_header.vldbversion);
@@ -219,7 +270,7 @@ readheader(struct vlheader *headerp)
            ntohl(headerp->vital_header.totalEntries[1]);
 
     headerp->SIT = ntohl(headerp->SIT);
-    for (i = 0; i < MAXSERVERID; i++)
+    for (i = 0; i <= MAXSERVERID; i++)
        headerp->IpMappedAddr[i] = ntohl(headerp->IpMappedAddr[i]);
     for (i = 0; i < HASHSIZE; i++)
        headerp->VolnameHash[i] = ntohl(headerp->VolnameHash[i]);
@@ -228,36 +279,37 @@ readheader(struct vlheader *headerp)
            headerp->VolidHash[i][j] = ntohl(headerp->VolidHash[i][j]);
 
     if (listheader) {
-       printf("vldb header\n");
-       printf("   vldbversion      = %u\n",
+       quiet_println("vldb header\n");
+       quiet_println("   vldbversion      = %u\n",
               headerp->vital_header.vldbversion);
-       printf("   headersize       = %u [actual=%u]\n",
+       quiet_println("   headersize       = %u [actual=%lu]\n",
               headerp->vital_header.headersize, sizeof(*headerp));
-       printf("   freePtr          = 0x%x\n", headerp->vital_header.freePtr);
-       printf("   eofPtr           = %u\n", headerp->vital_header.eofPtr);
-       printf("   allocblock calls = %10u\n", headerp->vital_header.allocs);
-       printf("   freeblock  calls = %10u\n", headerp->vital_header.frees);
-       printf("   MaxVolumeId      = %u\n",
+       quiet_println("   freePtr          = 0x%x\n", headerp->vital_header.freePtr);
+       quiet_println("   eofPtr           = %u\n", headerp->vital_header.eofPtr);
+       quiet_println("   allocblock calls = %10u\n", headerp->vital_header.allocs);
+       quiet_println("   freeblock  calls = %10u\n", headerp->vital_header.frees);
+       quiet_println("   MaxVolumeId      = %u\n",
               headerp->vital_header.MaxVolumeId);
-       printf("   rw vol entries   = %u\n",
+       quiet_println("   rw vol entries   = %u\n",
               headerp->vital_header.totalEntries[0]);
-       printf("   ro vol entries   = %u\n",
+       quiet_println("   ro vol entries   = %u\n",
               headerp->vital_header.totalEntries[1]);
-       printf("   bk vol entries   = %u\n",
+       quiet_println("   bk vol entries   = %u\n",
               headerp->vital_header.totalEntries[2]);
-       printf("   multihome info   = 0x%x (%u)\n", headerp->SIT,
+       quiet_println("   multihome info   = 0x%x (%u)\n", headerp->SIT,
               headerp->SIT);
-       printf("   server ip addr   table: size = %d entries\n",
+       quiet_println("   server ip addr   table: size = %d entries\n",
               MAXSERVERID + 1);
-       printf("   volume name hash table: size = %d buckets\n", HASHSIZE);
-       printf("   volume id   hash table: %d tables with %d buckets each\n",
+       quiet_println("   volume name hash table: size = %d buckets\n", HASHSIZE);
+       quiet_println("   volume id   hash table: %d tables with %d buckets each\n",
               MAXTYPES, HASHSIZE);
     }
 
     /* Check the header size */
     if (headerp->vital_header.headersize != sizeof(*headerp))
-       printf("Header reports its size as %d (should be %d)\n",
+       log_error(VLDB_CHECK_WARNING,"Header reports its size as %d (should be %lu)\n",
               headerp->vital_header.headersize, sizeof(*headerp));
+    return;
 }
 
 void
@@ -282,7 +334,7 @@ writeheader(struct vlheader *headerp)
            htonl(headerp->vital_header.totalEntries[1]);
 
     headerp->SIT = htonl(headerp->SIT);
-    for (i = 0; i < MAXSERVERID; i++)
+    for (i = 0; i <= MAXSERVERID; i++)
        headerp->IpMappedAddr[i] = htonl(headerp->IpMappedAddr[i]);
     for (i = 0; i < HASHSIZE; i++)
        headerp->VolnameHash[i] = htonl(headerp->VolnameHash[i]);
@@ -290,22 +342,31 @@ writeheader(struct vlheader *headerp)
        for (j = 0; j < HASHSIZE; j++)
            headerp->VolidHash[i][j] = htonl(headerp->VolidHash[i][j]);
 
-    vldbwrite(0, headerp, sizeof(*headerp));
+    vldbwrite(0, (char *)headerp, sizeof(*headerp));
 }
 
 void
-readMH(afs_int32 addr, struct extentaddr *mhblockP)
+readMH(afs_uint32 addr, int block, struct extentaddr *mhblockP)
 {
     int i, j;
     struct extentaddr *e;
 
-    vldbread(addr, mhblockP, VL_ADDREXTBLK_SIZE);
-
-    mhblockP->ex_count = ntohl(mhblockP->ex_count);
-    mhblockP->ex_flags = ntohl(mhblockP->ex_flags);
-    for (i = 0; i < VL_MAX_ADDREXTBLKS; i++)
-       mhblockP->ex_contaddrs[i] = ntohl(mhblockP->ex_contaddrs[i]);
-
+    vldbread(addr, (char *)mhblockP, VL_ADDREXTBLK_SIZE);
+
+    /* Every mh block has the VLCONTBLOCK flag set in the header to
+     * indicate the entry is an 8192 byte extended block. The
+     * VLCONTBLOCK flag is always clear in regular vl entries. The
+     * vlserver depends on the VLCONTBLOCK flag to correctly traverse
+     * the vldb. The flags field is in network byte order. */
+    mhblockP->ex_hdrflags = ntohl(mhblockP->ex_hdrflags);
+
+    if (block == 0) {
+        /* These header fields are only used in the first mh block. */
+        mhblockP->ex_count = ntohl(mhblockP->ex_count);
+        for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
+           mhblockP->ex_contaddrs[i] = ntohl(mhblockP->ex_contaddrs[i]);
+        }
+    }
     for (i = 1; i < VL_MHSRV_PERBLK; i++) {
        e = &(mhblockP[i]);
 
@@ -314,6 +375,7 @@ readMH(afs_int32 addr, struct extentaddr *mhblockP)
        for (j = 0; j < VL_MAXIPADDRS_PERMH; j++)
            e->ex_addrs[j] = ntohl(e->ex_addrs[j]);
     }
+    return;
 }
 
 void
@@ -321,7 +383,7 @@ readentry(afs_int32 addr, struct nvlentry *vlentryp, afs_int32 *type)
 {
     int i;
 
-    vldbread(addr, vlentryp, sizeof(*vlentryp));
+    vldbread(addr, (char *)vlentryp, sizeof(*vlentryp));
 
     for (i = 0; i < MAXTYPES; i++)
        vlentryp->volumeId[i] = ntohl(vlentryp->volumeId[i]);
@@ -333,9 +395,10 @@ readentry(afs_int32 addr, struct nvlentry *vlentryp, afs_int32 *type)
        vlentryp->nextIdHash[i] = ntohl(vlentryp->nextIdHash[i]);
     vlentryp->nextNameHash = ntohl(vlentryp->nextNameHash);
     for (i = 0; i < NMAXNSERVERS; i++) {
-       vlentryp->serverNumber[i] = ntohl(vlentryp->serverNumber[i]);
-       vlentryp->serverPartition[i] = ntohl(vlentryp->serverPartition[i]);
-       vlentryp->serverFlags[i] = ntohl(vlentryp->serverFlags[i]);
+       /* make sure not to ntohl these, as they're chars, not ints */
+       vlentryp->serverNumber[i] = vlentryp->serverNumber[i];
+       vlentryp->serverPartition[i] = vlentryp->serverPartition[i];
+       vlentryp->serverFlags[i] = vlentryp->serverFlags[i];
     }
 
     if (vlentryp->flags == VLCONTBLOCK) {
@@ -347,51 +410,95 @@ readentry(afs_int32 addr, struct nvlentry *vlentryp, afs_int32 *type)
     }
 
     if (listentries) {
-       printf("address %u: ", addr);
+       quiet_println("address %u (offset 0x%0x): ", addr, OFFSET(addr));
        if (vlentryp->flags == VLCONTBLOCK) {
-           printf("mh extension block\n");
+           quiet_println("mh extension block\n");
        } else if (vlentryp->flags == VLFREE) {
-           printf("free vlentry\n");
+           quiet_println("free vlentry\n");
        } else {
-           printf("vlentry %s\n", vlentryp->name);
-           printf("   rw id = %u ; ro id = %u ; bk id = %u\n",
+           quiet_println("vlentry %s\n", vlentryp->name);
+           quiet_println("   rw id = %u ; ro id = %u ; bk id = %u\n",
                   vlentryp->volumeId[0], vlentryp->volumeId[1],
                   vlentryp->volumeId[2]);
-           printf("   flags         =");
+           quiet_println("   flags         =");
            if (vlentryp->flags & VLF_RWEXISTS)
-               printf(" rw");
+               quiet_println(" rw");
            if (vlentryp->flags & VLF_ROEXISTS)
-               printf(" ro");
+               quiet_println(" ro");
            if (vlentryp->flags & VLF_BACKEXISTS)
-               printf(" bk");
-           if (vlentryp->flags & 0xffff8fff)
-               printf(" errorflag(0x%x)", vlentryp->flags);
-           printf("\n");
-           printf("   LockAfsId     = %d\n", vlentryp->LockAfsId);
-           printf("   LockTimestamp = %d\n", vlentryp->LockTimestamp);
-           printf("   cloneId       = %u\n", vlentryp->cloneId);
-           printf
+               quiet_println(" bk");
+           if (vlentryp->flags & VLOP_MOVE)
+               quiet_println(" lock_move");
+           if (vlentryp->flags & VLOP_RELEASE)
+               quiet_println(" lock_release");
+           if (vlentryp->flags & VLOP_BACKUP)
+               quiet_println(" lock_backup");
+           if (vlentryp->flags & VLOP_DELETE)
+               quiet_println(" lock_delete");
+           if (vlentryp->flags & VLOP_DUMP)
+               quiet_println(" lock_dump");
+
+           /* all bits not covered by VLF_* and VLOP_* constants */
+           if (vlentryp->flags & 0xffff8e0f)
+               quiet_println(" errorflag(0x%x)", vlentryp->flags);
+           quiet_println("\n");
+           quiet_println("   LockAfsId     = %d\n", vlentryp->LockAfsId);
+           quiet_println("   LockTimestamp = %d\n", vlentryp->LockTimestamp);
+           quiet_println("   cloneId       = %u\n", vlentryp->cloneId);
+           quiet_println
                ("   next hash for rw = %u ; ro = %u ; bk = %u ; name = %u\n",
                 vlentryp->nextIdHash[0], vlentryp->nextIdHash[1],
                 vlentryp->nextIdHash[2], vlentryp->nextNameHash);
            for (i = 0; i < NMAXNSERVERS; i++) {
                if (vlentryp->serverNumber[i] != 255) {
-                   printf("   server %d ; partition %d ; flags =",
+                   quiet_println("   server %d ; partition %d ; flags =",
                           vlentryp->serverNumber[i],
                           vlentryp->serverPartition[i]);
                    if (vlentryp->serverFlags[i] & VLSF_RWVOL)
-                       printf(" rw");
+                       quiet_println(" rw");
                    if (vlentryp->serverFlags[i] & VLSF_ROVOL)
-                       printf(" ro");
+                       quiet_println(" ro");
                    if (vlentryp->serverFlags[i] & VLSF_BACKVOL)
-                       printf(" bk");
+                       quiet_println(" bk");
                    if (vlentryp->serverFlags[i] & VLSF_NEWREPSITE)
-                       printf(" newro");
-                   printf("\n");
+                       quiet_println(" newro");
+                   quiet_println("\n");
                }
            }
        }
     }
+    return;
+}
+
+void
+writeMH(afs_int32 addr, int block, struct extentaddr *mhblockP)
+{
+    int i, j;
+    struct extentaddr *e;
+
+    if (verbose) {
+       quiet_println("Writing back MH block % at addr %u\n", block,  addr);
+    }
+    mhblockP->ex_hdrflags = htonl(mhblockP->ex_hdrflags);
+    if (block == 0) {
+       /*
+        * These header fields are only used in the first mh block, so were
+        * converted to host byte order only when the first mh block was read.
+        */
+       mhblockP->ex_count = htonl(mhblockP->ex_count);
+       for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
+           mhblockP->ex_contaddrs[i] = htonl(mhblockP->ex_contaddrs[i]);
+       }
+    }
+    for (i = 1; i < VL_MHSRV_PERBLK; i++) {
+       e = &(mhblockP[i]);
+       /* hostuuid was not converted */
+       e->ex_uniquifier = htonl(e->ex_uniquifier);
+       for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
+           e->ex_addrs[j] = htonl(e->ex_addrs[j]);
+       }
+    }
+    vldbwrite(addr, (char *)mhblockP, VL_ADDREXTBLK_SIZE);
 }
 
 void
@@ -399,9 +506,7 @@ writeentry(afs_int32 addr, struct nvlentry *vlentryp)
 {
     int i;
 
-    if (verbose)
-       printf("Writing back entry at addr %u\n", addr);
-
+    if (verbose) quiet_println("Writing back entry at addr %u\n", addr);
     for (i = 0; i < MAXTYPES; i++)
        vlentryp->volumeId[i] = htonl(vlentryp->volumeId[i]);
     vlentryp->flags = htonl(vlentryp->flags);
@@ -412,66 +517,12 @@ writeentry(afs_int32 addr, struct nvlentry *vlentryp)
        vlentryp->nextIdHash[i] = htonl(vlentryp->nextIdHash[i]);
     vlentryp->nextNameHash = htonl(vlentryp->nextNameHash);
     for (i = 0; i < NMAXNSERVERS; i++) {
-       vlentryp->serverNumber[i] = htonl(vlentryp->serverNumber[i]);
-       vlentryp->serverPartition[i] = htonl(vlentryp->serverPartition[i]);
-       vlentryp->serverFlags[i] = htonl(vlentryp->serverFlags[i]);
-    }
-    vldbwrite(addr, vlentryp, sizeof(*vlentryp));
-}
-
-void
-readSIT(int base, int addr)
-{
-    int i, j, a;
-    char sitbuf[VL_ADDREXTBLK_SIZE];
-    struct extentaddr *extent;
-
-    if (!addr)
-       return;
-    vldbread(addr, sitbuf, VL_ADDREXTBLK_SIZE);
-    extent = (struct extentaddr *)sitbuf;
-
-    printf("multihome info block: base %d\n", base);
-    if (base == 0) {
-       printf("   count = %u\n", ntohl(extent->ex_count));
-       printf("   flags = %u\n", ntohl(extent->ex_flags));
-       for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
-           printf("   contaddrs[%d] = %u\n", i,
-                  ntohl(extent->ex_contaddrs[i]));
-       }
-    }
-    for (i = 1; i < VL_MHSRV_PERBLK; i++) {
-       /* should we skip this entry */
-       for (j = 0; j < VL_MAX_ADDREXTBLKS; j++) {
-           if (extent[i].ex_addrs[j])
-               break;
-       }
-       if (j >= VL_MAX_ADDREXTBLKS)
-           continue;
-
-       printf("   base %d index %d:\n", base, i);
-
-       printf("       afsuuid    = (%x %x %x /%d/%d/ /%x/%x/%x/%x/%x/%x/)\n",
-              ntohl(extent[i].ex_hostuuid.time_low),
-              ntohl(extent[i].ex_hostuuid.time_mid),
-              ntohl(extent[i].ex_hostuuid.time_hi_and_version),
-              ntohl(extent[i].ex_hostuuid.clock_seq_hi_and_reserved),
-              ntohl(extent[i].ex_hostuuid.clock_seq_low),
-              ntohl(extent[i].ex_hostuuid.node[0]),
-              ntohl(extent[i].ex_hostuuid.node[1]),
-              ntohl(extent[i].ex_hostuuid.node[2]),
-              ntohl(extent[i].ex_hostuuid.node[3]),
-              ntohl(extent[i].ex_hostuuid.node[4]),
-              ntohl(extent[i].ex_hostuuid.node[5]));
-       printf("       uniquifier = %u\n", ntohl(extent[i].ex_uniquifier));
-       for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
-           a = ntohl(extent[i].ex_addrs[j]);
-           if (a) {
-               printf("       %d.%d.%d.%d\n", (a >> 24) & 0xff,
-                      (a >> 16) & 0xff, (a >> 8) & 0xff, (a) & 0xff);
-           }
-       }
+       /* make sure not to htonl these, as they're chars, not ints */
+       vlentryp->serverNumber[i] =  vlentryp->serverNumber[i] ;
+       vlentryp->serverPartition[i] = vlentryp->serverPartition[i] ;
+       vlentryp->serverFlags[i] = vlentryp->serverFlags[i] ;
     }
+    vldbwrite(addr, (char *)vlentryp, sizeof(*vlentryp));
 }
 
 /*
@@ -486,19 +537,17 @@ ReadAllEntries(struct vlheader *header)
     int freecount = 0, mhcount = 0, vlcount = 0;
     int rwcount = 0, rocount = 0, bkcount = 0;
     struct nvlentry vlentry;
-    afs_uint32 addr, entrysize, maxvolid = 0;
+    afs_uint32 addr;
+    afs_uint32 entrysize = 0;
+    afs_uint32 maxvolid = 0;
 
-    if (verbose)
-       printf("Read each entry in the database\n");
+    if (verbose) quiet_println("Read each entry in the database\n");
     for (addr = header->vital_header.headersize;
         addr < header->vital_header.eofPtr; addr += entrysize) {
 
        /* Remember the highest volume id */
        readentry(addr, &vlentry, &type);
        if (type == VL) {
-           if (!(vlentry.flags & VLF_RWEXISTS))
-               printf("WARNING: VLDB entry '%s' has no RW volume\n",
-                      vlentry.name);
 
            for (i = 0; i < MAXTYPES; i++)
                if (maxvolid < vlentry.volumeId[i])
@@ -523,12 +572,12 @@ ReadAllEntries(struct vlheader *header)
                    continue;
                }
                if (e) {
-                   printf
-                       ("VLDB entry '%s' contains an unknown RW/RO index serverFlag\n",
-                        vlentry.name);
+                  log_error
+                       (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): VLDB entry '%s' contains an unknown RW/RO index serverFlag\n",
+                       addr, OFFSET(addr), vlentry.name);
                    e = 0;
                }
-               printf
+               quiet_println
                    ("   index %d : serverNumber %d : serverPartition %d : serverFlag %d\n",
                     j, vlentry.serverNumber[j], vlentry.serverPartition[j],
                     vlentry.serverFlags[j]);
@@ -537,7 +586,7 @@ ReadAllEntries(struct vlheader *header)
 
        rindex = addr / sizeof(vlentry);
        if (record[rindex].type) {
-           printf("INTERNAL ERROR: record holder %d already in use\n",
+           log_error(VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: record holder %d already in use\n",
                   rindex);
            return;
        }
@@ -555,74 +604,24 @@ ReadAllEntries(struct vlheader *header)
            entrysize = VL_ADDREXTBLK_SIZE;
            mhcount++;
        } else {
-           printf("Unknown entry at %u\n", addr);
+           log_error(VLDB_CHECK_ERROR, "address %u (offset 0x%0x): Unknown entry. Aborting\n", addr, OFFSET(addr));
+           break;
        }
     }
     if (verbose) {
-       printf("Found %d entries, %d free entries, %d multihomed blocks\n",
+       quiet_println("Found %d entries, %d free entries, %d multihomed blocks\n",
               vlcount, freecount, mhcount);
-       printf("Found %d RW volumes, %d BK volumes, %d RO volumes\n", rwcount,
+       quiet_println("Found %d RW volumes, %d BK volumes, %d RO volumes\n", rwcount,
               bkcount, rocount);
     }
 
     /* Check the maxmimum volume id in the header */
     if (maxvolid != header->vital_header.MaxVolumeId - 1)
-       printf
+       quiet_println
            ("Header's maximum volume id is %u and largest id found in VLDB is %u\n",
             header->vital_header.MaxVolumeId, maxvolid);
 }
 
-
-void
-SetHashEnd(long addr, int type, long new)
-{
-    struct nvlentry vlentry;
-    afs_int32 i, rindex, type2, next = -1;
-
-    for (; addr; addr = next) {
-       readentry(addr, &vlentry, &type2);
-       switch(type & 0xf0) {
-       case RWH:
-           next = vlentry.nextIdHash[0];
-           break;
-       case ROH:
-           next = vlentry.nextIdHash[1];
-           break;
-       case BKH:
-           next = vlentry.nextIdHash[2];
-           break;
-       case NH:
-           next = vlentry.nextNameHash;
-           break;
-       default:
-           next = -1;
-       }
-
-       if (next < 1) {
-           switch(type & 0xf0) {
-           case RWH:
-             if (vlentry.nextIdHash[0] != 0) {printf("bwoop\n");}
-               vlentry.nextIdHash[0] = new;
-               break;
-           case ROH:
-             if (vlentry.nextIdHash[1] != 0) {printf("bwoop\n");}
-               vlentry.nextIdHash[1] = new;
-               break;
-           case BKH:
-             if (vlentry.nextIdHash[2] != 0) {printf("bwoop\n");}
-               vlentry.nextIdHash[2] = new;
-               break;
-           case NH:
-             if (vlentry.nextNameHash != 0) {printf("bwoop\n");}
-               vlentry.nextNameHash = new;
-               break;
-           }
-           writeentry(addr, &vlentry);
-           return;
-       }
-    }
-}
-
 /*
  * Follow each Name hash bucket marking it as read in the record array.
  * Record we found it in the name hash within the record array.
@@ -637,33 +636,51 @@ FollowNameHash(struct vlheader *header)
     afs_int32 i, type, rindex;
 
     /* Now follow the Name Hash Table */
-    if (verbose)
-       printf("Check Volume Name Hash\n");
+    if (verbose) quiet_println("Check Volume Name Hash\n");
     for (i = 0; i < HASHSIZE; i++) {
        chainlength = 0;
+
+       if (!validVolumeAddr(header->VolnameHash[i])) {
+           log_error(VLDB_CHECK_ERROR,"Name Hash index %d is out of range: %u\n",
+                     i, header->VolnameHash[i]);
+           continue;
+       }
+
        for (addr = header->VolnameHash[i]; addr; addr = vlentry.nextNameHash) {
            readentry(addr, &vlentry, &type);
            if (type != VL) {
-               printf("Name Hash %d: Bad entry at %u: Not a valid vlentry\n",
-                      i, addr);
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Name Hash %d: Not a vlentry\n",
+                      addr, OFFSET(addr), i);
                continue;
            }
 
-           rindex = addr / sizeof(vlentry);
+           rindex = ADDR(addr);
 
+           /*
+            * we know that the address is valid because we
+            * checked it either above or below
+            */
            if (record[rindex].addr != addr && record[rindex].addr) {
-               printf
-                   ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+               log_error
+                   (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %ld and %u use same record slot %d\n",
                     record[rindex].addr, addr, rindex);
            }
            if (record[rindex].type & NH) {
-               printf
-                   ("Name Hash %d: Bad entry '%s': Already in the name hash\n",
-                    i, vlentry.name);
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Name Hash %d: volume name '%s' is already in the name hash\n",
+                    addr, OFFSET(addr), i, vlentry.name);
+               record[rindex].type |= MULTN;
+               break;
+           }
+
+           if (!validVolumeAddr(vlentry.nextNameHash)) {
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Name Hash forward link of '%s' is out of range\n",
+                         addr, OFFSET(addr), vlentry.name);
+               record[rindex].type |= MULTN;
                break;
            }
-           record[rindex].type |= NH;
 
+           record[rindex].type |= NH;
            record[rindex].type |= REFN;
 
            chainlength++;
@@ -671,9 +688,10 @@ FollowNameHash(struct vlheader *header)
 
            /* Hash the name and check if in correct hash table */
            if (NameHash(vlentry.name) != i) {
-               printf
-                   ("Name Hash %d: Bad entry '%s': Incorrect name hash chain (should be in %d)\n",
-                    i, vlentry.name, NameHash(vlentry.name));
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Name Hash %d: volume name '%s': Incorrect name hash chain (should be in %d)\n",
+                    addr, OFFSET(addr), i, vlentry.name, NameHash(vlentry.name));
+               record[rindex].type |= MULTN;
            }
        }
        if (chainlength > longest)
@@ -682,10 +700,11 @@ FollowNameHash(struct vlheader *header)
            shortest = chainlength;
     }
     if (verbose) {
-       printf
+       quiet_println
            ("%d entries in name hash, longest is %d, shortest is %d, average length is %f\n",
             count, longest, shortest, ((float)count / (float)HASHSIZE));
     }
+    return;
 }
 
 /*
@@ -699,41 +718,57 @@ FollowIdHash(struct vlheader *header)
     int count = 0, longest = 0, shortest = -1, chainlength;
     struct nvlentry vlentry;
     afs_uint32 addr;
-    afs_int32 i, j, hash, type, rindex, ref;
+    afs_int32 i, j, hash, type, rindex, ref, badref, badhash;
 
     /* Now follow the RW, RO, and BK Hash Tables */
-    if (verbose)
-       printf("Check RW, RO, and BK id Hashes\n");
+    if (verbose) quiet_println("Check RW, RO, and BK id Hashes\n");
     for (i = 0; i < MAXTYPES; i++) {
        hash = ((i == 0) ? RWH : ((i == 1) ? ROH : BKH));
        ref = ((i == 0) ? REFRW : ((i == 1) ? REFRO : REFBK));
+       badref = ((i == 0) ? MULTRW : ((i == 1) ? MULTRO : MULTBK));
+       badhash = ((i == 0) ? MULTRW : ((i == 1) ? MULTRO : MULTBK));
        count = longest = 0;
        shortest = -1;
 
        for (j = 0; j < HASHSIZE; j++) {
            chainlength = 0;
+           if (!validVolumeAddr(header->VolidHash[i][j])) {
+               log_error(VLDB_CHECK_ERROR,"%s Hash index %d is out of range: %u\n",
+                         vtype(i), j, header->VolidHash[i][j]);
+               continue;
+           }
+
            for (addr = header->VolidHash[i][j]; addr;
                 addr = vlentry.nextIdHash[i]) {
                readentry(addr, &vlentry, &type);
                if (type != VL) {
-                   printf
-                       ("%s Id Hash %d: Bad entry at %u: Not a valid vlentry\n",
-                        vtype(i), j, addr);
+                   log_error
+                       (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): %s Id Hash %d: Not a vlentry\n",
+                        addr, OFFSET(addr), vtype(i), j);
                    continue;
                }
 
-               rindex = addr / sizeof(vlentry);
+               rindex = ADDR(addr);
                if (record[rindex].addr != addr && record[rindex].addr) {
-                   printf
-                       ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
+                   log_error
+                       (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %ld and %u use same record slot %d\n",
                         record[rindex].addr, addr, rindex);
                }
                if (record[rindex].type & hash) {
-                   printf
-                       ("%s Id Hash %d: Bad entry '%s': Already in the the hash table\n",
-                        vtype(i), j, vlentry.name);
+                   log_error
+                       (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): %s Id Hash %d: volume name '%s': Already in the hash table\n",
+                        addr, OFFSET(addr), vtype(i), j, vlentry.name);
+                   record[rindex].type |= badref;
+                   break;
+               }
+
+               if (!validVolumeAddr(vlentry.nextIdHash[i])) {
+                   log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): %s Id Hash forward link of '%s' is out of range\n",
+                             addr, OFFSET(addr), vtype(i), vlentry.name);
+                   record[rindex].type |= badref;
                    break;
                }
+
                record[rindex].type |= hash;
                record[rindex].type |= ref;
 
@@ -742,10 +777,11 @@ FollowIdHash(struct vlheader *header)
 
                /* Hash the id and check if in correct hash table */
                if (IdHash(vlentry.volumeId[i]) != j) {
-                   printf
-                       ("%s Id Hash %d: Bad entry '%s': Incorrect Id hash chain (should be in %d)\n",
-                        vtype(i), j, vlentry.name,
+                  log_error
+                       (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): %s Id Hash %d: volume name '%s': Incorrect Id hash chain (should be in %d)\n",
+                        addr, OFFSET(addr), vtype(i), j, vlentry.name,
                         IdHash(vlentry.volumeId[i]));
+                   record[rindex].type |= badhash;
                }
            }
 
@@ -755,12 +791,12 @@ FollowIdHash(struct vlheader *header)
                shortest = chainlength;
        }
        if (verbose) {
-           printf
+           quiet_println
                ("%d entries in %s hash, longest is %d, shortest is %d, average length is %f\n",
-                count, vtype(i), longest, shortest,
-                ((float)count / (float)HASHSIZE));
+                count, vtype(i), longest, shortest,((float)count / (float)HASHSIZE));
        }
     }
+    return;
 }
 
 /*
@@ -776,27 +812,26 @@ FollowFreeChain(struct vlheader *header)
     afs_int32 type, rindex;
 
     /* Now follow the Free Chain */
-    if (verbose)
-       printf("Check Volume Free Chain\n");
+    if (verbose) quiet_println("Check Volume Free Chain\n");
     for (addr = header->vital_header.freePtr; addr;
         addr = vlentry.nextIdHash[0]) {
        readentry(addr, &vlentry, &type);
        if (type != FR) {
-           printf
-               ("Free Chain %d: Bad entry at %u: Not a valid free vlentry (0x%x)\n",
-                count, addr, type);
+          log_error
+               (VLDB_CHECK_ERROR,"address %u (offset 0%0x): Free Chain %d: Not a free vlentry (0x%x)\n",
+                addr, OFFSET(addr), count, type);
            continue;
        }
 
        rindex = addr / sizeof(vlentry);
        if (record[rindex].addr != addr && record[rindex].addr) {
-           printf
-               ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
-                record[rindex].addr, addr, rindex);
+          log_error
+               (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %u (0x%0x) and %ld (0x%0x) use same record slot %d\n",
+                record[rindex].addr, OFFSET(record[rindex].addr), addr, OFFSET(addr), rindex);
        }
        if (record[rindex].type & FRC) {
-           printf("Free Chain: Bad entry at %u: Already in the free chain\n",
-                  addr);
+           log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Free Chain: Already in the free chain\n",
+                  addr, OFFSET(addr));
            break;
        }
        record[rindex].type |= FRC;
@@ -804,23 +839,24 @@ FollowFreeChain(struct vlheader *header)
        count++;
     }
     if (verbose)
-       printf("%d entries on free chain\n", count);
+     quiet_println("%d entries on free chain\n", count);
+    return;
 }
 
 /*
  * Read each multihomed block and mark it as found in the record.
  * Read each entry in each multihomed block and mark the serveraddrs
  * array with the number of ip addresses found for this entry.
- * 
+ *
  * Then read the IpMappedAddr array in the header.
  * Verify that multihomed entries base and index are valid and points to
  * a good multhomed entry.
  * Mark the serveraddrs array with 1 ip address for regular entries.
- * 
- * By the end, the severaddrs array will have a 0 if the entry has no 
+ *
+ * By the end, the severaddrs array will have a 0 if the entry has no
  * IP addresses in it or the count of the number of IP addresses.
  *
- * The code does not verify if there are duplicate IP addresses in the 
+ * The code does not verify if there are duplicate IP addresses in the
  * list. The vlserver does this when a fileserver registeres itself.
  */
 void
@@ -829,7 +865,6 @@ CheckIpAddrs(struct vlheader *header)
     int mhblocks = 0;
     afs_int32 i, j, m, rindex;
     afs_int32 mhentries, regentries;
-    afs_int32 caddrs[VL_MAX_ADDREXTBLKS];
     char mhblock[VL_ADDREXTBLK_SIZE];
     struct extentaddr *MHblock = (struct extentaddr *)mhblock;
     struct extentaddr *e;
@@ -839,86 +874,87 @@ CheckIpAddrs(struct vlheader *header)
     memset(&nulluuid, 0, sizeof(nulluuid));
 
     if (verbose)
-       printf("Check Multihomed blocks\n");
+       quiet_println("Check Multihomed blocks\n");
 
     if (header->SIT) {
-       /* Read the first MH block and from it, gather the 
+       /* Read the first MH block and from it, gather the
         * addresses of all the mh blocks.
         */
-       readMH(header->SIT, MHblock);
-       if (MHblock->ex_flags != VLCONTBLOCK) {
-           printf
-               ("Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
-                header->SIT);
+       readMH(header->SIT, 0, MHblock);
+       if (MHblock->ex_hdrflags != VLCONTBLOCK) {
+          log_error
+               (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Multihomed Block 0: Not a multihomed block\n",
+                header->SIT, OFFSET(header->SIT));
        }
 
        for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
-           caddrs[i] = MHblock->ex_contaddrs[i];
+           mhinfo[i].addr = MHblock->ex_contaddrs[i];
        }
 
-       if (header->SIT != caddrs[0]) {
-           printf
-               ("MH block does not point to self %u in header, %u in block\n",
-                header->SIT, caddrs[0]);
+       if (header->SIT != mhinfo[0].addr) {
+          log_error
+               (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): MH block does not point to self in header, %u in block\n",
+                header->SIT, OFFSET(header->SIT), mhinfo[0].addr);
        }
 
        /* Now read each MH block and record it in the record array */
        for (i = 0; i < VL_MAX_ADDREXTBLKS; i++) {
-           if (!caddrs[i])
+           if (!mhinfo[i].addr)
                continue;
 
-           readMH(caddrs[i], MHblock);
-           if (MHblock->ex_flags != VLCONTBLOCK) {
-               printf
-                   ("Multihomed Block 0: Bad entry at %u: Not a valid multihomed block\n",
-                    header->SIT);
+           readMH(mhinfo[i].addr, i, MHblock);
+           if (MHblock->ex_hdrflags != VLCONTBLOCK) {
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Multihomed Block %d: Not a multihomed block\n",
+                    mhinfo[i].addr, OFFSET(mhinfo[i].addr), i);
            }
 
-           rindex = caddrs[i] / sizeof(vlentry);
-           if (record[rindex].addr != caddrs[i] && record[rindex].addr) {
-               printf
-                   ("INTERNAL ERROR: addresses %u and %u use same record slot %d\n",
-                    record[rindex].addr, caddrs[i], rindex);
+           rindex = mhinfo[i].addr / sizeof(vlentry);
+           if (record[rindex].addr != mhinfo[i].addr && record[rindex].addr) {
+               log_error
+                   (VLDB_CHECK_ERROR,"INTERNAL VLDB_CHECK_ERROR: addresses %u (0x%0x) and %u (0x%0x) use same record slot %d\n",
+                    record[rindex].addr, OFFSET(record[rindex].addr), mhinfo[i].addr, OFFSET(mhinfo[i].addr), rindex);
            }
            if (record[rindex].type & FRC) {
-               printf
-                   ("MH Blocks Chain %d: Bad entry at %u: Already a MH block\n",
-                    i, record[rindex].addr);
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): MH Blocks Chain %d: Already a MH block\n",
+                    record[rindex].addr, OFFSET(record[rindex].addr), i);
                break;
            }
            record[rindex].type |= MHC;
 
            mhblocks++;
 
-           /* Read each entry in a multihomed block. 
+           /* Read each entry in a multihomed block.
             * Find the pointer to the entry in the IpMappedAddr array and
             * verify that the entry is good (has IP addresses in it).
             */
            mhentries = 0;
            for (j = 1; j < VL_MHSRV_PERBLK; j++) {
+               int first_ipindex = -1;
                e = (struct extentaddr *)&(MHblock[j]);
 
-               /* Search the IpMappedAddr array for the reference to this entry */
-               for (ipindex = 0; ipindex < MAXSERVERID; ipindex++) {
-                   if (((header->IpMappedAddr[ipindex] & 0xff000000) ==
-                        0xff000000)
-                       &&
-                       (((header->
-                          IpMappedAddr[ipindex] & 0x00ff0000) >> 16) == i)
-                       && ((header->IpMappedAddr[ipindex] & 0x0000ffff) ==
-                           j)) {
-                       break;
+               /* Search the IpMappedAddr array for all the references to this entry. */
+               /* Use the first reference for checking the ip addresses of this entry. */
+               for (ipindex = 0; ipindex <= MAXSERVERID; ipindex++) {
+                   if (((header->IpMappedAddr[ipindex] & 0xff000000) == 0xff000000)
+                       && (((header-> IpMappedAddr[ipindex] & 0x00ff0000) >> 16) == i)
+                       && ((header->IpMappedAddr[ipindex] & 0x0000ffff) == j)) {
+                       if (first_ipindex == -1) {
+                           first_ipindex = ipindex;
+                       } else {
+                           serverxref[ipindex] = first_ipindex;
+                       }
                    }
                }
-               if (ipindex >= MAXSERVERID)
-                   ipindex = -1;
-               else
+               ipindex = first_ipindex;
+               if (ipindex != -1)
                    serveraddrs[ipindex] = -1;
 
                if (memcmp(&e->ex_hostuuid, &nulluuid, sizeof(afsUUID)) == 0) {
                    if (ipindex != -1) {
-                       printf
-                           ("Server Addrs index %d references null MH block %d, index %d\n",
+                       log_error
+                           (VLDB_CHECK_ERROR,"Server Addrs index %d references null MH block %d, index %d\n",
                             ipindex, i, j);
                        serveraddrs[ipindex] = 0;       /* avoids printing 2nd error below */
                    }
@@ -936,8 +972,9 @@ CheckIpAddrs(struct vlheader *header)
                if (ipaddrs) {
                    mhentries++;
                    if (ipindex == -1) {
-                       printf
-                           ("MH block %d, index %d: Not referenced by server addrs\n",
+                       mhinfo[i].orphan[j] = 1;
+                       log_error
+                           (VLDB_CHECK_ERROR,"MH block %d, index %d: Not referenced by server addrs\n",
                             i, j);
                    } else {
                        serveraddrs[ipindex] = ipaddrs; /* It is good */
@@ -945,33 +982,33 @@ CheckIpAddrs(struct vlheader *header)
                }
 
                if (listservers && ipaddrs) {
-                   printf("MH block %d, index %d:", i, j);
+                   quiet_println("MH block %d, index %d:", i, j);
                    for (m = 0; m < VL_MAXIPADDRS_PERMH; m++) {
                        if (!e->ex_addrs[m])
                            continue;
-                       printf(" %d.%d.%d.%d",
+                       quiet_println(" %d.%d.%d.%d",
                               (e->ex_addrs[m] & 0xff000000) >> 24,
                               (e->ex_addrs[m] & 0x00ff0000) >> 16,
                               (e->ex_addrs[m] & 0x0000ff00) >> 8,
                               (e->ex_addrs[m] & 0x000000ff));
                    }
-                   printf("\n");
+                   quiet_println("\n");
                }
            }
 /*
  *      if (mhentries != MHblock->ex_count) {
- *        printf("MH blocks says it has %d entries (found %d)\n",
+ *        quiet_println("MH blocks says it has %d entries (found %d)\n",
  *               MHblock->ex_count, mhentries);
  *     }
  */
        }
     }
     if (verbose)
-       printf("%d multihomed blocks\n", mhblocks);
+       quiet_println("%d multihomed blocks\n", mhblocks);
 
     /* Check the server addresses */
     if (verbose)
-       printf("Check server addresses\n");
+       quiet_println("Check server addresses\n");
     mhentries = regentries = 0;
     for (i = 0; i <= MAXSERVERID; i++) {
        if (header->IpMappedAddr[i]) {
@@ -979,22 +1016,36 @@ CheckIpAddrs(struct vlheader *header)
                mhentries++;
                if (((header->IpMappedAddr[i] & 0x00ff0000) >> 16) >
                    VL_MAX_ADDREXTBLKS)
-                   printf
-                       ("IP Addr for entry %d: Multihome block is bad (%d)\n",
+                  log_error
+                       (VLDB_CHECK_ERROR,"IP Addr for entry %d: Multihome block is bad (%d)\n",
+                        i, ((header->IpMappedAddr[i] & 0x00ff0000) >> 16));
+               if (mhinfo[(header->IpMappedAddr[i] & 0x00ff0000) >> 16].addr == 0)
+                   log_error(VLDB_CHECK_ERROR,"IP Addr for entry %d: No such multihome block (%d)\n",
                         i, ((header->IpMappedAddr[i] & 0x00ff0000) >> 16));
                if (((header->IpMappedAddr[i] & 0x0000ffff) > VL_MHSRV_PERBLK)
                    || ((header->IpMappedAddr[i] & 0x0000ffff) < 1))
-                   printf
-                       ("IP Addr for entry %d: Multihome index is bad (%d)\n",
+                   log_error
+                       (VLDB_CHECK_ERROR,"IP Addr for entry %d: Multihome index is bad (%d)\n",
                         i, (header->IpMappedAddr[i] & 0x0000ffff));
                if (serveraddrs[i] == -1) {
-                   printf
-                       ("warning: IP Addr for entry %d: Multihome entry has no ip addresses\n",
+                   log_error
+                       (VLDB_CHECK_WARNING,"warning: IP Addr for entry %d: Multihome entry has no ip addresses\n",
                         i);
                    serveraddrs[i] = 0;
                }
+               if (serverxref[i] != BADSERVERID) {
+                   log_error
+                       (VLDB_CHECK_WARNING,
+                       "warning: MH block %d, index %d is cross-linked by server numbers %d and %d.\n",
+                       (header->IpMappedAddr[i] & 0x00ff0000) >> 16,
+                       (header->IpMappedAddr[i] & 0x0000ffff),
+                       i, serverxref[i]);
+                   /* set addresses found/not found for this server number,
+                    * using the first index to the mh we found above. */
+                   serveraddrs[i] = serveraddrs[serverxref[i]];
+               }
                if (listservers) {
-                   printf("   Server ip addr %d = MH block %d, index %d\n",
+                   quiet_println("   Server ip addr %d = MH block %d, index %d\n",
                           i, (header->IpMappedAddr[i] & 0x00ff0000) >> 16,
                           (header->IpMappedAddr[i] & 0x0000ffff));
                }
@@ -1002,7 +1053,7 @@ CheckIpAddrs(struct vlheader *header)
                regentries++;
                serveraddrs[i] = 1;     /* It is good */
                if (listservers) {
-                   printf("   Server ip addr %d = %d.%d.%d.%d\n", i,
+                   quiet_println("   Server ip addr %d = %d.%d.%d.%d\n", i,
                           (header->IpMappedAddr[i] & 0xff000000) >> 24,
                           (header->IpMappedAddr[i] & 0x00ff0000) >> 16,
                           (header->IpMappedAddr[i] & 0x0000ff00) >> 8,
@@ -1012,41 +1063,154 @@ CheckIpAddrs(struct vlheader *header)
        }
     }
     if (verbose) {
-       printf("%d simple entries, %d multihomed entries, Total = %d\n",
+       quiet_println("%d simple entries, %d multihomed entries, Total = %d\n",
               regentries, mhentries, mhentries + regentries);
     }
+    return;
+}
+
+char *
+nameForAddr(afs_uint32 addr, int hashtype, afs_uint32 *hash, char *buffer)
+{
+    /*
+     * We need to simplify the reporting, while retaining
+     * legible messages.  This is a helper function.  The return address
+     * is either a fixed char or the provided buffer - so don't use the
+     * name after the valid lifetime of the buffer.
+     */
+    afs_int32 type;
+    struct nvlentry entry;
+    if (!addr) {
+       /* Distinguished, invalid, hash */
+       *hash = 0xFFFFFFFF;
+       return "empty";
+    } else if (!validVolumeAddr(addr)) {
+       /* Different, invalid, hash */
+       *hash = 0XFFFFFFFE;
+       return "invalid";
+    }
+    readentry(addr, &entry, &type);
+    if (VL != type) {
+       *hash = 0XFFFFFFFE;
+       return "invalid";
+    }
+    if (hashtype >= MAXTYPES) {
+       *hash = NameHash(entry.name);
+    } else {
+       *hash = IdHash(entry.volumeId[hashtype]);
+    }
+    sprintf(buffer, "for '%s'", entry.name);
+    return buffer;
+}
+
+void
+reportHashChanges(struct vlheader *header, afs_uint32 oldnamehash[HASHSIZE], afs_uint32 oldidhash[MAXTYPES][HASHSIZE])
+{
+    int i, j;
+    afs_uint32 oldhash, newhash;
+    char oldNameBuffer[10 + VL_MAXNAMELEN];
+    char newNameBuffer[10 + VL_MAXNAMELEN];
+    char *oldname, *newname;
+    /*
+     * report hash changes
+     */
+
+    for (i = 0; i < HASHSIZE; i++) {
+       if (oldnamehash[i] != header->VolnameHash[i]) {
+
+           oldname = nameForAddr(oldnamehash[i], MAXTYPES, &oldhash, oldNameBuffer);
+           newname = nameForAddr(header->VolnameHash[i], MAXTYPES, &newhash, newNameBuffer);
+           if (verbose || (oldhash != newhash)) {
+               quiet_println("FIX: Name hash header at %d was %s, is now %s\n", i, oldname, newname);
+           }
+       }
+       for (j = 0; j < MAXTYPES; j++) {
+           if (oldidhash[j][i] != header->VolidHash[j][i]) {
 
+               oldname = nameForAddr(oldidhash[j][i], j, &oldhash, oldNameBuffer);
+               newname = nameForAddr(header->VolidHash[j][i], j, &newhash, newNameBuffer);
+               if (verbose || (oldhash != newhash)) {
+                   quiet_println("FIX: %s hash header at %d was %s, is now %s\n", vtype(j), i, oldname, newname);
+               }
+           }
+       }
+    }
 }
 
-void 
-FixBad(afs_uint32 idx, afs_uint32 addr, afs_uint32 type, afs_uint32 tmp, 
-       struct nvlentry *vlentry) {
-    SetHashEnd(addr, type, tmp);
-    printf("linked unlinked chain %u (index %d) to end of chain\n", 
-          tmp, ADDR(tmp));
+/**
+ * Remove unreferenced, duplicate multi-home address indices.
+ *
+ * Removes entries from IpMappedAddr which where found to be
+ * duplicates. Only entries which are not referenced by vl entries
+ * are removed on this pass.
+ *
+ * @param[inout] header the vldb header to be updated.
+ */
+void
+removeCrossLinkedAddresses(struct vlheader *header)
+{
+    int i;
+
+    for (i = 0; i <= MAXSERVERID; i++) {
+       if (serverref[i] == 0
+           && (header->IpMappedAddr[i] & 0xff000000) == 0xff000000
+           && serverxref[i] != BADSERVERID) {
+           if (serverxref[i] == i) {
+               log_error(VLDB_CHECK_ERROR,
+                         "INTERNAL VLDB_CHECK_ERROR: serverxref points to self; index %d\n",
+                         i);
+           } else if (header->IpMappedAddr[serverxref[i]] == 0) {
+               log_error(VLDB_CHECK_ERROR,
+                         "INTERNAL VLDB_CHECK_ERROR: serverxref points to empty addr; index %d, value %d\n",
+                         i, serverxref[i]);
+           } else if (header->IpMappedAddr[serverxref[i]] != header->IpMappedAddr[i]) {
+               log_error(VLDB_CHECK_ERROR,
+                         "INTERNAL VLDB_CHECK_ERROR: invalid serverxref; index %d, value %d\n",
+                         i, serverxref[i]);
+           } else {
+               quiet_println
+                   ("FIX: Removing unreferenced address index %d, which cross-links MH block %d, index %d\n",
+                    i, (header->IpMappedAddr[i] & 0x00ff0000) >> 16,
+                    (header->IpMappedAddr[i] & 0x0000ffff));
+               header->IpMappedAddr[i] = 0;
+           }
+       }
+    }
 }
 
 int
-WorkerBee(struct cmd_syndesc *as, char *arock)
+WorkerBee(struct cmd_syndesc *as, void *arock)
 {
     char *dbfile;
-    afs_int32 maxentries, type, tmp;
+    afs_int32 type;
     struct vlheader header;
-    struct nvlentry vlentry;
-    int i, j, help = 0;
+    struct nvlentry vlentry, vlentry2;
+    int i, j, k;
+    afs_uint32 oldnamehash[HASHSIZE];
+    afs_uint32 oldidhash[MAXTYPES][HASHSIZE];
 
+    error_level = 0;  /*  start clean with no error status */
     dbfile = as->parms[0].items->data; /* -database */
     listuheader = (as->parms[1].items ? 1 : 0);        /* -uheader  */
     listheader = (as->parms[2].items ? 1 : 0); /* -vheader  */
     listservers = (as->parms[3].items ? 1 : 0);        /* -servers  */
     listentries = (as->parms[4].items ? 1 : 0);        /* -entries  */
     verbose = (as->parms[5].items ? 1 : 0);    /* -verbose  */
-    fix = (as->parms[6].items ? 1 : 0);        /* -fix  */
+    quiet = (as->parms[6].items ? 1 : 0);  /* -quiet */
+    fix = (as->parms[7].items ? 1 : 0);    /* -fix  */
+
+    /* sanity check */
+    if (quiet && (verbose || listuheader || listheader ||listservers \
+                || listentries)) {
+        log_error(VLDB_CHECK_FATAL," -quiet cannot be used other display flags\n");
+        return VLDB_CHECK_FATAL;
+    }
+
 
     /* open the vldb database file */
     fd = open(dbfile, (fix > 0)?O_RDWR:O_RDONLY, 0);
     if (fd < 0) {
-       printf("can't open file '%s'. error = %d\n", dbfile, errno);
+       log_error(VLDB_CHECK_FATAL,"can't open file '%s'. error = %d\n", dbfile, errno);
        return 0;
     }
 
@@ -1054,14 +1218,18 @@ WorkerBee(struct cmd_syndesc *as, char *arock)
     readUbikHeader();
     readheader(&header);
     if (header.vital_header.vldbversion < 3) {
-       printf("does not support vldb with version less than 3\n");
-       return 0;
+       log_error(VLDB_CHECK_FATAL,"does not support vldb with version less than 3\n");
+       return VLDB_CHECK_FATAL;
     }
 
     maxentries = (header.vital_header.eofPtr / sizeof(vlentry)) + 1;
-    record = (struct er *)malloc(maxentries * sizeof(struct er));
-    memset((char *)record, 0, (maxentries * sizeof(struct er)));
-    memset((char *)serveraddrs, 0, sizeof(serveraddrs));
+    record = calloc(maxentries, sizeof(struct er));
+    memset(serveraddrs, 0, sizeof(serveraddrs));
+    memset(mhinfo, 0, sizeof(mhinfo));
+    memset(serverref, 0, sizeof(serverref));
+    for (i = 0; i <= MAXSERVERID; i++) {
+       serverxref[i] = BADSERVERID;
+    }
 
     /* Will fill in the record array of entries it found */
     ReadAllEntries(&header);
@@ -1079,18 +1247,16 @@ WorkerBee(struct cmd_syndesc *as, char *arock)
     /* Follow the chain of free entries */
     FollowFreeChain(&header);
 
-    /* Now check the record we have been keeping for inconsistancies
-     * For valid vlentries, also check that the server we point to is 
+    /* Now check the record we have been keeping for inconsistencies
+     * For valid vlentries, also check that the server we point to is
      * valid (the serveraddrs array).
      */
     if (verbose)
-       printf("Verify each volume entry\n");
+       quiet_println("Verify each volume entry\n");
     for (i = 0; i < maxentries; i++) {
-       int nextp;
-       int reft;
-       int hash;
-       int *nextpp;
-       char *which;
+       int hash = 0;
+        int nexthash = 0;
+       char *which = NULL;
 
        if (record[i].type == 0)
            continue;
@@ -1100,169 +1266,376 @@ WorkerBee(struct cmd_syndesc *as, char *arock)
         */
        if (record[i].type & VL) {
            int foundbad = 0;
+           int foundbroken = 0;
            char volidbuf[256];
 
            readentry(record[i].addr, &vlentry, &type);
 
+           if (!(vlentry.flags & VLF_RWEXISTS))
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s' (%u) has no RW volume\n",
+                      record[i].addr, OFFSET(record[i].addr), vlentry.name, vlentry.volumeId[0]);
+
            if (InvalidVolname(vlentry.name))
-               printf("Volume '%s' at addr %u has an invalid name\n",
-                      vlentry.name, record[i].addr);
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s' (%u) has an invalid name\n",
+                      record[i].addr, OFFSET(record[i].addr), vlentry.name, vlentry.volumeId[0]);
+
+           if (vlentry.volumeId[0] == 0)
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s' (%u) has an invalid volume id\n",
+                      record[i].addr, OFFSET(record[i].addr), vlentry.name, vlentry.volumeId[0]);
 
            if (!(record[i].type & NH)) {
-               nextp = ADDR(vlentry.nextNameHash);
-               reft = REFN;
                hash = NameHash(vlentry.name);
-               nextpp = &vlentry.nextNameHash;
                which = "name";
-               sprintf(volidbuf, "");
+               volidbuf[0]='\0';
                foundbad = 1;
            }
 
            if (vlentry.volumeId[0] && !(record[i].type & RWH)) {
-               nextp = ADDR(vlentry.nextIdHash[0]);
-               reft = REFRW;
                hash = IdHash(vlentry.volumeId[0]);
-               nextpp = &(vlentry.nextIdHash[0]);
                which = "RW";
                sprintf(volidbuf, "id %u ", vlentry.volumeId[0]);
                foundbad = 1;
            }
 
            if (vlentry.volumeId[1] && !(record[i].type & ROH)) {
-               nextp = ADDR(vlentry.nextIdHash[1]);
-               reft = REFRO;
                hash = IdHash(vlentry.volumeId[1]);
-               nextpp = &(vlentry.nextIdHash[1]);
                which = "RO";
                sprintf(volidbuf, "id %u ", vlentry.volumeId[1]);
                foundbad = 1;
            }
 
            if (vlentry.volumeId[2] && !(record[i].type & BKH)) {
-               nextp = ADDR(vlentry.nextIdHash[2]);
-               reft = REFBK;
                hash = IdHash(vlentry.volumeId[2]);
-               nextpp = &(vlentry.nextIdHash[2]);
                which = "BK";
                sprintf(volidbuf, "id %u ", vlentry.volumeId[2]);
                foundbad = 1;
            }
 
-           if (foundbad) {
-               printf("%d: Volume '%s' %snot found in %s hash %d", i, 
-                      vlentry.name, volidbuf, which, hash);
-               if (nextp) {
-                   printf(" (next %d", nextp);
-                   if (!(record[nextp].type & reft)) {
-                       printf(" not in chain ");
-                       record[nextp].type |= reft;
-                   } else if (nextp != 0) {
-                       printf(" next in chain");
-                       if (fix) {
-                           printf(", unchaining");
-                           *nextpp = 0;
-                           writeentry(record[i].addr, &vlentry);
-                       }
-                   }
-                   printf(")");
+           if (!validVolumeAddr(vlentry.nextNameHash) ||
+               record[ADDR(vlentry.nextNameHash)].type & MULTN) {
+               hash = NameHash(vlentry.name);
+               which = "name";
+               volidbuf[0]='\0';
+               if (validVolumeAddr(vlentry.nextNameHash)) {
+                   readentry(vlentry.nextNameHash, &vlentry2, &type);
+                   nexthash = NameHash(vlentry2.name);
+               } else {
+                   nexthash = 0xFFFFFFFF;
+               }
+               if (hash != nexthash)
+                   foundbroken = 1;
+           }
+
+           if (!validVolumeAddr(vlentry.nextIdHash[0]) ||
+               record[ADDR(vlentry.nextIdHash[0])].type & MULTRW) {
+               hash = IdHash(vlentry.volumeId[0]);
+               which = "RW";
+               sprintf(volidbuf, "id %u ", vlentry.volumeId[0]);
+               if (validVolumeAddr(vlentry.nextIdHash[0])) {
+                   readentry(vlentry.nextIdHash[0], &vlentry2, &type);
+                   nexthash = IdHash(vlentry2.volumeId[0]);
+               } else {
+                   nexthash = 0xFFFFFFFF;
                }
-               printf("\n");
+               if (hash != nexthash)
+                   foundbroken = 1;
            }
-       
+
+           if (!validVolumeAddr(vlentry.nextIdHash[1]) ||
+               record[ADDR(vlentry.nextIdHash[1])].type & MULTRO) {
+               hash = IdHash(vlentry.volumeId[1]);
+               which = "RO";
+               sprintf(volidbuf, "id %u ", vlentry.volumeId[1]);
+               if (validVolumeAddr(vlentry.nextIdHash[1])) {
+                   readentry(vlentry.nextIdHash[1], &vlentry2, &type);
+                   nexthash = IdHash(vlentry2.volumeId[1]);
+               } else {
+                   nexthash = 0xFFFFFFFF;
+               }
+               if (hash != nexthash)
+                   foundbroken = 1;
+           }
+
+           if (!validVolumeAddr(vlentry.nextIdHash[2]) ||
+               record[ADDR(vlentry.nextIdHash[2])].type & MULTBK) {
+               hash = IdHash(vlentry.volumeId[2]);
+               which = "BK";
+               sprintf(volidbuf, "id %u ", vlentry.volumeId[2]);
+               if (validVolumeAddr(vlentry.nextIdHash[2])) {
+                   readentry(vlentry.nextIdHash[2], &vlentry2, &type);
+                   nexthash = IdHash(vlentry2.volumeId[2]);
+               } else {
+                   nexthash = 0xFFFFFFFF;
+               }
+               if (hash != nexthash)
+                   foundbroken = 1;
+           }
+
+           if (foundbroken) {
+               log_error(VLDB_CHECK_ERROR,
+                       "address %u (offset 0x%0x): Volume '%s' %s forward link in %s hash chain is broken (hash %d != %d)\n",
+                       record[i].addr, OFFSET(record[i].addr),
+                       vlentry.name, volidbuf, which, hash, nexthash);
+           } else if (foundbad) {
+               log_error(VLDB_CHECK_ERROR,
+                       "address %u (offset 0x%0x): Volume '%s' %snot found in %s hash %d\n",
+                       record[i].addr, OFFSET(record[i].addr),
+                       vlentry.name, volidbuf, which, hash);
+           }
+
            for (j = 0; j < NMAXNSERVERS; j++) {
-               if ((vlentry.serverNumber[j] != 255)
-                   && (serveraddrs[vlentry.serverNumber[j]] == 0)) {
-                   printf
-                       ("Volume '%s', index %d points to empty server entry %d\n",
-                        vlentry.name, j, vlentry.serverNumber[j]);
+               if (vlentry.serverNumber[j] != BADSERVERID) {
+                   serverref[vlentry.serverNumber[j]] = 1;
+                   if (serveraddrs[vlentry.serverNumber[j]] == 0) {
+                       log_error
+                           (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s', index %d points to empty server entry %d\n",
+                            record[i].addr, OFFSET(record[i].addr), vlentry.name, j, vlentry.serverNumber[j]);
+                   } else if (serverxref[vlentry.serverNumber[j]] != BADSERVERID) {
+                           log_error
+                           (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s', index %d points to server entry %d, which is cross-linked by %d\n",
+                            record[i].addr, OFFSET(record[i].addr), vlentry.name, j, vlentry.serverNumber[j], serverxref[vlentry.serverNumber[j]]);
+                   }
                }
            }
-       
+
            if (record[i].type & 0xffff0f00)
-               printf
-                   ("Volume '%s' id %u also found on other chains (0x%x)\n",
-                    vlentry.name, vlentry.volumeId[0], record[i].type);
-           
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Volume '%s' id %u also found on other chains (0x%x)\n",
+                    record[i].addr, OFFSET(record[i].addr), vlentry.name, vlentry.volumeId[0], record[i].type);
+
            /* A free entry */
        } else if (record[i].type & FR) {
            if (!(record[i].type & FRC))
-               printf("Free vlentry at %u not on free chain\n",
-                      record[i].addr);
-           
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Free vlentry not on free chain\n",
+                      record[i].addr, OFFSET(record[i].addr));
+
            if (record[i].type & 0xfffffdf0)
-               printf
-                   ("Free vlentry at %u also found on other chains (0x%x)\n",
-                    record[i].addr, record[i].type);
-           
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Free vlentry also found on other chains (0x%x)\n",
+                    record[i].addr, OFFSET(record[i].addr), record[i].type);
+
            /* A multihomed entry */
        } else if (record[i].type & MH) {
            if (!(record[i].type & MHC))
-               printf("Multihomed block at %u is orphaned\n",
-                      record[i].addr);
-           
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Multihomed block is orphaned\n",
+                      record[i].addr, OFFSET(record[i].addr));
+
            if (record[i].type & 0xfffffef0)
-               printf
-                   ("Multihomed block at %u also found on other chains (0x%x)\n",
-                    record[i].addr, record[i].type);
-           
+               log_error
+                   (VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Multihomed block also found on other chains (0x%x)\n",
+                    record[i].addr, OFFSET(record[i].addr), record[i].type);
+
        } else {
-           printf("Unknown entry type at %u (0x%x)\n", record[i].addr,
-                  record[i].type);
+           log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Unknown entry type 0x%x\n",
+                  record[i].addr, OFFSET(record[i].addr), record[i].type);
        }
     }
 
-    /* By the time we get here, unchained entries are really unchained */
-    printf("Scanning %u entries for possible repairs\n", maxentries);
+    if (fix) {
+       /*
+        * If we are fixing we will rebuild the free and hash lists from the ground up.
+        */
+       header.vital_header.freePtr = 0;
+       memcpy(oldnamehash, header.VolnameHash, sizeof(oldnamehash));
+       memset(header.VolnameHash, 0, sizeof(header.VolnameHash));
+
+       memcpy(oldidhash, header.VolidHash, sizeof(oldidhash));
+       memset(header.VolidHash, 0, sizeof(header.VolidHash));
+       quiet_println("Rebuilding %u entries\n", maxentries);
+    } else {
+       quiet_println("Scanning %u entries for possible repairs\n", maxentries);
+    }
     for (i = 0; i < maxentries; i++) {
+       afs_uint32 hash;
        if (record[i].type & VL) {
            readentry(record[i].addr, &vlentry, &type);
-           if (!(record[i].type & REFN) && (strlen(vlentry.name)>0)) {
-               printf("%d: Record %u (type 0x%x) not in a name chain\n", i, 
-                      record[i].addr, record[i].type);
-               if (fix) {
-                   if (header.VolnameHash[NameHash(vlentry.name)] == 0)
-                       header.VolnameHash[NameHash(vlentry.name)] = record[i].addr;
-                   else
-                       FixBad(i, header.VolnameHash[NameHash(vlentry.name)], NH, record[i].addr, &vlentry);
-               }
+           if (!(record[i].type & REFN)) {
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Record is not in a name chain (type 0x%0x)\n",
+                      record[i].addr, OFFSET(record[i].addr), record[i].type);
            }
            if (vlentry.volumeId[0] && !(record[i].type & REFRW)) {
-               printf("%d: Record %u (type 0x%x) not in a RW chain\n", i,
-                      record[i].addr, record[i].type);
-               if (fix) {
-                   if (header.VolidHash[0][IdHash(vlentry.volumeId[0])] == 0)
-                       header.VolidHash[0][IdHash(vlentry.volumeId[0])] = record[i].addr;
-                   else
-                       FixBad(i, header.VolidHash[0][IdHash(vlentry.volumeId[0])], RWH, record[i].addr, &vlentry);
-               }
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Record not in a RW chain (type 0x%0x)\n",
+                      record[i].addr, OFFSET(record[i].addr), record[i].type);
            }
            if (vlentry.volumeId[1] && !(record[i].type & REFRO)) {
-               printf("%d: Record %u (type 0x%x) not in a RO chain\n", i, 
-                      record[i].addr, record[i].type);
-               if (fix) {
-                   if (header.VolidHash[1][IdHash(vlentry.volumeId[1])] == 0)
-                       header.VolidHash[1][IdHash(vlentry.volumeId[1])] = record[i].addr;
-                   else
-                       FixBad(i, header.VolidHash[1][IdHash(vlentry.volumeId[1])], ROH, record[i].addr, &vlentry);
-               }
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Record not in a RO chain (type 0x%0x)\n",
+                      record[i].addr, OFFSET(record[i].addr), record[i].type);
            }
            if (vlentry.volumeId[2] && !(record[i].type & REFBK)) {
-               printf("%d: Record %u (type 0x%x) not in a BK chain\n", i, 
-                      record[i].addr, record[i].type);
-               if (fix) {
-                   if (header.VolidHash[2][IdHash(vlentry.volumeId[2])] == 0)
-                       header.VolidHash[2][IdHash(vlentry.volumeId[2])] = record[i].addr;
-                   else
-                       FixBad(i, header.VolidHash[2][IdHash(vlentry.volumeId[2])], BKH, record[i].addr, &vlentry);
+               log_error(VLDB_CHECK_ERROR,"address %u (offset 0x%0x): Record not in a BK chain (type 0x%0x)\n",
+                      record[i].addr, OFFSET(record[i].addr), record[i].type);
+           }
+           if ((vlentry.LockTimestamp == 0 && (vlentry.flags & VLOP_ALLOPERS) != 0) ||
+              (vlentry.LockTimestamp != 0 && (vlentry.flags & VLOP_ALLOPERS) == 0)) {
+               log_error(VLDB_CHECK_ERROR,
+                   "address %u (offset 0x%0x): Lock inconsistency in volume '%s'; timestamp %d, lock flags 0x%0x\n",
+                   record[i].addr, OFFSET(record[i].addr), vlentry.name,
+                   vlentry.LockTimestamp, (vlentry.flags & VLOP_ALLOPERS));
+           }
+
+           if (fix) {
+               afs_uint32 oldhash, newhash;
+               char oldNameBuffer[10 + VL_MAXNAMELEN];
+               char newNameBuffer[10 + VL_MAXNAMELEN];
+               char *oldname, *newname;
+
+               /* Fix broken names and numbers so entries can be inspected and deleted. */
+               if (InvalidVolname(vlentry.name)) {
+                   char bogus[VL_MAXNAMELEN];
+                   memset(bogus, 0, sizeof(bogus));
+                   snprintf(bogus, sizeof(bogus)-1, ".bogus.%ld", record[i].addr);
+                   strcpy(vlentry.name, bogus);
+                   quiet_println("FIX: Record %ld invalid volume name set to '%s'\n", record[i].addr, bogus);
+               }
+               if (vlentry.volumeId[0] == 0) {
+                   afs_uint32 next_volid = header.vital_header.MaxVolumeId++;
+                   vlentry.volumeId[0] = next_volid;
+                   quiet_println("FIX: Record %ld invalid volume id set to %ld. New max volid is %ld\n",
+                       record[i].addr, next_volid, header.vital_header.MaxVolumeId);
                }
 
+               /*
+                * Put the current hash table contexts into our 'next'
+                * and our address into the hash table.
+                */
+               hash = NameHash(vlentry.name);
+
+               if (vlentry.nextNameHash != header.VolnameHash[hash]) {
+                   oldname = nameForAddr(vlentry.nextNameHash, MAXTYPES, &oldhash, oldNameBuffer);
+                   newname = nameForAddr(header.VolnameHash[hash], MAXTYPES, &newhash, newNameBuffer);
+                   if (verbose || ((oldhash != newhash) &&
+                                    (0 != vlentry.nextNameHash) &&
+                                    (0 != header.VolnameHash[hash]))) {
+                       /*
+                        * That is, only report if we are verbose
+                        * or the hash is changing (and one side wasn't NULL
+                        */
+                       quiet_println("FIX: Name hash link for '%s' was %s, is now %s\n",
+                              vlentry.name, oldname, newname);
+                   }
+               }
+
+               vlentry.nextNameHash = header.VolnameHash[hash];
+               header.VolnameHash[hash] = record[i].addr;
+
+               for (j = 0; j < MAXTYPES; j++) {
+
+                   if (0 == vlentry.volumeId[j]) {
+                       /*
+                        * No volume of that type.  Continue
+                        */
+                       continue;
+                   }
+                   hash = IdHash(vlentry.volumeId[j]);
+
+                   if (vlentry.nextIdHash[j] != header.VolidHash[j][hash]) {
+                       oldname = nameForAddr(vlentry.nextIdHash[j], j, &oldhash, oldNameBuffer);
+                       newname = nameForAddr(header.VolidHash[j][hash], j, &newhash, newNameBuffer);
+                       if (verbose || ((oldhash != newhash) &&
+                                       (0 != vlentry.nextIdHash[j]) &&
+                                       (0 != header.VolidHash[j][hash]))) {
+                           quiet_println("FIX: %s hash link for '%s' was %s, is now %s\n",
+                                         vtype(j), vlentry.name, oldname, newname);
+                       }
+                   }
+
+                   /* Consolidate server numbers which point to the same mh entry.
+                    * The serverref flags are not reset here, since we want to make
+                    * sure the data is actually written before the server number is
+                    * considered unreferenced. */
+                   for (k = 0; k < NMAXNSERVERS; k++) {
+                       if (vlentry.serverNumber[k] != BADSERVERID
+                           && serverxref[vlentry.serverNumber[k]] != BADSERVERID) {
+                           u_char oldsn = vlentry.serverNumber[k];
+                           u_char newsn = serverxref[oldsn];
+                           if (newsn == oldsn) {
+                               log_error(VLDB_CHECK_ERROR,
+                                         "INTERNAL VLDB_CHECK_ERROR: serverxref points to self; index %d\n",
+                                         oldsn);
+                           } else if (header.IpMappedAddr[oldsn] == 0) {
+                               log_error(VLDB_CHECK_ERROR,
+                                         "INTERNAL VLDB_CHECK_ERROR: serverxref; points to empty address; index %d, value %d\n",
+                                         oldsn, newsn);
+                           } else if (header.IpMappedAddr[newsn] != header.IpMappedAddr[oldsn]) {
+                               log_error(VLDB_CHECK_ERROR,
+                                         "INTERNAL VLDB_CHECK_ERROR: invalid serverxref; index %d\n",
+                                         oldsn);
+                           } else {
+                               quiet_println
+                                   ("FIX: Volume '%s', index %d, server number was %d, is now %d\n",
+                                    vlentry.name, k, oldsn, newsn);
+                               vlentry.serverNumber[k] = newsn;
+                           }
+                       }
+                   }
+
+                   vlentry.nextIdHash[j] = header.VolidHash[j][hash];
+                   header.VolidHash[j][hash] = record[i].addr;
+               }
+
+               /*
+                * Fix lock timestamp and flag inconsistencies.
+                */
+               if (vlentry.LockTimestamp == 0 && (vlentry.flags & VLOP_ALLOPERS) != 0) {
+                   quiet_println("FIX: Record %u: Inconsistent lock in volume %s; setting timestamp.\n",
+                                 record[i].addr, vlentry.name);
+                   vlentry.LockTimestamp = time(NULL);
+               }
+               if (vlentry.LockTimestamp != 0 && (vlentry.flags & VLOP_ALLOPERS) == 0) {
+                   quiet_println("FIX: Record %u: Inconsistent lock in volume %s; setting misc lock flag.\n",
+                                 record[i].addr, vlentry.name);
+                   vlentry.flags |= VLOP_DELETE; /* Shown by vos as "delete/misc". */
+               }
+
+               writeentry(record[i].addr, &vlentry);
+           }
+       }
+       else if (record[i].type & MH) {
+           int block, index;
+           char mhblock[VL_ADDREXTBLK_SIZE];
+           struct extentaddr *MHblock = (struct extentaddr *)mhblock;
+
+           if (fix) {
+               for (block = 0; block < VL_MAX_ADDREXTBLKS; block++) {
+                   if (mhinfo[block].addr == record[i].addr)
+                       break;
+               }
+               if (block == VL_MAX_ADDREXTBLKS) {
+                   continue;  /* skip orphaned extent block */
+               }
+               readMH(record[i].addr, block, MHblock);
+               for (index = 0; index < VL_MHSRV_PERBLK; index++) {
+                   if (mhinfo[block].orphan[index]) {
+                       quiet_println("FIX: Removing unreferenced mh entry; block %d, index %d\n",
+                               block, index);
+                       memset(&(MHblock[index]), 0, sizeof(struct extentaddr));
+                   }
+               }
+               writeMH(record[i].addr, block, MHblock);
+           }
+       } else if (record[i].type & FR) {
+           if (fix) {
+               readentry(record[i].addr, &vlentry, &type);
+               vlentry.nextIdHash[0] = header.vital_header.freePtr;
+               header.vital_header.freePtr = record[i].addr;
+               if ((record[i].type & FRC) == 0) {
+                   quiet_println
+                       ("FIX: Putting free entry on the free chain: addr=%lu (offset 0x%0x)\n",
+                        record[i].addr, OFFSET(record[i].addr));
+               }
+               writeentry(record[i].addr, &vlentry);
            }
        }
     }
-    if (fix) 
+    if (fix) {
+       reportHashChanges(&header, oldnamehash, oldidhash);
+       removeCrossLinkedAddresses(&header);
        writeheader(&header);
+    }
+
+    close(fd);
 
-    return 0;
+    return error_level;
 }
 
 int
@@ -1272,7 +1645,7 @@ main(int argc, char **argv)
 
     setlinebuf(stdout);
 
-    ts = cmd_CreateSyntax(NULL, WorkerBee, NULL, "vldb check");
+    ts = cmd_CreateSyntax(NULL, WorkerBee, NULL, 0, "vldb check");
     cmd_AddParm(ts, "-database", CMD_SINGLE, CMD_REQUIRED, "vldb_file");
     cmd_AddParm(ts, "-uheader", CMD_FLAG, CMD_OPTIONAL,
                "Display UBIK header");
@@ -1282,6 +1655,7 @@ main(int argc, char **argv)
                "Display server list");
     cmd_AddParm(ts, "-entries", CMD_FLAG, CMD_OPTIONAL, "Display entries");
     cmd_AddParm(ts, "-verbose", CMD_FLAG, CMD_OPTIONAL, "verbose");
+    cmd_AddParm(ts, "-quiet", CMD_FLAG, CMD_OPTIONAL, "quiet");
     cmd_AddParm(ts, "-fix", CMD_FLAG, CMD_OPTIONAL, "attempt to patch the database (potentially dangerous)");
 
     return cmd_Dispatch(argc, argv);