struct nvlentry *VlEntry);
static int repsite_exists(struct nvlentry *VlEntry, int server, int partition);
static void repsite_compress(struct nvlentry *VlEntry, int offset);
-static void vlentry_to_vldbentry(struct vl_ctx *ctx,
+static int vlentry_to_vldbentry(struct vl_ctx *ctx,
+ struct nvlentry *VlEntry,
+ struct vldbentry *VldbEntry);
+static int vlentry_to_nvldbentry(struct vl_ctx *ctx,
struct nvlentry *VlEntry,
- struct vldbentry *VldbEntry);
-static void vlentry_to_nvldbentry(struct vl_ctx *ctx,
- struct nvlentry *VlEntry,
- struct nvldbentry *VldbEntry);
-static void vlentry_to_uvldbentry(struct vl_ctx *ctx,
- struct nvlentry *VlEntry,
- struct uvldbentry *VldbEntry);
+ struct nvldbentry *VldbEntry);
+static int vlentry_to_uvldbentry(struct vl_ctx *ctx,
+ struct nvlentry *VlEntry,
+ struct uvldbentry *VldbEntry);
static int InvalidVolname(char *volname);
static int InvalidVoltype(afs_int32 voltype);
static int InvalidOperation(afs_int32 voloper);
}
}
+
+static_inline int
+multiHomedExtentBase(struct vl_ctx *ctx, int srvidx, struct extentaddr **exp,
+ int *basePtr)
+{
+ int base;
+ int index;
+
+ *exp = NULL;
+ *basePtr = 0;
+
+ if ((ctx->hostaddress[srvidx] & 0xff000000) == 0xff000000) {
+ base = (ctx->hostaddress[srvidx] >> 16) & 0xff;
+ index = ctx->hostaddress[srvidx] & 0x0000ffff;
+ if (base >= VL_MAX_ADDREXTBLKS) {
+ VLog(0, ("Internal error: Multihome extent base is too large. "
+ "Base %d index %d\n", base, index));
+ return VL_IO;
+ }
+ if (index >= VL_MHSRV_PERBLK) {
+ VLog(0, ("Internal error: Multihome extent index is too large. "
+ "Base %d index %d\n", base, index));
+ return VL_IO;
+ }
+ if (!ctx->ex_addr[base]) {
+ VLog(0, ("Internal error: Multihome extent does not exist. "
+ "Base %d\n", base));
+ return VL_IO;
+ }
+
+ *basePtr = base;
+ *exp = &ctx->ex_addr[base][index];
+ }
+
+ return 0;
+}
+
+static_inline int
+multiHomedExtent(struct vl_ctx *ctx, int srvidx, struct extentaddr **exp)
+{
+ int base;
+
+ return multiHomedExtentBase(ctx, srvidx, exp, &base);
+}
+
#define AFS_RXINFO_LEN 128
static char *
-rxinfo(char * str, struct rx_call *rxcall)
+rxkadInfo(char *str, struct rx_connection *conn, struct in_addr hostAddr)
{
int code;
- struct rx_connection *tconn;
char tname[64] = "";
char tinst[64] = "";
char tcell[64] = "";
afs_uint32 exp;
- struct in_addr hostAddr;
- tconn = rx_ConnectionOf(rxcall);
- hostAddr.s_addr = rx_HostOf(rx_PeerOf(tconn));
- code =
- rxkad_GetServerInfo(rxcall->conn, NULL, &exp, tname, tinst, tcell,
- NULL);
+ code = rxkad_GetServerInfo(conn, NULL, &exp, tname, tinst, tcell,
+ NULL);
if (!code)
- sprintf(str, "%s %s%s%s%s%s", inet_ntoa(hostAddr), tname,
+ snprintf(str, AFS_RXINFO_LEN,
+ "%s rxkad:%s%s%s%s%s", inet_ntoa(hostAddr), tname,
(tinst[0] == '\0') ? "" : ".",
(tinst[0] == '\0') ? "" : tinst,
(tcell[0] == '\0') ? "" : "@",
(tcell[0] == '\0') ? "" : tcell);
else
- sprintf(str, "%s noauth", inet_ntoa(hostAddr));
+ snprintf(str, AFS_RXINFO_LEN, "%s noauth", inet_ntoa(hostAddr));
return (str);
}
+static char *
+rxinfo(char *str, struct rx_call *rxcall)
+{
+ struct rx_connection *conn;
+ struct in_addr hostAddr;
+ rx_securityIndex authClass;
+
+ conn = rx_ConnectionOf(rxcall);
+ authClass = rx_SecurityClassOf(conn);
+ hostAddr.s_addr = rx_HostOf(rx_PeerOf(conn));
+
+ switch(authClass) {
+ case RX_SECIDX_KAD:
+ return rxkadInfo(str, conn, hostAddr);
+ default:
+ ;
+ }
+
+ snprintf(str, AFS_RXINFO_LEN, "%s noauth", inet_ntoa(hostAddr));
+ return str;
+}
+
+
/* This is called to initialize the database, set the appropriate locks and make sure that the vldb header is valid */
int
Init_VLdbase(struct vl_ctx *ctx,
if (blockindex == 0) { /* entry not found */
if (!code)
code = VL_NOENT;
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return code;
+ goto abort;
}
if (tentry.flags & VLDELETED) { /* Entry is deleted! */
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_ENTDELETED;
+ code = VL_ENTDELETED;
+ goto abort;
}
/* Convert from the internal to external form */
if (new == 1)
- vlentry_to_nvldbentry(&ctx, &tentry, (struct nvldbentry *)aentry);
+ code = vlentry_to_nvldbentry(&ctx, &tentry, (struct nvldbentry *)aentry);
else if (new == 2)
- vlentry_to_uvldbentry(&ctx, &tentry, (struct uvldbentry *)aentry);
+ code = vlentry_to_uvldbentry(&ctx, &tentry, (struct uvldbentry *)aentry);
else
- vlentry_to_vldbentry(&ctx, &tentry, (struct vldbentry *)aentry);
+ code = vlentry_to_vldbentry(&ctx, &tentry, (struct vldbentry *)aentry);
+
+ if (code)
+ goto abort;
+
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
afs_int32
char rxstr[AFS_RXINFO_LEN];
if (NameIsId(volname)) {
- return GetEntryByID(rxcall, atoi(volname), -1, aentry, new, this_op);
+ return GetEntryByID(rxcall, strtoul(volname, NULL, 10), -1, aentry, new, this_op);
}
if (InvalidVolname(volname))
return VL_BADNAME;
if (blockindex == 0) { /* entry not found */
if (!code)
code = VL_NOENT;
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return code;
+ goto abort;
}
if (tentry.flags & VLDELETED) { /* Entry is deleted */
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_ENTDELETED;
+ code = VL_ENTDELETED;
+ goto abort;
}
/* Convert to external entry representation */
if (new == 1)
- vlentry_to_nvldbentry(&ctx, &tentry, (struct nvldbentry *)aentry);
+ code = vlentry_to_nvldbentry(&ctx, &tentry, (struct nvldbentry *)aentry);
else if (new == 2)
- vlentry_to_uvldbentry(&ctx, &tentry, (struct uvldbentry *)aentry);
+ code = vlentry_to_uvldbentry(&ctx, &tentry, (struct uvldbentry *)aentry);
else
- vlentry_to_vldbentry(&ctx, &tentry, (struct vldbentry *)aentry);
+ code = vlentry_to_vldbentry(&ctx, &tentry, (struct vldbentry *)aentry);
+
+ if (code)
+ goto abort;
+
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
+
}
afs_int32
VLog(25, ("OListEntry index=%d %s\n", previous_index,
rxinfo(rxstr, rxcall)));
*next_index = NextEntry(&ctx, previous_index, &tentry, count);
- if (*next_index)
- vlentry_to_vldbentry(&ctx, &tentry, aentry);
+ if (*next_index) {
+ code = vlentry_to_vldbentry(&ctx, &tentry, aentry);
+ if (code) {
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
+ }
+ }
return (ubik_EndTrans(ctx.trans));
}
return code;
VLog(25, ("ListEntry index=%d %s\n", previous_index, rxinfo(rxstr, rxcall)));
*next_index = NextEntry(&ctx, previous_index, &tentry, count);
- if (*next_index)
- vlentry_to_nvldbentry(&ctx, &tentry, aentry);
+ if (*next_index) {
+ code = vlentry_to_nvldbentry(&ctx, &tentry, aentry);
+ if (code) {
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
+ }
+ }
+
return (ubik_EndTrans(ctx.trans));
}
Vldbentry = VldbentryFirst = vldbentries->bulkentries_val =
(vldbentry *) malloc(allocCount * sizeof(vldbentry));
if (Vldbentry == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
VldbentryLast = VldbentryFirst + allocCount;
/* Handle the attribute by volume id totally separate of the rest
if (blockindex == 0) {
if (!code)
code = VL_NOENT;
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->bulkentries_val)
- free((char *)vldbentries->bulkentries_val);
- vldbentries->bulkentries_val = 0;
- vldbentries->bulkentries_len = 0;
- return code;
- }
- if ((code =
- put_attributeentry(&ctx, &Vldbentry, &VldbentryFirst, &VldbentryLast,
- vldbentries, &tentry, nentries, &allocCount))) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->bulkentries_val)
- free((char *)vldbentries->bulkentries_val);
- vldbentries->bulkentries_val = 0;
- vldbentries->bulkentries_len = 0;
- return VL_SIZEEXCEEDED;
+ goto abort;
}
+
+ code = put_attributeentry(&ctx, &Vldbentry, &VldbentryFirst,
+ &VldbentryLast, vldbentries, &tentry,
+ nentries, &allocCount);
+ if (code)
+ goto abort;
} else {
afs_int32 nextblockindex = 0, count = 0, k = 0, match = 0;
while ((nextblockindex =
if (!(tentry.flags & attributes->flag))
continue;
}
- if ((code =
- put_attributeentry(&ctx, &Vldbentry, &VldbentryFirst,
- &VldbentryLast, vldbentries, &tentry,
- nentries, &allocCount))) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->bulkentries_val)
- free((char *)vldbentries->bulkentries_val);
- vldbentries->bulkentries_val = 0;
- vldbentries->bulkentries_len = 0;
- return code;
- }
+ code = put_attributeentry(&ctx, &Vldbentry, &VldbentryFirst,
+ &VldbentryLast, vldbentries, &tentry,
+ nentries, &allocCount);
+ if (code)
+ goto abort;
}
}
if (vldbentries->bulkentries_len
vldbentries->bulkentries_len *
sizeof(vldbentry));
if (vldbentries->bulkentries_val == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
}
VLog(5,
("ListAttrs nentries=%d %s\n", vldbentries->bulkentries_len,
rxinfo(rxstr, rxcall)));
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ if (vldbentries->bulkentries_val)
+ free(vldbentries->bulkentries_val);
+ vldbentries->bulkentries_val = 0;
+ vldbentries->bulkentries_len = 0;
+
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+
+ return code;
}
afs_int32
Vldbentry = VldbentryFirst = vldbentries->nbulkentries_val =
(nvldbentry *) malloc(allocCount * sizeof(nvldbentry));
if (Vldbentry == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
VldbentryLast = VldbentryFirst + allocCount;
/* Handle the attribute by volume id totally separate of the rest
if (blockindex == 0) {
if (!code)
code = VL_NOENT;
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->nbulkentries_val)
- free((char *)vldbentries->nbulkentries_val);
- vldbentries->nbulkentries_val = 0;
- vldbentries->nbulkentries_len = 0;
- return code;
- }
- if ((code =
- put_nattributeentry(&ctx, &Vldbentry, &VldbentryFirst, &VldbentryLast,
- vldbentries, &tentry, 0, 0, nentries,
- &allocCount))) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->nbulkentries_val)
- free((char *)vldbentries->nbulkentries_val);
- vldbentries->nbulkentries_val = 0;
- vldbentries->nbulkentries_len = 0;
- return VL_SIZEEXCEEDED;
+ goto abort;
}
+
+ code = put_nattributeentry(&ctx, &Vldbentry, &VldbentryFirst,
+ &VldbentryLast, vldbentries, &tentry,
+ 0, 0, nentries, &allocCount);
+ if (code)
+ goto abort;
} else {
afs_int32 nextblockindex = 0, count = 0, k = 0, match = 0;
while ((nextblockindex =
if (!(tentry.flags & attributes->flag))
continue;
}
- if ((code =
- put_nattributeentry(&ctx, &Vldbentry, &VldbentryFirst,
- &VldbentryLast, vldbentries, &tentry, 0,
- 0, nentries, &allocCount))) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- if (vldbentries->nbulkentries_val)
- free((char *)vldbentries->nbulkentries_val);
- vldbentries->nbulkentries_val = 0;
- vldbentries->nbulkentries_len = 0;
- return code;
- }
+ code = put_nattributeentry(&ctx, &Vldbentry, &VldbentryFirst,
+ &VldbentryLast, vldbentries,
+ &tentry, 0, 0, nentries, &allocCount);
+ if (code)
+ goto abort;
}
}
if (vldbentries->nbulkentries_len
vldbentries->nbulkentries_len *
sizeof(nvldbentry));
if (vldbentries->nbulkentries_val == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
}
VLog(5,
("NListAttrs nentries=%d %s\n", vldbentries->nbulkentries_len,
rxinfo(rxstr, rxcall)));
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ if (vldbentries->nbulkentries_val)
+ free(vldbentries->nbulkentries_val);
+ vldbentries->nbulkentries_val = 0;
+ vldbentries->nbulkentries_len = 0;
+ return code;
}
blockindex =
FindByID(&ctx, attributes->volumeid, -1, &tentry, &code);
if (!blockindex) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return (code ? code : VL_NOENT);
+ if (!code)
+ code = VL_NOENT;
+ goto abort;
}
vllist = (single_vldbentry *) malloc(sizeof(single_vldbentry));
if (vllist == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
- vlentry_to_vldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ code = vlentry_to_vldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ if (code)
+ goto abort;
+
vllist->next_vldb = NULL;
*vllistptr = vllist; /* Thread onto list */
vllist = (single_vldbentry *) malloc(sizeof(single_vldbentry));
if (vllist == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
- vlentry_to_vldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ code = vlentry_to_vldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ if (code)
+ goto abort;
+
vllist->next_vldb = NULL;
*vllistptr = vllist; /* Thread onto list */
vllistptr = &vllist->next_vldb;
(*nentries)++;
if (smallMem && (*nentries >= VLDBALLOCCOUNT)) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_SIZEEXCEEDED;
+ code = VL_SIZEEXCEEDED;
+ goto abort;
}
}
}
*vllistptr = NULL;
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
afs_int32
blockindex =
FindByID(&ctx, attributes->volumeid, -1, &tentry, &code);
if (!blockindex) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return (code ? code : VL_NOENT);
+ if (!code)
+ code = VL_NOENT;
+ goto abort;
}
vllist = (single_nvldbentry *) malloc(sizeof(single_nvldbentry));
if (vllist == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
- vlentry_to_nvldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ code = vlentry_to_nvldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ if (code)
+ goto abort;
+
vllist->next_vldb = NULL;
*vllistptr = vllist; /* Thread onto list */
vllist = (single_nvldbentry *) malloc(sizeof(single_nvldbentry));
if (vllist == NULL) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
- vlentry_to_nvldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ code = vlentry_to_nvldbentry(&ctx, &tentry, &vllist->VldbEntry);
+ if (code)
+ goto abort;
+
vllist->next_vldb = NULL;
*vllistptr = vllist; /* Thread onto list */
vllistptr = &vllist->next_vldb;
(*nentries)++;
if (smallMem && (*nentries >= VLDBALLOCCOUNT)) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_SIZEEXCEEDED;
+ code = VL_SIZEEXCEEDED;
+ goto abort;
}
}
}
*vllistptr = NULL;
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
/* Get back vldb header statistics (allocs, frees, maxvolumeid,
nservers = *nentries = addrsp->bulkaddrs_len = 0;
if (!taddrp) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
for (i = 0; i <= MAXSERVERID; i++) {
addrsp->bulkaddrs_len = *nentries = nservers;
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
#define PADDR(addr) VLog(0,("%d.%d.%d.%d", (addr>>24)&0xff, (addr>>16)&0xff, (addr>>8) &0xff, addr&0xff));
int this_op = VLREGADDR;
afs_int32 code;
struct vl_ctx ctx;
- int cnt, h, i, j, k, m, base, index;
+ int cnt, h, i, j, k, m;
struct extentaddr *exp = 0, *tex;
afsUUID tuuid;
afs_uint32 addrs[VL_MAXIPADDRS_PERMH];
- afs_int32 fbase;
+ int base;
int count, willChangeEntry, foundUuidEntry, willReplaceCnt;
int WillReplaceEntry, WillChange[MAXSERVERID + 1];
int FoundUuid = 0;
}
}
if (cnt <= 0) {
- ubik_AbortTrans(ctx.trans);
- return VL_INDEXERANGE;
+ code = VL_INDEXERANGE;
+ goto abort;
}
count = 0;
for (srvidx = 0; srvidx <= MAXSERVERID; srvidx++) {
willChangeEntry = 0;
WillReplaceEntry = 1;
- if ((ctx.hostaddress[srvidx] & 0xff000000) == 0xff000000) {
- /* The server is registered as a multihomed */
- base = (ctx.hostaddress[srvidx] >> 16) & 0xff;
- index = ctx.hostaddress[srvidx] & 0x0000ffff;
- if (base >= VL_MAX_ADDREXTBLKS) {
- VLog(0,
- ("Internal error: Multihome extent base is too large. Base %d index %d\n",
- base, index));
- continue;
- }
- if (index >= VL_MHSRV_PERBLK) {
- VLog(0,
- ("Internal error: Multihome extent index is too large. Base %d index %d\n",
- base, index));
- continue;
- }
- if (!ctx.ex_addr[base]) {
- VLog(0,
- ("Internal error: Multihome extent does not exist. Base %d\n",
- base));
- continue;
- }
+ code = multiHomedExtent(&ctx, srvidx, &exp);
+ if (code)
+ continue;
+ if (exp) {
/* See if the addresses to register will change this server entry */
- exp = &ctx.ex_addr[base][index];
tuuid = exp->ex_hostuuid;
afs_ntohuuid(&tuuid);
if (afs_uuid_equal(uuidp, &tuuid)) {
VLog(0,("]\n"));
if (foundUuidEntry) {
- VLog(0,
- (" It would have replaced the existing VLDB server entry:\n"));
- VLog(0, (" entry %d: [", FoundUuid));
- base = (ctx.hostaddress[FoundUuid] >> 16) & 0xff;
- index = ctx.hostaddress[FoundUuid] & 0x0000ffff;
- exp = &ctx.ex_addr[base][index];
- for (mhidx = 0; mhidx < VL_MAXIPADDRS_PERMH; mhidx++) {
- if (!exp->ex_addrs[mhidx])
- continue;
- if (mhidx > 0)
- VLog(0,(" "));
- PADDR(ntohl(exp->ex_addrs[mhidx]));
+ code = multiHomedExtent(&ctx, FoundUuid, &exp);
+ if (code == 0) {
+ VLog(0, (" It would have replaced the existing VLDB server "
+ "entry:\n"));
+ VLog(0, (" entry %d: [", FoundUuid));
+ for (mhidx = 0; mhidx < VL_MAXIPADDRS_PERMH; mhidx++) {
+ if (!exp->ex_addrs[mhidx])
+ continue;
+ if (mhidx > 0)
+ VLog(0,(" "));
+ PADDR(ntohl(exp->ex_addrs[mhidx]));
+ }
+ VLog(0, ("]\n"));
}
- VLog(0, ("]\n"));
}
if (count == 1)
for (j = 0; j < count; j++) {
srvidx = WillChange[j];
VLog(0, (" entry %d: ", srvidx));
- if ((ctx.hostaddress[srvidx] & 0xff000000) == 0xff000000) {
+
+ code = multiHomedExtent(&ctx, srvidx, &exp);
+ if (code)
+ goto abort;
+
+ if (exp) {
VLog(0, ("["));
- base = (ctx.hostaddress[srvidx] >> 16) & 0xff;
- index = ctx.hostaddress[srvidx] & 0x0000ffff;
- exp = &ctx.ex_addr[base][index];
for (mhidx = 0; mhidx < VL_MAXIPADDRS_PERMH; mhidx++) {
if (!exp->ex_addrs[mhidx])
continue;
(" and/or remove the sysid file from the registering fileserver\n"));
VLog(0, (" before the fileserver can be registered in the VLDB.\n"));
- ubik_AbortTrans(ctx.trans);
- return VL_MULTIPADDR;
+ code = VL_MULTIPADDR;
+ goto abort;
}
/* Passed the checks. Now find and update the existing mh entry, or create
/* Found the entry with same uuid. See if we need to change it */
int change = 0;
- fbase = (ctx.hostaddress[FoundUuid] >> 16) & 0xff;
- index = ctx.hostaddress[FoundUuid] & 0x0000ffff;
- exp = &ctx.ex_addr[fbase][index];
+ code = multiHomedExtentBase(&ctx, FoundUuid, &exp, &base);
+ if (code)
+ goto abort;
/* Determine if the entry has changed */
for (k = 0; ((k < cnt) && !change); k++) {
}
/* Have an entry that needs to be replaced */
- if ((ctx.hostaddress[ReplaceEntry] & 0xff000000) == 0xff000000) {
- fbase = (ctx.hostaddress[ReplaceEntry] >> 16) & 0xff;
- index = ctx.hostaddress[ReplaceEntry] & 0x0000ffff;
- exp = &ctx.ex_addr[fbase][index];
+ code = multiHomedExtentBase(&ctx, ReplaceEntry, &exp, &base);
+ if (code)
+ goto abort;
+ if (exp) {
VLog(0,
(" It will replace the following existing entry in the VLDB (new uuid):\n"));
VLog(0, (" entry %d: [", ReplaceEntry));
VLog(0,(", in the VLDB (new uuid):\n"));
code =
- FindExtentBlock(&ctx, uuidp, 1, ReplaceEntry, &exp, &fbase);
+ FindExtentBlock(&ctx, uuidp, 1, ReplaceEntry, &exp, &base);
if (code || !exp) {
- ubik_AbortTrans(ctx.trans);
- return (code ? code : VL_IO);
+ if (!code)
+ code = VL_IO;
+ goto abort;
}
}
} else {
* well as use a new slot of the ctx.hostaddress array.
*/
VLog(0, (" It will create a new entry in the VLDB.\n"));
- code = FindExtentBlock(&ctx, uuidp, 1, -1, &exp, &fbase);
+ code = FindExtentBlock(&ctx, uuidp, 1, -1, &exp, &base);
if (code || !exp) {
- ubik_AbortTrans(ctx.trans);
- return (code ? code : VL_IO);
+ if (!code)
+ code = VL_IO;
+ goto abort;
}
}
/* Write the new mh entry out */
if (vlwrite
(ctx.trans,
- DOFFSET(ntohl(ctx.ex_addr[0]->ex_contaddrs[fbase]),
- (char *)ctx.ex_addr[fbase], (char *)exp), (char *)exp,
+ DOFFSET(ntohl(ctx.ex_addr[0]->ex_contaddrs[base]),
+ (char *)ctx.ex_addr[base], (char *)exp), (char *)exp,
sizeof(*exp))) {
- ubik_AbortTrans(ctx.trans);
- return VL_IO;
+ code = VL_IO;
+ goto abort;
}
/* Remove any common addresses from other mh entres. We know these entries
if (willReplaceCnt && (WillChange[i] == ReplaceEntry))
continue;
- base = (ctx.hostaddress[WillChange[i]] >> 16) & 0xff;
- index = ctx.hostaddress[WillChange[i]] & 0x0000ffff;
- tex = &ctx.ex_addr[fbase][index];
+ code = multiHomedExtentBase(&ctx, WillChange[i], &tex, &base);
+ if (code)
+ goto abort;
if (++m == 1)
VLog(0,
DOFFSET(ntohl(ctx.ex_addr[0]->ex_contaddrs[base]),
(char *)ctx.ex_addr[base], (char *)tex);
if (vlwrite(ctx.trans, doff, (char *)tex, sizeof(*tex))) {
- ubik_AbortTrans(ctx.trans);
- return VL_IO;
+ code = VL_IO;
+ goto abort;
}
}
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
afs_int32
if (attributes->Mask & VLADDR_IPADDR) {
if (attributes->Mask & (VLADDR_INDEX | VLADDR_UUID)) {
- ubik_AbortTrans(ctx.trans);
- return VL_BADMASK;
+ code = VL_BADMASK;
+ goto abort;
}
for (base = 0; base < VL_MAX_ADDREXTBLKS; base++) {
if (!ctx.ex_addr[base])
break;
}
if (base >= VL_MAX_ADDREXTBLKS) {
- ubik_AbortTrans(ctx.trans);
- return VL_NOENT;
+ code = VL_NOENT;
+ goto abort;
}
} else if (attributes->Mask & VLADDR_INDEX) {
if (attributes->Mask & (VLADDR_IPADDR | VLADDR_UUID)) {
- ubik_AbortTrans(ctx.trans);
- return VL_BADMASK;
+ code = VL_BADMASK;
+ goto abort;
}
index = attributes->index;
if (index < 1 || index >= (VL_MAX_ADDREXTBLKS * VL_MHSRV_PERBLK)) {
- ubik_AbortTrans(ctx.trans);
- return VL_INDEXERANGE;
+ code = VL_INDEXERANGE;
+ goto abort;
}
base = index / VL_MHSRV_PERBLK;
offset = index % VL_MHSRV_PERBLK;
if (offset == 0) {
- ubik_AbortTrans(ctx.trans);
- return VL_NOENT;
+ code = VL_NOENT;
+ goto abort;
}
if (!ctx.ex_addr[base]) {
- ubik_AbortTrans(ctx.trans);
- return VL_INDEXERANGE;
+ code = VL_INDEXERANGE;
+ goto abort;
}
exp = &ctx.ex_addr[base][offset];
} else if (attributes->Mask & VLADDR_UUID) {
if (attributes->Mask & (VLADDR_IPADDR | VLADDR_INDEX)) {
- ubik_AbortTrans(ctx.trans);
- return VL_BADMASK;
+ code = VL_BADMASK;
+ goto abort;
}
if (!ctx.ex_addr[0]) { /* mh servers probably aren't setup on this vldb */
- ubik_AbortTrans(ctx.trans);
- return VL_NOENT;
- }
- if ((code =
- FindExtentBlock(&ctx, &attributes->uuid, 0, -1, &exp, &base))) {
- ubik_AbortTrans(ctx.trans);
- return code;
+ code = VL_NOENT;
+ goto abort;
}
+ code = FindExtentBlock(&ctx, &attributes->uuid, 0, -1, &exp, &base);
+ if (code)
+ goto abort;
} else {
- ubik_AbortTrans(ctx.trans);
- return VL_BADMASK;
+ code = VL_BADMASK;
+ goto abort;
}
if (exp == NULL) {
- ubik_AbortTrans(ctx.trans);
- return VL_NOENT;
+ code = VL_NOENT;
+ goto abort;
}
addrsp->bulkaddrs_val = taddrp =
(afs_uint32 *) malloc(sizeof(afs_int32) * (MAXSERVERID + 1));
nservers = *nentries = addrsp->bulkaddrs_len = 0;
if (!taddrp) {
- countAbort(this_op);
- ubik_AbortTrans(ctx.trans);
- return VL_NOMEM;
+ code = VL_NOMEM;
+ goto abort;
}
tuuid = exp->ex_hostuuid;
afs_ntohuuid(&tuuid);
if (afs_uuid_is_nil(&tuuid)) {
- ubik_AbortTrans(ctx.trans);
- return VL_NOENT;
+ code = VL_NOENT;
+ goto abort;
}
if (uuidpo)
*uuidpo = tuuid;
}
addrsp->bulkaddrs_len = *nentries = nservers;
return (ubik_EndTrans(ctx.trans));
+
+abort:
+ countAbort(this_op);
+ ubik_AbortTrans(ctx.trans);
+ return code;
}
/* ============> End of Exported vldb RPC functions <============= */
{
vldbentry *reall;
afs_int32 allo;
+ int code;
if (*Vldbentry == *VldbentryLast) {
if (smallMem)
*VldbentryLast = *Vldbentry + allo;
*alloccnt += allo;
}
- vlentry_to_vldbentry(ctx, entry, *Vldbentry);
+
+ code = vlentry_to_vldbentry(ctx, entry, *Vldbentry);
+ if (code)
+ return code;
+
(*Vldbentry)++;
(*nentries)++;
vldbentries->bulkentries_len++;
{
nvldbentry *reall;
afs_int32 allo;
+ int code;
if (*Vldbentry == *VldbentryLast) {
if (smallMem)
*VldbentryLast = *Vldbentry + allo;
*alloccnt += allo;
}
- vlentry_to_nvldbentry(ctx, entry, *Vldbentry);
+ code = vlentry_to_nvldbentry(ctx, entry, *Vldbentry);
+ if (code)
+ return code;
+
(*Vldbentry)->matchindex = (matchtype << 16) + matchindex;
(*Vldbentry)++;
(*nentries)++;
/* Convert from the internal (compacted) vldb entry to the external
* representation used by the interface. */
-static void
+static int
vlentry_to_vldbentry(struct vl_ctx *ctx, struct nvlentry *VlEntry,
struct vldbentry *VldbEntry)
{
- int i, j;
+ int i, j, code;
+ struct extentaddr *exp;
memset(VldbEntry, 0, sizeof(struct vldbentry));
strncpy(VldbEntry->name, VlEntry->name, sizeof(VldbEntry->name));
for (i = 0; i < OMAXNSERVERS; i++) {
if (VlEntry->serverNumber[i] == BADSERVERID)
break;
- if ((ctx->hostaddress[j = VlEntry->serverNumber[i]] & 0xff000000) ==
- 0xff000000) {
- struct extentaddr *exp;
- int base, index;
-
- base = (ctx->hostaddress[j] >> 16) & 0xff;
- index = ctx->hostaddress[j] & 0x0000ffff;
- exp = &ctx->ex_addr[base][index];
+ j = VlEntry->serverNumber[i];
+ code = multiHomedExtent(ctx, VlEntry->serverNumber[i], &exp);
+ if (code)
+ return code;
+ if (exp) {
/* For now return the first ip address back */
for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
if (exp->ex_addrs[j]) {
VldbEntry->volumeId[i] = VlEntry->volumeId[i];
VldbEntry->cloneId = VlEntry->cloneId;
VldbEntry->flags = VlEntry->flags;
+
+ return 0;
}
/* Convert from the internal (compacted) vldb entry to the external
* representation used by the interface. */
-static void
+static int
vlentry_to_nvldbentry(struct vl_ctx *ctx, struct nvlentry *VlEntry,
struct nvldbentry *VldbEntry)
{
- int i, j;
+ int i, j, code;
+ struct extentaddr *exp;
- memset(VldbEntry, 0, sizeof(struct vldbentry));
+ memset(VldbEntry, 0, sizeof(struct nvldbentry));
strncpy(VldbEntry->name, VlEntry->name, sizeof(VldbEntry->name));
for (i = 0; i < NMAXNSERVERS; i++) {
if (VlEntry->serverNumber[i] == BADSERVERID)
break;
- if ((ctx->hostaddress[j = VlEntry->serverNumber[i]] & 0xff000000) ==
- 0xff000000) {
- struct extentaddr *exp;
- int base, index;
-
- base = (ctx->hostaddress[j] >> 16) & 0xff;
- index = ctx->hostaddress[j] & 0x0000ffff;
- exp = &ctx->ex_addr[base][index];
+ code = multiHomedExtent(ctx, VlEntry->serverNumber[i], &exp);
+ if (code)
+ return code;
+
+ if (exp) {
/* For now return the first ip address back */
for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
if (exp->ex_addrs[j]) {
VldbEntry->volumeId[i] = VlEntry->volumeId[i];
VldbEntry->cloneId = VlEntry->cloneId;
VldbEntry->flags = VlEntry->flags;
+
+ return 0;
}
-static void
+static int
vlentry_to_uvldbentry(struct vl_ctx *ctx, struct nvlentry *VlEntry,
struct uvldbentry *VldbEntry)
{
- int i, j;
+ int i, code;
+ struct extentaddr *exp;
- memset(VldbEntry, 0, sizeof(struct vldbentry));
+ memset(VldbEntry, 0, sizeof(struct uvldbentry));
strncpy(VldbEntry->name, VlEntry->name, sizeof(VldbEntry->name));
for (i = 0; i < NMAXNSERVERS; i++) {
if (VlEntry->serverNumber[i] == BADSERVERID)
break;
VldbEntry->serverFlags[i] = VlEntry->serverFlags[i];
VldbEntry->serverUnique[i] = 0;
- if ((ctx->hostaddress[j = VlEntry->serverNumber[i]] & 0xff000000) ==
- 0xff000000) {
- struct extentaddr *exp;
- int base, index;
+ code = multiHomedExtent(ctx, VlEntry->serverNumber[i], &exp);
+ if (code)
+ return code;
+
+ if (exp) {
afsUUID tuuid;
- base = (ctx->hostaddress[j] >> 16) & 0xff;
- index = ctx->hostaddress[j] & 0x0000ffff;
- exp = &ctx->ex_addr[base][index];
tuuid = exp->ex_hostuuid;
afs_ntohuuid(&tuuid);
VldbEntry->serverFlags[i] |= VLSERVER_FLAG_UUID;
VldbEntry->volumeId[i] = VlEntry->volumeId[i];
VldbEntry->cloneId = VlEntry->cloneId;
VldbEntry->flags = VlEntry->flags;
+
+ return 0;
}
#define LEGALCHARS ".ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_"
IpAddrToRelAddr(struct vl_ctx *ctx, afs_uint32 ipaddr, int create)
{
int i, j;
- afs_int32 code, base, index;
+ afs_int32 code;
struct extentaddr *exp;
for (i = 0; i <= MAXSERVERID; i++) {
if (ctx->hostaddress[i] == ipaddr)
return i;
- if ((ctx->hostaddress[i] & 0xff000000) == 0xff000000) {
- base = (ctx->hostaddress[i] >> 16) & 0xff;
- index = ctx->hostaddress[i] & 0x0000ffff;
- if (base >= VL_MAX_ADDREXTBLKS) {
- VLog(0,
- ("Internal error: Multihome extent base is too large. Base %d index %d\n",
- base, index));
- return -1; /* EINVAL */
- }
- if (index >= VL_MHSRV_PERBLK) {
- VLog(0,
- ("Internal error: Multihome extent index is too large. Base %d index %d\n",
- base, index));
- return -1; /* EINVAL */
- }
- if (!ctx->ex_addr[base]) {
- VLog(0,
- ("Internal error: Multihome extent does not exist. Base %d\n",
- base));
- return -1; /* EINVAL */
- }
- exp = &ctx->ex_addr[base][index];
+ code = multiHomedExtent(ctx, i, &exp);
+ if (code)
+ return -1;
+ if (exp) {
for (j = 0; j < VL_MAXIPADDRS_PERMH; j++) {
if (exp->ex_addrs[j] && (ntohl(exp->ex_addrs[j]) == ipaddr)) {
return i;
int i, j;
afs_int32 code;
struct extentaddr *exp = NULL;
- int base = 0;
- int index, mhidx;
+ int base;
+ int mhidx;
afsUUID tuuid;
afs_int32 blockindex, count;
int pollcount = 0;
}
for (i = 0; i <= MAXSERVERID; i++) {
- if ((ctx->hostaddress[i] & 0xff000000) == 0xff000000) {
- base = (ctx->hostaddress[i] >> 16) & 0xff;
- index = ctx->hostaddress[i] & 0x0000ffff;
- if ((base >= VL_MAX_ADDREXTBLKS) || (index >= VL_MHSRV_PERBLK)) {
- VLog(0,
- ("Internal error: Multihome extent addr is too large. Base %d index %d\n",
- base, index));
- return -1; /* EINVAL */
- }
+ code = multiHomedExtentBase(ctx, i, &exp, &base);
+ if (code)
+ return code;
- exp = &ctx->ex_addr[base][index];
+ if (exp) {
for (mhidx = 0; mhidx < VL_MAXIPADDRS_PERMH; mhidx++) {
if (!exp->ex_addrs[mhidx])
continue;
git://git.openafs.org / openafs.git / blobdiff