RedHat: Fail openafs-client 'stop' on rmmod error
authorAndrew Deason <adeason@sinenomine.net>
Wed, 8 Feb 2012 22:03:29 +0000 (16:03 -0600)
committerDerrick Brashear <shadow@dementix.org>
Tue, 14 Feb 2012 21:36:19 +0000 (13:36 -0800)
commit12e2a3abe7ca640a7cef2630039c06964f779f17
tree3baed18dfb927b7e081a34c609769023a485dcde
parentaaab21e7a123ce701a8d5b2144032739fe177d6f
RedHat: Fail openafs-client 'stop' on rmmod error

Currently, the openafs-client RPM init script ignores any error
reported by rmmod. If 'umount /afs' succeeds but rmmod does not, the
client may panic the machine if the client is started again (from e.g.
running the 'restart' init script method), since afsd will try to
initialize AFS with a libafs that has been shut down.

So, do not ignore errors from 'rmmod', and instead fail the 'stop'
method from the init script if we get an error.

Change-Id: Id4a07703fb4df69ad3a6a3569c91e48f73a0d309
Reviewed-on: http://gerrit.openafs.org/6709
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/packaging/RedHat/openafs-client.init