down with assert, up with osi_Assert
authorDerrick Brashear <shadow@dementia.org>
Mon, 18 Oct 2010 03:39:47 +0000 (23:39 -0400)
committerDerrick Brashear <shadow@dementia.org>
Wed, 27 Oct 2010 17:22:31 +0000 (10:22 -0700)
commit34767c6a0f914960c9a1efabe69dd9c312a2b400
tree975ef3c3bc0ece1bac58b27c5a95e778150b7d84
parentbd1657fb9d42e46fdc9560687aa0d360395740b2
down with assert, up with osi_Assert

because NDEBUG breaks things which happen inside an assert,
be done with that. instead, call osi_Assert wherever possible.
doesn't work for code which builds before rx; those cases we handle
by ensuring no operations happen inside the assert(). side effect:
move all pthread operations wrapped in asserts to MUTEX_mumble and
CV_mumble calls where those exist, so the assertions happen all in
one set of macroes.

Change-Id: I9fd8a0fdfdaed5ed55de3e5c0c4673d4714e7441
Reviewed-on: http://gerrit.openafs.org/3001
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
73 files changed:
src/afsd/afsd.c
src/afsd/afsd_kernel.c
src/audit/audit.c
src/budb/db_dump.c
src/budb/dbs_dump.c
src/butc/tcmain.c
src/kauth/kalog.c
src/libafsrpc/afsrpc.def
src/log/unlog.c
src/lwp/iomgr.c
src/lwp/lock.c
src/lwp/lock.h
src/lwp/lwp.c
src/lwp/lwp.h
src/lwp/rw.c
src/ptserver/utils.c
src/rx/rx.c
src/rx/rx_lwp.h
src/shlibafsrpc/libafsrpc.map
src/tsalvaged/Makefile.in
src/ubik/disk.c
src/ubik/recovery.c
src/ubik/ubik.c
src/ubik/ubik.p.h
src/ubik/ubikclient.c
src/util/Makefile.in
src/util/netutils.c
src/util/potpourri.h [deleted file]
src/util/pthread_glock.h
src/util/serverLog.c
src/util/thread_pool.c
src/util/work_queue.c
src/viced/afsfileprocs.c
src/viced/callback.c
src/viced/host.c
src/viced/host.h
src/viced/viced.c
src/viced/viced.h
src/vol/Makefile.in
src/vol/NTMakefile
src/vol/clone.c
src/vol/daemon_com.c
src/vol/fssync-client.c
src/vol/fssync-debug.c
src/vol/fssync-server.c
src/vol/ihandle.c
src/vol/ihandle.h
src/vol/listinodes.c
src/vol/namei_ops.c
src/vol/ntops.c
src/vol/nuke.c
src/vol/partition.c
src/vol/physio.c
src/vol/salvaged.c
src/vol/salvsync-client.c
src/vol/salvsync-server.c
src/vol/vg_cache.c
src/vol/vg_scan.c
src/vol/vnode.c
src/vol/vnode_inline.h
src/vol/vol-salvage.c
src/vol/volume.c
src/vol/volume.h
src/vol/volume_inline.h
src/vol/vutil.c
src/volser/Makefile.in
src/volser/dumpstuff.c
src/volser/physio.c
src/volser/vol_split.c
src/volser/volmain.c
src/volser/volprocs.c
src/volser/volser.p.h
src/volser/voltrans.c