git://git.openafs.org / openafs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b5f75c1) | patch
libadmin: Clear structures according to their size.
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 30 Mar 2012 18:16:50 +0000 (19:16 +0100)
committerDerrick Brashear <shadow@dementix.org>
Sat, 7 Apr 2012 12:07:00 +0000 (05:07 -0700)
commit34afb3e6b903fc1659b1c869fa2fb4226038e076
tree9bed77831f74df4430469c4fb9c56c41a5b3946btree | snapshot
parentb5f75c122875b4212eb1a885d09bfdd63f537a19commit | diff
libadmin: Clear structures according to their size.

memset(a, 0, sizeof(a)) is rarely correct, unless a is an error. Use the
size of the destination structure, rather than the size of a pointer to it
when deciding how much memory to clear.

Caught by clang's new error messages

Change-Id: Ia6c566534efae2f67f1b9bd22198d352238a987c
Reviewed-on: http://gerrit.openafs.org/7076
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
src/libadmin/vos/afs_vosAdmin.c diff | blob | history
OpenAFS Master Repository