vol: Don't return an uninited val from LookupNode
authorSimon Wilkinson <sxw@your-file-system.com>
Sat, 31 Mar 2012 15:51:19 +0000 (11:51 -0400)
committerDerrick Brashear <shadow@dementix.org>
Mon, 9 Apr 2012 01:19:14 +0000 (18:19 -0700)
commit6c1a7e68c4859573f636dec9b7e4b2ac1f5bb8a4
tree88240e5939a98aca1b622558749ac3912f6552a4
parent9cbc3b77db818bd65a8ec3c5b804178449c2bb67
vol: Don't return an uninited val from LookupNode

If the SalvageHashTable for a particular node is empty, then LookupNode
can return an uninitialised value to the caller. It isn't clear from a
broader code inspection whether LookupNode can ever be called with an
empty SalvageHashTable, but returning a NULL vsp does seem like the
correct thing to do in this situation.

Caught by clang-analyzer

Change-Id: Ibee79e6acf7d3bdbc2995ef924338ade4de77d08
Reviewed-on: http://gerrit.openafs.org/7094
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/vol/salvsync-server.c