viced: do not overwrite possible failure
authorMarcio Barbosa <mbarbosa@sinenomine.net>
Thu, 24 Dec 2015 20:23:23 +0000 (17:23 -0300)
committerBenjamin Kaduk <kaduk@mit.edu>
Thu, 24 Dec 2015 23:22:23 +0000 (18:22 -0500)
commit6e4f8e55282963a5b2e28c4d90f7a32f5ceb37b0
treeba74dc6fc6f002b0ac5cdead64a727489f3d7b43
parentb8757341fb9592519032ef64030d0e98195d8d3d
viced: do not overwrite possible failure

The function ‘hpr_Initialize’ overwrites the code
returned by ‘ubik_ClientInit’. As a result, ‘hpr_Initialize’
will not report any failure triggered by ‘ubik_ClientInit’.

To fix this problem, store the code returned by ‘rxs_Release’
in a new variable. Only return this code if the function
‘ubik_ClientInit’ worked properly. Otherwise, return the code
provided by ‘ubik_ClientInit’.

Change-Id: I1820e3cbc2131daace01cec0464e56fd2982a783
Reviewed-on: http://gerrit.openafs.org/12137
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/viced/host.c