git://git.openafs.org / openafs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b604ee7) | patch
OPENAFS-SA-2018-002 ubik: prevent VOTE_Debug, VOTE_XDebug information leak
authorMark Vitale <mvitale@sinenomine.net>
Tue, 26 Jun 2018 10:01:16 +0000 (06:01 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Sun, 9 Sep 2018 22:34:07 +0000 (17:34 -0500)
commit7a7c1f751cdb06c0d95339c999b2c035c2d2168b
tree029d74f445e1c646480a1300ca76deaa33a32d6atree | snapshot
parentb604ee7add7be416bf20973422a041e913d20761commit | diff
OPENAFS-SA-2018-002 ubik: prevent VOTE_Debug, VOTE_XDebug information leak

VOTE_Debug and VOTE_XDebug (udebug) both leave a single field
uninitialized if there is no current transaction.  This leaks the memory
contents of the ubik server over the wire.

struct ubik_debug
- 4 bytes in member writeTrans

In common code to both RPCs, ensure that writeTrans is always
initialized.

[kaduk@mit.edu: switch to memset]

Change-Id: I91184b4ed0c159982a883ebaa9634406400eae93
src/ubik/vote.c diff | blob | history
OpenAFS Master Repository