libadmin: Don't free garbage pointer
authorSimon Wilkinson <sxw@your-file-system.com>
Sat, 2 Mar 2013 11:02:09 +0000 (11:02 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Thu, 7 Mar 2013 15:57:38 +0000 (07:57 -0800)
commit8260d86dda766a21e9f457994e7a3b259ba3a31b
tree217c108b1924585b5797fe23a4833ac55c489907
parentb535059d48ac592760e2e5b87414d9010143c993
libadmin: Don't free garbage pointer

If we jump to the error handler early on in pts_GroupOwnerChange,
idlist may not have been used, and so we will end up trying to
free stack garbage.

Initialise the structure to 0 at the start of the function, so it
is always safe to enter the error handler.

Caught by coverity (#985962)

Change-Id: If70102e3da07135a9ec695f13caebe6298eff8ca
Reviewed-on: http://gerrit.openafs.org/9398
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/libadmin/pts/afs_ptsAdmin.c