rxgen: Don't overflow PackageIndex
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 1 Mar 2013 11:35:05 +0000 (11:35 +0000)
committerDerrick Brashear <shadow@your-file-system.com>
Mon, 4 Mar 2013 03:02:25 +0000 (19:02 -0800)
commita1d8109c8fa8c10e3ce5ed67cda03b3b557608ff
tree53a2d00f120ce1ad745cd8c4618a59cab8dd578b
parentff7fd58b49a41bf85df492b9f470004d4433800e
rxgen: Don't overflow PackageIndex

PackageIndex++ returns the pre-index value of PackageIndex, so the
error statement isn't run when PackageIndex == MAX_PACKAGES. This
means we go on to overflow all of the arrays that are MAX_PACKAGES
in size.

Caught by coverity (#985583, #985584, #985585, #985586,
                    #985587, #985588, #985589)

Change-Id: If81f9ff89edc4cfd56677ff51cea71281ebe1e3b
Reviewed-on: http://gerrit.openafs.org/9325
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
src/rxgen/rpc_parse.c