viced: Check for HOSTDELETED in stillborn check
authorAndrew Deason <adeason@sinenomine.net>
Mon, 3 Oct 2011 18:10:44 +0000 (13:10 -0500)
committerDerrick Brashear <shadow@dementix.org>
Mon, 24 Oct 2011 20:13:06 +0000 (13:13 -0700)
commitb5a153fb75bb6642490e9856dc6212244a590301
tree26df19d5e438ef29b432ea7a0b8d56a0ba6ffb5b
parent13a4642458254e6bdbfa6fd8e165c270f567a1aa
viced: Check for HOSTDELETED in stillborn check

h_FindClient_r checks the connection rock for a client object twice.
First it sees if we already have a client object, and if we don't, we
effectively create one (or find a suitable one). Then we check again,
to see if someone else set the rock while we were creating a client
structure.

Currently, the first check checks if client->host->hostFlags has
HOSTDELETED set, but the second check does not. So, if the host
associated with the client has been deleted by someone else, currently
we will unnecessarily log a "stillborn client" message, and we will
continue to use the deleted host. If the host continues to be held by
someone, we will run into the same situation repeatedly on future
requests until all of the host references go away.

To fix this, also ignore HOSTDELETED clients when performing the
stillborn race check.

Change-Id: Id72e83cb55b99a686d4179905116592e80eb9ac7
Reviewed-on: http://gerrit.openafs.org/5614
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/viced/host.c