butc: avoid testing stack garbage; remove dead initializer
authorGarrett Wollman <wollman@csail.mit.edu>
Sun, 7 Aug 2011 03:49:10 +0000 (23:49 -0400)
committerDerrick Brashear <shadow@dementia.org>
Sun, 7 Aug 2011 15:56:09 +0000 (08:56 -0700)
commitc92f04af6094ce04b1541a1b23b254d3c1421290
tree317c5b11c2ad572020a51ad194f8a97b0de369d7
parent34cc26a1b11bc8cf8f91996a019ac4b7d21dccd8
butc: avoid testing stack garbage; remove dead initializer

"code" is unconditionally set early in saveDbToTape() so there's
no need to initialize it.  On the other hand, dumpEntry.id is used
before dumpEntry is initialized, so set it to what appears to be
the expected value before any non-local exits could cause it to be
inspected.

Change-Id: I133f8e84e46d0faedf3c9683330d92158bcd8935
Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5166
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/butc/tcudbprocs.c