volser: Fix bad readlink usage
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 26 Feb 2013 21:28:52 +0000 (21:28 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Wed, 27 Feb 2013 20:37:48 +0000 (12:37 -0800)
commitddc37043351056c402158610477312f0d7d01c13
treedf584c43abd3681c718511b17d96404538bf41e6
parentcaabad98232557220f153461520fc0cf1c6978fb
volser: Fix bad readlink usage

readlink fills the buffer passed to it with a non-terminated string.
It can legitimately fill the whole of this buffer. So, if we require
a string to be NUL terminated, we must give readlink one less than
the string length so that the termination character can be safely
appended.

Caught by coverity (#985611)

Change-Id: Ie6c651a9c0fd94d83bd05395204341d71e353146
Reviewed-on: http://gerrit.openafs.org/9290
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/volser/restorevol.c