volser: Close dirp on error in ConvertROtoRW 42/14342/3
authorMarcio Barbosa <mbarbosa@sinenomine.net>
Thu, 3 Sep 2020 20:11:34 +0000 (20:11 +0000)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 23 Oct 2020 16:16:07 +0000 (12:16 -0400)
commitf18b58f8227df2ab420d69eb5937a99f747c7692
treed1d494d99f3c9f6eb91adb392fca99fa680f9bca
parent47d809d4434f6724d0b6fbe2dcb54749486eeddb
volser: Close dirp on error in ConvertROtoRW

Currently, if SAFSVolConvertROtoRWvolume cannot create a new transaction
for the volume to be converted, it returns without closing the directory
stream opened by it. To prevent this leak, go through a new 'goto done'
destructor if NewTrans fails.

Change-Id: Ie0580e7739ae667f1cd2f9cabb8aaf5e15d3f2dd
Reviewed-on: https://gerrit.openafs.org/14342
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/volser/volprocs.c