Linux 4.4: Do not use splice() 17/12217/5
authorStephan Wiesand <stephan.wiesand@desy.de>
Tue, 8 Mar 2016 13:15:17 +0000 (14:15 +0100)
committerBenjamin Kaduk <kaduk@mit.edu>
Mon, 21 Mar 2016 17:33:08 +0000 (13:33 -0400)
commitae5f411c3b374367ab8ae69488f78f8e0484ce48
tree708f5e56fec22365abbcd5646b5aeb4545528b8a
parent58d82226a555d3781a5cb45e5cc177727628ebd8
Linux 4.4: Do not use splice()

splice() may return -ERESTARTSYS if there are pending signals, and
it's not even clear how this should be dealt with. This potential
problem has been present for a long time, but as of Linux 4.4
(commit c725bfce7968009756ed2836a8cd7ba4dc163011) seems much more
likely to happen.

Until resources are available to fix the code to handle such errors,
avoid the riskier uses of splice().

If there is a default implementation of file_splice_{write,read},
use that; on somewhat older kernels where it is not available,
use the generic version instead.

[kaduk@mit.edu: add test for default_file_splice_write]

Change-Id: Ib4477cdfb2cd0f49f516da75edc3cb9d1a8817dc
Reviewed-on: https://gerrit.openafs.org/12217
Reviewed-by: Chas Williams <3chas3@gmail.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
acinclude.m4
src/afs/LINUX/osi_fetchstore.c
src/afs/LINUX/osi_vnodeops.c
src/afs/afs_fetchstore.c