Remove dead code 83/13683/7
authorAndrew Deason <adeason@sinenomine.net>
Wed, 10 Jul 2019 20:14:28 +0000 (15:14 -0500)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 23 Aug 2019 13:36:44 +0000 (09:36 -0400)
commit339167ef1fda899655969f4572ff95271dfdb7cf
tree24925e2a271d7b235e337add61f91f48ca149d7f
parent0d6a43e0699fca00bff87c5e16c901e4579d2285
Remove dead code

There is a perhaps-surprisingly large amount of code disabled behind
directives like '#if 0', '#ifdef notdef', and '#ifdef notyet'. At
best, this code is clutter, and at worst some of it is
confusing/outdated, and/or confusingly nested inside other
preprocessor conditionals. Sometimes this disabled code shows up when
grepping the tree, and causes a nuisance when refactoring related
areas of code.

Get rid of all of it. If anyone ever wants this code back, it can
always be restored by reverting portions of this commit.

Also delete some comments that clearly refer to the disabled code, and
in some cases, adjust the adjacent comments to make sense accordingly.

This commit doesn't touch any files in src/external/.

Change-Id: If260a41257e8d107930bd3c177eddb8ab336f0d1
Reviewed-on: https://gerrit.openafs.org/13683
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: Benjamin Kaduk <kaduk@mit.edu>
176 files changed:
src/JAVA/libjafs/File.c
src/WINNT/afsadmsvr/TaAfsAdmSvrClientBind.cpp
src/WINNT/afsadmsvr/TaAfsAdmSvrMain.cpp
src/WINNT/afsapplib/al_browseset.cpp
src/WINNT/afsapplib/resize.cpp
src/WINNT/afsclass/worker.cpp
src/WINNT/afsd/cm_btree.c
src/WINNT/afsd/cm_buf.c
src/WINNT/afsd/cm_daemon.c
src/WINNT/afsd/cm_ioctl.c
src/WINNT/afsd/cm_nls.c
src/WINNT/afsd/cm_nls.h
src/WINNT/afsd/cm_performance.c
src/WINNT/afsd/cm_vnodeops.c
src/WINNT/afsd/fs.c
src/WINNT/afsd/krb.h
src/WINNT/afsd/rpc_srvsvc.c
src/WINNT/afsd/smb.c
src/WINNT/afsd/smb3.c
src/WINNT/afsrdr/kernel/lib/AFSInit.cpp
src/WINNT/afsrdr/user/RDRFunction.c
src/WINNT/client_config/config.cpp
src/WINNT/client_config/drivemap.cpp
src/WINNT/client_config/tab_hosts.cpp
src/WINNT/client_osi/osidb.c
src/WINNT/client_osi/osidebug.c
src/WINNT/install/loopback/wmi.cpp
src/WINNT/kfw/inc/krb4/conf.h
src/WINNT/kfw/inc/krb4/krb.h
src/WINNT/kfw/inc/krb5/krb5/krb5.h
src/WINNT/kfw/inc/krbcc/cacheapi.h
src/WINNT/kfw/inc/loadfuncs/loadfuncs-krb5.h
src/WINNT/kfw/inc/netidmgr/khmsgtypes.h
src/WINNT/netidmgr_plugin/afsfuncs.c
src/WINNT/netidmgr_plugin/afsplugin.c
src/WINNT/tests/largefiles/lftest.c
src/WINNT/tests/torture/Source/WinTorture.c
src/afs/AIX/osi_sleep.c
src/afs/AIX/osi_vnodeops.c
src/afs/DARWIN/osi_inode.c
src/afs/DARWIN/osi_machdep.h
src/afs/DARWIN/osi_vfsops.c
src/afs/DARWIN/osi_vm.c
src/afs/DARWIN/osi_vnodeops.c
src/afs/FBSD/osi_inode.c
src/afs/FBSD/osi_vnodeops.c
src/afs/HPUX/osi_vnodeops.c
src/afs/IRIX/osi_vfs.h
src/afs/LINUX/osi_nfssrv.c
src/afs/LINUX/osi_probe.c
src/afs/LINUX/osi_vnodeops.c
src/afs/NBSD/osi_file.c
src/afs/NBSD/osi_machdep.h
src/afs/NBSD/osi_vnodeops.c
src/afs/OBSD/osi_file.c
src/afs/OBSD/osi_misc.c
src/afs/OBSD/osi_vnodeops.c
src/afs/UKERNEL/osi_machdep.h
src/afs/VNOPS/afs_vnop_lookup.c
src/afs/afs_callback.c
src/afs/afs_daemons.c
src/afs/afs_disconnected.c
src/afs/afs_fetchstore.c
src/afs/afs_pag_cred.c
src/afs/afs_pioctl.c
src/afs/afs_vcache.c
src/afs/afs_volume.c
src/afsd/afsd.c
src/afsmonitor/afsmon-win.c
src/afsmonitor/afsmonitor.c
src/afsweb/nsafs.c
src/aklog/aklog.c
src/auth/ktc.c
src/auth/ktc_nt.c
src/bozo/bnode.c
src/bucoord/bc_status.c
src/bucoord/config.c
src/bucoord/dsstub.c
src/bucoord/dump.c
src/budb/database.h
src/budb/db_dump.c
src/budb/db_hash.c
src/budb/procs.c
src/butc/afsxbsa.c
src/butc/recoverDb.c
src/butc/tcmain.c
src/comerr/error_table_nt.c
src/config/param.nbsd40.h
src/config/param.nbsd50.h
src/config/param.nbsd60.h
src/config/param.nbsd70.h
src/config/param.sgi_65.h
src/config/param.sun4x_510.h
src/config/param.sun4x_511.h
src/config/param.sun4x_58.h
src/config/param.sun4x_59.h
src/config/param.sunx86_510.h
src/config/param.sunx86_511.h
src/config/param.sunx86_58.h
src/config/param.sunx86_59.h
src/config/stds.h
src/export/cfgafs.c
src/export/cfgexport.c
src/export/export.c
src/gtx/curses_test.c
src/gtx/gtxX11win.h
src/gtx/gtxdumbwin.h
src/gtx/object_test.c
src/kauth/admin_tools.c
src/kauth/crypt.c
src/kauth/kadatabase.c
src/kauth/kaprocs.c
src/kauth/kpasswd.c
src/libadmin/test/bos.c
src/libadmin/test/vos.c
src/libadmin/vos/vsprocs.c
src/lwp/lock.h
src/lwp/test/selserver.c
src/platform/DARWIN/AFSPreference/Krb5Util.m
src/platform/DARWIN/growlagent/main.m
src/ptserver/ptclient.c
src/ptserver/ptprocs.c
src/ptserver/pts.c
src/ptserver/testpt.c
src/rx/AIX/rx_knet.c
src/rx/FBSD/rx_knet.c
src/rx/HPUX/rx_kmutex.h
src/rx/NBSD/rx_knet.c
src/rx/rx_packet.h
src/rxgen/rpc_cout.c
src/rxgen/rpc_parse.c
src/rxkad/bg-fcrypt.c
src/rxkad/fcrypt.c
src/rxkad/rxkad_convert.h
src/rxkad/test/stress_c.c
src/rxkad/test/stress_s.c
src/rxkad/ticket5.c
src/scout/scout.c
src/sys/afssyscalls.c
src/tests/afscp.c
src/tests/asu.c
src/tests/ga-test.c
src/tests/large-dir.c
src/tests/large-dir2.c
src/tests/mmap-and-read.c
src/tests/rename-under-feet.c
src/tools/dumpscan/directory.c
src/tools/dumpscan/dumptool.c
src/tools/dumpscan/intNN.h
src/tsalvaged/salvsync-debug.c
src/tsm41/aix_aklog.c
src/ubik/utst_server.c
src/uss/uss_common.c
src/uss/uss_vol.c
src/uss/uss_vol.h
src/util/afs_lhash.c
src/util/ktime.c
src/venus/fs.c
src/venus/fstrace.c
src/venus/kdump.c
src/venus/test/fulltest.c
src/vfsck/pass5.c
src/viced/afsfileprocs.c
src/viced/fsprobe.c
src/viced/state_analyzer.c
src/vol/listinodes.c
src/vol/partition.c
src/vol/purge.c
src/vol/salvsync-server.c
src/vol/volume.c
src/vol/volume.h
src/volser/restorevol.c
src/volser/vol-dump.c
src/volser/vos.c
src/volser/vsprocs.c
tests/rpctestlib/rpc_test_procs.c