clang-16: Fix conditionally unused-but-set variables 77/15177/5
authorCheyenne Wills <cwills@sinenomine.net>
Wed, 2 Nov 2022 20:47:04 +0000 (14:47 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 2 Dec 2022 02:29:25 +0000 (21:29 -0500)
commit97018ace991d300a6ff75a1dcd1a69b4044f2b89
tree3bb2d65da0eb3416fa75e0928e5409e8d499de4d
parent05eb420829f9bca155c1d5af9fe96844db974770
clang-16: Fix conditionally unused-but-set variables

clang-16 is flagging unused-but-set variables which result in build
errors when --enable-warning is turned on.

   remote.c:485:15: error: variable 'pass' set but not used
       [-Werror,-Wunused-but-set-variable]
     afs_int32 pass;
              ^
These variables are actually used in specific cases depending on
build configuration (e.g. AFS_PTHREAD_ENV, etc.).

Relocate these variables so they are fully defined or referenced within
preprocessor '#if' blocks.

Change-Id: I900a192ec781be4ab4453769e1d8f0cc48fe5757
Reviewed-on: https://gerrit.openafs.org/15177
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/afs/afs_daemons.c
src/kauth/kadatabase.c
src/ubik/recovery.c
src/ubik/remote.c
src/vol/volume.c