libadmin: Fix RPCStatsStateGet 'rpc' prototype 80/15180/5
authorCheyenne Wills <cwills@sinenomine.net>
Thu, 1 Dec 2022 17:00:06 +0000 (10:00 -0700)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 2 Dec 2022 02:35:43 +0000 (21:35 -0500)
commit97f0a20e50f027fe00adb22c39b71f0ac79f1ff7
tree4a86252c21e29df7fa0e4f9c8092d68147cf2b47
parentafafde158ff875d2459bb81ac373cde3e45dac03
libadmin: Fix RPCStatsStateGet 'rpc' prototype

clang-16 is flagging a incompatible-function-pointer-types warning which
results in build errors when --enable-warning is turned on.

   client.c:498:13: error: incompatible function pointer types passing
      'int (struct rx_connection *, afs_int32 *)'
      (aka 'int (struct rx_connection *, int *)') to parameter of type
      'int (*)(struct rx_connection *, afs_RPCStatsState_p)'
      (aka 'int (*)(struct rx_connection *, afs_RPCStatsState_t *)')
      [-Wincompatible-function-pointer-types]

    (conn, RXSTATS_QueryPeerRPCStats, &state, &st)) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~

Update the 'util_RPCStatsStateGet()' function's parameter to match the
function type for the RPC functions actually being called.

Change-Id: I4354dff2733ce2319b27a2f047cfe4a21ef3bcc8
Reviewed-on: https://gerrit.openafs.org/15180
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/libadmin/adminutil/afs_utilAdmin.c
src/libadmin/adminutil/afs_utilAdmin.h