Unix CM: Always use ->storeproc()

Always use ->storeproc() and avoid branching

"do or do not -- there is no try"

Change-Id: Idbcf0c80930d6a433b4c921b44db28cb6fbbf9bb
Reviewed-on: http://gerrit.openafs.org/1073
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

diff --git a/src/afs/afs_fetchstore.c b/src/afs/afs_fetchstore.c
index ee252f1..dd9c2b8 100644 (file)
--- a/src/afs/afs_fetchstore.c
+++ b/src/afs/afs_fetchstore.c
@@ -515,12 +515,8 @@ afs_CacheStoreDCaches(struct vcache *avc, struct dcache **dclist,
 #endif /* AFS_NOSTATS */
        bytesXferred = 0;
 
-       if (ops->storeproc)
-           code = (*ops->storeproc)(ops, rock, tdc, shouldwake,
+       code = (*ops->storeproc)(ops, rock, tdc, shouldwake,
                                     &bytesXferred);
-       else
-            code = afs_GenericStoreProc(ops, rock, tdc, shouldwake,
-                                       &bytesXferred);
 
        afs_Trace4(afs_iclSetp, CM_TRACE_STOREPROC, ICL_TYPE_POINTER, avc,
                    ICL_TYPE_FID, &(avc->f.fid), ICL_TYPE_OFFSET,