build: declare test targets as phony

Modern versions `make` will not build the 'test' target since a
directory exists with the same name.

    $ grep -C1 '^test:' Makefile
    test:
        cd test; $(MAKE)

    $ make test
    make: 'test' is up to date.

Declare these targets as .PHONY to force make to build the test programs
even when the 'test' directory is present. Also use '&&' to concatenate
commands instead ';' to avoid running the second command when the first
fails.

Change-Id: Id561d7610f80b87b59c632801fa0a4b216feb42d
Reviewed-on: https://gerrit.openafs.org/13419
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

diff --git a/src/auth/Makefile.in b/src/auth/Makefile.in
index 8dec8a6..d172019 100644 (file)
--- a/src/auth/Makefile.in
+++ b/src/auth/Makefile.in
@@ -177,8 +177,9 @@ dest: libauth.a libauth.krb.a auth.h cellconfig.h
 #
 # Misc. targets
 #
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 clean:
        $(LT_CLEAN)

diff --git a/src/bozo/Makefile.in b/src/bozo/Makefile.in
index 6b24f05..cfb3324 100644 (file)
--- a/src/bozo/Makefile.in
+++ b/src/bozo/Makefile.in
@@ -169,8 +169,9 @@ clean:
                bosint.cs.c bosint.ss.c bosint.xdr.c bosint.h \
                core boserr.c bnode.h AFS_component_version_number.c
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 include ../config/Makefile.version
 

diff --git a/src/comerr/Makefile.in b/src/comerr/Makefile.in
index b94f1c6..d906feb 100644 (file)
--- a/src/comerr/Makefile.in
+++ b/src/comerr/Makefile.in
@@ -89,8 +89,9 @@ clean:
                et_lex.lex.c test1.h test1.c test2.h test2.c \
                eddep makedep core AFS_component_version_number.c
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 compile_et.o:  AFS_component_version_number.c
 # specify yacc build product as a dependency so our .c.o rule will apply

diff --git a/src/dir/Makefile.in b/src/dir/Makefile.in
index 978ddc1..34c63f5 100644 (file)
--- a/src/dir/Makefile.in
+++ b/src/dir/Makefile.in
@@ -28,8 +28,9 @@ libdir.a: buffer.o dir.o salvage.o AFS_component_version_number.o
        $(AR) crv $@ buffer.o dir.o salvage.o  AFS_component_version_number.o
        $(RANLIB) $@
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 buffer.o: buffer.c dir.h
 

diff --git a/src/libacl/Makefile.in b/src/libacl/Makefile.in
index f2c90f5..fbf532c 100644 (file)
--- a/src/libacl/Makefile.in
+++ b/src/libacl/Makefile.in
@@ -64,8 +64,9 @@ dest: libacl.a acl.h prs_fs.h
 #
 # Misc. targets
 #
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 clean:
        $(LT_CLEAN)

diff --git a/src/log/Makefile.in b/src/log/Makefile.in
index e067d3a..f1cbf73 100644 (file)
--- a/src/log/Makefile.in
+++ b/src/log/Makefile.in
@@ -102,7 +102,8 @@ clean:
        $(RM) -f *.o unlog tokens kseal pagsh pagsh.krb \
                core AFS_component_version_number.c tokens.krb
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 include ../config/Makefile.version

diff --git a/src/util/Makefile.in b/src/util/Makefile.in
index f0dfcc8..5509e6f 100644 (file)
--- a/src/util/Makefile.in
+++ b/src/util/Makefile.in
@@ -212,8 +212,9 @@ clean:
        $(RM) -f sys dirpath.h
        $(RM) -f util.a *.o core AFS_component_version_number.c
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 include ../config/Makefile.version
 

diff --git a/src/venus/Makefile.in b/src/venus/Makefile.in
index 280107f..d778579 100644 (file)
--- a/src/venus/Makefile.in
+++ b/src/venus/Makefile.in
@@ -362,7 +362,8 @@ clean:
                AFS_component_version_number.c fstrace gcpags livesys dedebug \
                cacheout afsio
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 include ../config/Makefile.version

diff --git a/src/vol/Makefile.in b/src/vol/Makefile.in
index cb37d77..f6b85e6 100644 (file)
--- a/src/vol/Makefile.in
+++ b/src/vol/Makefile.in
@@ -245,8 +245,9 @@ clean:
        $(RM) -f *.o *.a AFS_component_version_number.c
        $(RM) -f ${SCMPROGS} ${STAGEPROGS} core salvager volinfo volscan gi fssync-debug
 
+.PHONY: test
 test:
-       cd test; $(MAKE)
+       cd test && $(MAKE)
 
 include ../config/Makefile.version