butc: Remove dead loop pointer allocations
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 24 Feb 2013 10:36:57 +0000 (10:36 +0000)
committerDerrick Brashear <shadow@your-file-system.com>
Mon, 25 Feb 2013 16:37:48 +0000 (08:37 -0800)
All of these *Ptr values are reset upon each iteration of the
while loop, so we don't need to NULL them immediately before
we go around again.

Caught by clang-analyzer

Change-Id: Iaa5ff6c7b154072e23eae272031919b424568eff
Reviewed-on: http://gerrit.openafs.org/9244
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/butc/dbentries.c

index a3faf8c..3a358ce 100644 (file)
@@ -474,10 +474,6 @@ dbWatcher(void *unused)
                    free(entryPtr->dlq_structPtr);
                free(entryPtr);
            }
-           entryPtr = (dlqlinkP) 0;
-           dumpPtr = (budb_dumpEntry *) 0;
-           volPtr = (budb_volumeEntry *) 0;
-           tapePtr = (budb_tapeEntry *) 0;
        }                       /*while */
 
        dbWatcherinprogress = 0;