vol: Log more info on wrong SYNC response length
authorAndrew Deason <adeason@sinenomine.net>
Mon, 10 Feb 2014 20:13:39 +0000 (14:13 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Sat, 22 Aug 2015 06:12:23 +0000 (02:12 -0400)
We log that the length of the response was wrong, so we're dropping
the connection. Log what the actual and expected lengths were, at
least, so we can maybe get a little bit of useful information from
this message.

Change-Id: I499d43c7625712b507698d908feb21477b789563
Reviewed-on: http://gerrit.openafs.org/10829
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/vol/daemon_com.c

index 9b5149a..4256a20 100644 (file)
@@ -440,7 +440,10 @@ SYNC_ask_internal(SYNC_client_state * state, SYNC_command * com, SYNC_response *
 
     if (res->hdr.response_len != n) {
        Log("SYNC_ask:  length field in response inconsistent "
-           "on circuit '%s'\n", state->proto_name);
+           "on circuit '%s' command %ld, %d != %lu\n", state->proto_name,
+           afs_printable_int32_ld(com->hdr.command),
+           n,
+           afs_printable_uint32_lu(res->hdr.response_len));
        res->hdr.response = SYNC_COM_ERROR;
        goto done;
     }