Commit
3f4c1099b7b (gerrit 10474) introduced a few issues, addressed here.
vpp is idiomatically of type 'struct vnode *', not 'struct vcache *';
use pvc as the name of the parent vcache pointer instead.
Fix whitespace.
Change-Id: Ic5d98a43446861bb571fe5a260e7ae1eea1051fd
Reviewed-on: http://gerrit.openafs.org/10531
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
* } */ *ap;
{
struct vnode *dvp = ap->a_dvp;
- struct vcache *vpp = NULL;
+ struct vcache *pvc = NULL;
int error = 0;
GETNAME();
AFS_GLOCK();
- error = afs_symlink(VTOAFS(dvp), name, ap->a_vap, ap->a_target, &vpp,
+ error = afs_symlink(VTOAFS(dvp), name, ap->a_vap, ap->a_target, &pvc,
vop_cn_cred);
AFS_GUNLOCK();
#ifndef AFS_DARWIN80_ENV
#endif
*ap->a_vpp = NULL;
if (!error) {
- error = afs_darwin_finalizevnode(vpp, dvp, ap->a_cnp, 0, 0);
- if (! error)
- *ap->a_vpp = AFSTOV(vpp);
+ error = afs_darwin_finalizevnode(pvc, dvp, ap->a_cnp, 0, 0);
+ if (!error)
+ *ap->a_vpp = AFSTOV(pvc);
}
DROPNAME();
return error;
VATTR_NULL(&vattr);
AFS_GLOCK();
code = afs_symlink(VTOAFS(dip), (char *)name, &vattr, (char *)target, NULL,
- credp);
+ credp);
AFS_GUNLOCK();
crfree(credp);
return afs_convert_code(code);
attrs.va_uid = afs_cr_uid(get_user_struct()->u_cred);
attrs.va_gid = afs_cr_gid(get_user_struct()->u_cred);
code = afs_symlink(VTOAFS(dirP), nameP, &attrs, target, NULL,
- get_user_struct()->u_cred);
+ get_user_struct()->u_cred);
VN_RELE(dirP);
if (code != 0) {
errno = code;
int (*vn_rmdir) (struct vcache *adp, char *, afs_ucred_t *);
int (*vn_readdir) (struct vcache *avc, struct uio *, afs_ucred_t *);
int (*vn_symlink) (struct vcache *adp, char *, struct vattr *, char *,
- struct vcache **vpp, afs_ucred_t *);
+ struct vcache **pvc, afs_ucred_t *);
int (*vn_readlink) (struct vcache *avc, struct uio *, afs_ucred_t *);
int (*vn_fsync) (struct vcache *avc, afs_ucred_t *);
int (*vn_inactive) (struct vcache *avc, afs_ucred_t *acred);
ReleaseWriteLock(&tvc->lock);
ReleaseWriteLock(&afs_xvcache);
if (tvcp)
- *tvcp = tvc;
+ *tvcp = tvc;
else
afs_PutVCache(tvc);
code = 0;