Windows: Generate a valid <revision> block using mkvers.c
authorJeffrey Altman <jaltman@your-file-system.com>
Tue, 13 Jul 2010 03:35:05 +0000 (23:35 -0400)
committerJeffrey Altman <jaltman@openafs.org>
Tue, 13 Jul 2010 13:06:12 +0000 (06:06 -0700)
The <revision> tag requires not only a <revnumber> but a <date>.

Change-Id: I3c5b7691d18381b1bf71bbd3d726bd284bf90919
Reviewed-on: http://gerrit.openafs.org/2390
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

src/config/mkvers.c

index 15118ea..38f252d 100644 (file)
@@ -18,7 +18,7 @@
 #include <sys/stat.h>
 #include <errno.h>
 #include <string.h>
-
+#include <time.h>
 
 #define VERINFO_STRING_CHARS_MAX  950  /* max chars in verinfo string */
 #define CFILE_STRING_CHARS_MAX    2000 /* max chars in C file string */
@@ -282,6 +282,7 @@ PrintStamps(void)
     char *c = NULL;
     int i;
     size_t outMax, outCount = 0;
+    time_t t = time(NULL);
 
     if (cfgFormat == CF_VERINFO) {
        outMax = VERINFO_STRING_CHARS_MAX;
@@ -305,8 +306,12 @@ PrintStamps(void)
                         "<revision>\n"
                         "<revnumber>\n"
                         "Base configuration %s\n"
-                        "</revnumber>\n",
-                       stateDeltas[i].name);
+                        "</revnumber>\n"
+                        "<date>\n"
+                        "%s"
+                        "</date>\n"
+                        "</revision>\n",
+                       stateDeltas[i].name, ctime(&t));
            } else {
                fprintf(fpVers, "%sBase configuration %s", cml_string,
                        stateDeltas[i].name);