git://git.openafs.org
/
openafs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
(parent:
4c6238b
)
unitialized-return-variable-20040402
author
Jeffrey Altman
<jaltman@mit.edu>
Fri, 2 Apr 2004 17:41:27 +0000 (17:41 +0000)
committer
Jeffrey Altman
<jaltman@secure-endpoints.com>
Fri, 2 Apr 2004 17:41:27 +0000 (17:41 +0000)
krb5_des_decrypt() does not initialize the return value to 1, failure,
therefore it returns random success (0) values when ticket types of
DES-CBC-MD5 or DES-CBC-MD4 are used because we do not have checksum
functions for those types.
src/rxkad/ticket5.c
patch
|
blob
|
history
diff --git
a/src/rxkad/ticket5.c
b/src/rxkad/ticket5.c
index
8abf468
..
9c22d20
100644
(file)
--- a/
src/rxkad/ticket5.c
+++ b/
src/rxkad/ticket5.c
@@
-413,7
+413,7
@@
krb5_des_decrypt(struct ktc_encryptionKey *key, int etype, void *in,
des_key_schedule s;
char cksum[24];
size_t cksumsz;
- int ret;
+ int ret = 1; /* failure */
cksum_func = NULL;