vlserver: unsigned values are always >0
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 30 Mar 2012 18:33:55 +0000 (19:33 +0100)
committerDerrick Brashear <shadow@dementix.org>
Mon, 9 Apr 2012 01:15:21 +0000 (18:15 -0700)
Maxvolidbump is defined as an unisgned int, and thus can never be less
than 0. Remove the pointless check, as it just makes clang sad.

Change-Id: I78a2c8f6fcaee17196e37183256e6935cdca183b
Reviewed-on: http://gerrit.openafs.org/7084
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>

src/vlserver/vlprocs.c

index 0bc0147..6868edb 100644 (file)
@@ -683,7 +683,7 @@ SVL_GetNewVolumeId(struct rx_call *rxcall, afs_uint32 Maxvolidbump,
     if (!afsconf_SuperUser(vldb_confdir, rxcall, NULL))
        END(VL_PERM);
 
-    if (Maxvolidbump < 0 || Maxvolidbump > MAXBUMPCOUNT)
+    if (Maxvolidbump > MAXBUMPCOUNT)
        END(VL_BADVOLIDBUMP);
 
     if ((code = Init_VLdbase(&ctx, LOCKWRITE, this_op)))