budb: Fail if afsconf_GetExtendedCellInfo does
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 24 Feb 2013 10:43:52 +0000 (10:43 +0000)
committerDerrick Brashear <shadow@your-file-system.com>
Mon, 25 Feb 2013 16:38:05 +0000 (08:38 -0800)
Rather than silently ignoring the failure of
afsconf_GetExtendedCellInfo, and then using garbage cell
configuration, just fail to start if afsconf can't parse the
config directory.

Change-Id: Ib3d26bc67844de10f7eb8c2ef555c5e607e4bf61
Reviewed-on: http://gerrit.openafs.org/9247
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/budb/server.c

index dd8f24f..ee4536c 100644 (file)
@@ -482,6 +482,11 @@ main(int argc, char **argv)
 
        code = afsconf_GetExtendedCellInfo (BU_conf, lcell, 0, &cellinfo,
                                            clones);
+       if (code) {
+           LogError(0, "Can't read cell information\n");
+           ERROR(code);
+       }
+
        code =
            convert_cell_to_ubik(&cellinfo, &globalConfPtr->myHost,
                                 globalConfPtr->serverList);