windows-smb-lock-order-20080903
authorJeffrey Altman <jaltman@secure-endpoints.com>
Wed, 3 Sep 2008 21:37:00 +0000 (21:37 +0000)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Wed, 3 Sep 2008 21:37:00 +0000 (21:37 +0000)
LICENSE MIT

another lock order violation to fix

src/WINNT/afsd/smb.c

index a5d5da6..ae083f9 100644 (file)
@@ -9860,6 +9860,7 @@ void smb_Shutdown(void)
             if (fidp->scp != NULL) {
                 cm_scache_t * scp;
 
+                lock_ReleaseWrite(&smb_rctLock);
                 lock_ObtainMutex(&fidp->mx);
                 if (fidp->scp != NULL) {
                     scp = fidp->scp;
@@ -9871,6 +9872,7 @@ void smb_Shutdown(void)
                     cm_ReleaseSCache(scp);
                 }
                 lock_ReleaseMutex(&fidp->mx);
+                lock_ObtainWrite(&smb_rctLock);
             }
         }