volser: Don't catch errors in cleanup
authorSimon Wilkinson <sxw@your-file-system.com>
Mon, 25 Feb 2013 10:26:33 +0000 (10:26 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Mon, 25 Feb 2013 21:28:26 +0000 (13:28 -0800)
We can't do anything if cleaning up the clone volume fails, so
don't bother storing the error code.

Caught by clang-analyzer

Change-Id: I5249dbad9a1bb732aba73e7a09f74c83e606b45d
Reviewed-on: http://gerrit.openafs.org/9258
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

src/volser/vsprocs.c

index a5147b0..7af0d9f 100644 (file)
@@ -2578,8 +2578,8 @@ cpincr:
 
     /* common cleanup - delete local clone */
     if (cloneVol)
-       code = DoVolDelete(fromconn, cloneVol, afrompart,
-                          "clone", 0, NULL, "Recovery:");
+       DoVolDelete(fromconn, cloneVol, afrompart,
+                   "clone", 0, NULL, "Recovery:");
 
   done:                        /* routine cleanup */
     if (fromconn)