afsmonitor: Check correct variable is non-NULL
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 26 Feb 2013 20:51:34 +0000 (20:51 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Wed, 27 Feb 2013 20:36:23 +0000 (12:36 -0800)
Before freeing curr_fsData, check that it is non-NULL, rather than
checking prev_fsData in error.

Caught by coverity (#985289)

Change-Id: I8fb74ce0c4e447de65924f2afb6075213d839760
Reviewed-on: http://gerrit.openafs.org/9284
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

src/afsmonitor/afsmonitor.c

index eee5936..953ba04 100644 (file)
@@ -491,7 +491,7 @@ afsmon_Exit(int a_exitVal)  /* exit code */
            fprintf(debugFD, ", prev \n");
        free(prev_fsData);
     }
-    if (prev_cmData != (struct cm_Display_Data *)0) {
+    if (curr_cmData != (struct cm_Display_Data *)0) {
        if (afsmon_debug)
            fprintf(debugFD, "Deallocating CM Print Buffers .... curr");
        free(curr_cmData);