kas_principalEntry_t Entry;
if (kas_PrincipalGet (hCell, NULL, &Identity, &Entry, &status))
{
- if (Entry.adminSetting == ADMIN)
+ if (Entry.adminSetting == KAS_ADMIN)
rc = TRUE;
}
void WIZARD::SetGraphic (int idbGraphic16, int idbGraphic256)
{
LPRGBQUAD pargb = NULL;
+ RGBQUAD argb[256];
m_idbGraphic16 = idbGraphic16;
m_idbGraphic256 = idbGraphic256;
HDC hdc = CreateCompatibleDC (NULL);
HBITMAP bmpOld = (HBITMAP)SelectObject (hdc, m_bmpGraphic256);
- RGBQUAD argb[256];
GetDIBColorTable (hdc, 0, 256, argb);
pargb = argb;
m_mszMembers = NULL;
m_mszMemberOf = NULL;
m_mszOwnerOf = NULL;
+ memset(&m_gs, 0, sizeof(m_gs));
}
m_fDelete = FALSE;
m_lastStatus = 0;
+ m_fVLDBOutOfDate = FALSE; /* FIXME: added because it was missing */
m_fStatusOutOfDate = TRUE;
memset (&m_ss, 0x00, sizeof(SERVERSTATUS));
}
m_fStatusOutOfDate = TRUE;
m_mszOwnerOf = NULL;
m_mszMemberOf = NULL;
+ memset(&m_us, 0, sizeof(m_us));
}
CopyAnsiToString (szLastModPrincipal, wpGetKas.wpKasPrincipalGet.Data.lastModPrincipal.principal);
CopyAnsiToString (szLastModInstance, wpGetKas.wpKasPrincipalGet.Data.lastModPrincipal.instance);
- m_us.KASINFO.fIsAdmin = (wpGetKas.wpKasPrincipalGet.Data.adminSetting == ADMIN) ? TRUE : FALSE;
+ m_us.KASINFO.fIsAdmin = (wpGetKas.wpKasPrincipalGet.Data.adminSetting == KAS_ADMIN) ? TRUE : FALSE;
m_us.KASINFO.fCanGetTickets = (wpGetKas.wpKasPrincipalGet.Data.tgsSetting == TGS) ? TRUE : FALSE;
m_us.KASINFO.fEncrypt = (wpGetKas.wpKasPrincipalGet.Data.encSetting == ENCRYPT) ? TRUE : FALSE;
m_us.KASINFO.fCanChangePassword = (wpGetKas.wpKasPrincipalGet.Data.cpwSetting == CHANGE_PASSWORD) ? TRUE : FALSE;
lpoa->nAlerts ++;
lpoa->aAlerts[ iInsert ].alert = alertTIMEOUT;
lpoa->aAlerts[ iInsert ].aiTIMEOUT.status = status;
- lpoa->aAlerts[ iInsert ].aiTIMEOUT.stLastAttempt;
GetSystemTime (&lpoa->aAlerts[ iInsert ].aiTIMEOUT.stLastAttempt);
fChanged = TRUE;
GetString (szText, IDS_AGGREGATE_NO_PROBLEMS);
else if (lpi->fIsFileset())
GetString (szText, IDS_FILESET_NO_PROBLEMS);
+ else
+ wsprintf (szText, TEXT("UNEXPECTED CONDITION in problems.cpp"));
SetDlgItemText (hDlg, IDC_PROBLEM_TEXT, szText);
break;
if (!fEnable)
CheckDlgButton (hDlg, IDC_CLONE_AGG_LIMIT, FALSE);
- fEnable &= IsDlgButtonChecked (hDlg, IDC_CLONE_AGG_LIMIT) && pcsp->fEnumedAggregs;
+ fEnable = fEnable && IsDlgButtonChecked (hDlg, IDC_CLONE_AGG_LIMIT) && pcsp->fEnumedAggregs;
EnableWindow (GetDlgItem (hDlg, IDC_CLONE_AGG), fEnable);
fEnable = IsDlgButtonChecked (hDlg, IDC_CLONE_PREFIX_LIMIT);
free(tdir);
UNLOCK_GLOBAL_MUTEX return (struct afsconf_dir *)0;
}
- fgets(afs_confdir, 128, fp);
- fclose(fp);
}
fgets(afs_confdir, 128, fp);
fclose(fp);
strcompose(tbuffer, 256, adir->name, "/", AFSDIR_THISCELL_FILE, NULL);
tf = fopen(tbuffer, "r");
if (tf) {
+ /* FIXME: buffer overflow waiting to happen */
rc = fscanf(tf, "%s", tbuffer);
if (rc == 1) {
adir->cellName = (char *)malloc(strlen(tbuffer) + 1);
if (code) {
afsconf_CloseInternal(adir);
fclose(tf);
+ free(curEntry);
return -1;
}
if (linkedcell[0] != '\0') {
if (*aline == '[') {
if (aclone)
*aclone = 1;
+ /* FIXME: length of aname unknown here */
code = sscanf(aline, "[%d.%d.%d.%d] #%s", &c1, &c2, &c3, &c4, aname);
} else {
if (aclone)
*aclone = 0;
+ /* FIXME: length of aname unknown here */
code = sscanf(aline, "%d.%d.%d.%d #%s", &c1, &c2, &c3, &c4, aname);
}
if (code != 5)
register char *alname)
{
register int code;
+ /* FIXME: length of aname, alname unknown here */
code = sscanf(aline, ">%s %s", aname, alname);
if (code == 1)
*alname = '\0';
register FILE *tf;
register FILE *nf;
register int flag;
- char tname[64];
+ char tname[64 + 1];
char *tp;
int found;
struct stat tstat;
{
char tbuffer[256];
register FILE *tf;
- char tname[64];
+ char tname[64 + 1];
register char *tp;
register int flag;
register afs_int32 code;
}
/* returns true iff user is in the UserList file */
-static
+static int
FindUser(adir, auser)
struct afsconf_dir *adir;
register char *auser;
{
char tbuffer[256];
register bufio_p bp;
- char tname[64];
+ char tname[64 + 1];
register int flag;
register afs_int32 code;
int rc;
rx_SetRxDeadTime(60);
/* VLDB initialization */
- vldbClientInit(0, localauth, tcell, &cstruct, &ttoken);
+ code = vldbClientInit(0, localauth, tcell, &cstruct, &ttoken);
if (code)
return (code);
static afs_int32(*checkEntry[NBLOCKTYPES]) ()
= {
+ /* FIXME: this list does not match typeName[] and may be incorrect */
0, /* free block */
verifyVolFragEntry, verifyVolInfoEntry, verifyTapeEntry, verifyDumpEntry, 0 /* text block */
};
pinitopcode = (char *)malloc(sizeof(initcmd_opcode));
if (!pinitopcode) {
fprintf(stderr, "%s: Can't malloc initial opcode space\n", aargv[0]);
+ free(newargv);
return (NULL);
}
strcpy(pinitopcode, initcmd_opcode);
char *
xmalloc(unsigned int size)
{
- char *p = malloc(size);
+ char *p = (char *)malloc(size);
if (!p) {
perror(whoami);
exit(1);
if (cml_prefix) {
cml_string =
- malloc(strlen("char ") + strlen(cml_prefix) + strlen(CML_STRING) +
+ (char *)malloc(strlen("char ") + strlen(cml_prefix) + strlen(CML_STRING) +
1);
if (!cml_string) {
printf("No space to use prefix in cml string, ignoring it.\n");
if ((finfo.attrib & ~_A_ARCH) != _A_NORMAL)
continue;
fh = _open(finfo.name, _S_IWRITE | _O_BINARY | _S_IREAD | _O_RDWR);
- pos = _lseek(fh, 0l, SEEK_END);
+ pos = _lseek(fh, 0L, SEEK_END);
+ buffer[0] = 0;
_write(fh, buffer, 1);
_chsize(fh, pos);
_close(fh);
break;
case 3: //1.0.401 or 1.0.40a are the same;
if ((isdigit(*ptr) == 0) // first 2 must be digit
- || (isdigit(*(ptr + 1) == 0))
+ || (isdigit(*(ptr + 1)) == 0)
|| (*(ptr + 1) != '0' && isdigit(*(ptr + 2)) == 0) // disallow 1.0.4b0 or 1.0.41a
)
usuage();
if (isdigit(*ptr) == 0 || isdigit(*(ptr + 1)) == 0)
usuage();
pat2 = atoi(ptr);
+ break;
default:
usuage();
}
if (file == NULL)
usuage();
len = filelength(_fileno(file));
- buf = (char *)malloc(len + 1);
+ save = (char *)malloc(len + 1);
+ buf = save;
len = fread(buf, sizeof(char), len, file);
buf[len] = 0; //set eof
fclose(file);
buf = ptr + 1;
}
fclose(file);
+ free(save);
return 0;
}
if (strcmp(argv[1], "~") == 0) { //check for file presence
if (file == NULL)
exit(0xc000);
len = filelength(_fileno(file));
- ch = (char *)malloc(len + 2);
+ save = (char *)malloc(len + 2);
+ ch = save;
*ch++ = 0; /* a small hack to allow matching /r/n if /n is first character */
len = fread(ch, sizeof(char), len, file);
file = freopen(fname, "wb", file);
ch++;
}
fclose(file);
+ free(save);
return 0;
}
if (strcmp(argv[1], "-") == 0) {
if (file == NULL)
exit(0xc000);
len = filelength(_fileno(file));
- ch = (char *)malloc(len + 1);
+ save = (char *)malloc(len + 1);
+ ch = save;
len = fread(ch, sizeof(char), len, file);
file = freopen(fname, "wb", file);
while (len-- > 0) {
ch++;
}
fclose(file);
+ free(save);
return 0;
}
if (strstr(fname, ".et") == NULL)
if (file == NULL)
exit(0xc000);
len = filelength(_fileno(file));
- ch = (char *)malloc(len + 1);
+ save = (char *)malloc(len + 1);
+ ch = save;
len = fread(ch, sizeof(char), len, file);
file = freopen(fname, "wb", file);
while (len-- > 0) {
pvar[i] = argv[i + 1];
pvar[argc - 1] = NULL;
pvar[0] = argv[1];
- l = _spawnvp(_P_WAIT, argv[1], pvar);
- if (ch)
- free(ch);
+ (void)_spawnvp(_P_WAIT, argv[1], pvar);
+ if (save)
+ free(save);
if (pvar)
free(pvar);
return 0;
#define LOAD(d,d0,d1,bl) d0 = (bl).b32.i0, d1 = (bl).b32.i1
#define LOADREG(d,d0,d1,s,s0,s1) d0 = s0, d1 = s1
#define OR(d,d0,d1,bl) d0 |= (bl).b32.i0, d1 |= (bl).b32.i1
-#define STORE(s,s0,s1,bl) (bl).b32.i0 = s0, (bl).b32.i1 = s1
+#define STORE(s,s0,s1,bl) (bl).b32.i0 = (s0), (bl).b32.i1 = (s1)
#define DCL_BLOCK(d,d0,d1) long d0, d1
#if defined(LARGEDATA)
/* Definitions for byte swapping */
#ifdef LSBFIRST
-#define vaxtohl(x) *((afs_uint32 *)(x))
-#define vaxtohs(x) *((unsigned short *)(x))
+#define vaxtohl(x) (*((afs_uint32 *)(x)))
+#define vaxtohs(x) (*((unsigned short *)(x)))
#else
static afs_uint32 four_bytes_vax_to_nets();
#define vaxtohl(x) four_bytes_vax_to_nets((char *)(x))
{
if (insist == 0) {
/* see if it is reasonable, but don't get so obnoxious */
+ /* FIXME: null pointer derefence!!! */
(*insist)++; /* so we don't get called again */
if (strlen(newpw) < 6)
return 0;
Print_bos_ProcessState_p(bos_ProcessState_p state, const char *prefix)
{
printf("%sProcess state:\n", prefix);
+ /* FIXME: BOS_PROCESS_OK is 0, so this test is not right */
if (*state & BOS_PROCESS_OK) {
printf("%s\tBOS_PROCESS_OK:\n", prefix);
}
for (i = 0; i < KAS_ENCRYPTION_KEY_LEN; i++) {
printf("%d ", principal->key.key[i]);
}
- printf("\n", prefix);
+ printf("\n");
printf("%sKey checksum %u\n", prefix, principal->keyCheckSum);
printf("%sDays to password expire %d\n", prefix,
if (tid) {
etst = AFSVolEndTrans(server, tid, &rcode);
+ /* FIXME: this looks like a typo */
if (etst || etst) {
if (!tst)
tst = (etst ? etst : rcode);
#define TRUE 1
#ifndef MIN
-#define MIN(a,b) ((a)>(b)) ? b : a
+#define MIN(a,b) (((a)>(b)) ? (b) : (a))
#endif
#ifndef NSIG
#else /* AFS_PTHREAD_ENV */
me = (PROCESS) LWP_ThreadId();
#endif /* AFS_PTHREAD_ENV */
- ptr = (char *)&MainThread;
+ ptr = &MainThread[0];
for (i = 0; i < nThreads; i++) {
if (ThreadId[i] == me) {
- ptr = (char *)&ThreadName[i];
+ ptr = &ThreadName[i][0];
break;
}
}
LWP_GetLine(char *linebuf, int len)
{
int cnt = 0;
- char ch = '\0';
+ int ch = 0;
fflush(stdin);
/* loop until a new line has been entered */
extern afs_int32 depthsg;
#endif
-extern afs_int32 ubik_lastYesTime;
-extern afs_int32 ubik_nBuffers;
-
extern int afsconf_ServerAuth();
extern int afsconf_CheckAuth();
int pr_realmNameLen;
char *pr_realmName;
+static struct afsconf_cell info;
+
#include "AFS_component_version_number.c"
/* check whether caller is authorized to manage RX statistics */
#if 0
struct ktc_encryptionKey tkey;
#endif
- struct afsconf_cell info;
int kerberosKeys; /* set if found some keys */
int lwps = 3;
char clones[MAXHOSTSPERCELL];
}
rx_listenerPid = pid;
if (swapNameProgram)
- (*swapNameProgram) (pid, "listener", &name);
+ (*swapNameProgram) (pid, "listener", &name[0]);
for (;;) {
/* Grab a new packet only if necessary (otherwise re-use the old one) */
/* copy data from an RX packet */
#define rx_packetread(p, off, len, out) \
( (off) + (len) > (p)->wirevec[1].iov_len ? \
- rx_SlowReadPacket(p, off, len, (char*)out) : \
- ((memcpy((char *)(out), (char*)((p)->wirevec[1].iov_base)+(off), len)),0))
+ rx_SlowReadPacket(p, off, len, (char*)(out)) : \
+ ((memcpy((char *)(out), (char*)((p)->wirevec[1].iov_base)+(off), (len))),0))
#define rx_computelen(p,l) { register int i; \
for (l=0, i=1; i < p->niovecs; i++ ) l += p->wirevec[i].iov_len; }
printf("getconn call failed with code %d\n", code);
break;
}
- if (tconn.cid == 0xffffffff) {
+ if (tconn.cid == (afs_int32)0xffffffff) {
printf("Done.\n");
break;
}
u_int size;
u_int nodesize;
+ /* FIXME: this does not look correct: MSVC 6 computes -2 here */
if (maxsize > ((~0) >> 1) - 1)
maxsize = ((~0) >> 1) - 1;
register bool_t stat = TRUE;
register u_int nodesize;
+ /* FIXME: this does not look correct: MSVC 6 computes -1 / elsize here */
i = ((~0) >> 1) / elsize;
if (maxsize > i)
maxsize = i;
int i;
int j;
char c;
- char flag[(1 << 8 * sizeof(char))];
+ char flag[(1 << (8 * sizeof(char)))];
int nflags;
cmdname = argv[0];
struct rx_call *call;
char *name;
{
- int fd = -1;
int error = 0;
struct stat status;
char *reqObject;
}
if ((status.st_mode & S_IFMT) != S_IFDIR) {
printf(" file %s is not a directory \n", reqObject);
- if (fd >= 0)
- close(fd);
error = -1;
}
- if (fd >= 0)
- close(fd);
if (!error)
error = update_SendDirInfo(reqObject, call, &status, name);
}
}
if (error == 0) {
fd = open(dirInfoFile, O_RDONLY, 0);
- if (fd) {
+ if (fd >= 0) {
fstat(fd, &tstatus);
errcode = update_SendFile(fd, call, &tstatus);
if (errcode)
*
*/
#define KSUCCESS 0
-#define KFAILURE -1
+#define KFAILURE (-1)
int
afs_krb_get_lrealm(char *r, int n)
{
- FILE *cnffile, *fopen();
+ FILE *cnffile/*, *fopen()*/;
if (n > 1)
return (KFAILURE); /* Temporary restriction */
} else
circf = 0;
for (;;) {
- if (ep >= &expbuf[ESIZE])
+ if (ep >= &expbuf[ESIZE - 10 /* fudge factor */])
comperr(retoolong);
if ((c = *sp++) == '\0') {
if (bracketp != bracket)
*ep = ep[-1] + 1;
ep++;
cclcnt++;
- if (ep >= &expbuf[ESIZE])
+ if (ep >= &expbuf[ESIZE - 10 /* fudge factor */])
comperr(retoolong);
}
}
*ep++ = c;
cclcnt++;
- if (ep >= &expbuf[ESIZE])
+ if (ep >= &expbuf[ESIZE - 10 /* fudge factor */])
comperr(retoolong);
} while ((c = *sp++) != ']');
lastep[1] = cclcnt;
"ListAttributesU",
"LinkedListU",
"RegisterAddr",
- "GetAddrsU" "ListAttributesN2"
+ "GetAddrsU",
+ "ListAttributesN2"
};
struct Vlent {
("Volumes not found in main hash tables in vldb will be fixed...\n");
memset(&updateentry, 0, sizeof(updateentry));
for (index = 0; 1; index = next_index) {
+ /* FIXME: n2 is never changed for some reason */
int n1 = 0, n2 = 0, n3 = 0, n4 = 0;
memset(&entry, 0, sizeof(entry));
code =
if (singleVolumeNumber) {
h.ih_vid = singleVolumeNumber;
- if (nt_HandleToVolDir(name, &h) < 0)
+ if (!nt_HandleToVolDir(name, &h))
return -1;
ninodes =
nt_ListAFSSubDirs(&h, writeFun, fp, judgeFun, singleVolumeNumber);