viced: Improve CallPreamble error messages
authorAndrew Deason <adeason@sinenomine.net>
Sat, 23 Feb 2013 04:46:12 +0000 (22:46 -0600)
committerDerrick Brashear <shadow@your-file-system.com>
Thu, 7 Mar 2013 12:23:29 +0000 (04:23 -0800)
These messages are not very useful right now. At least try to say what
host we sent an error to, so we know which host may be experiencing
some troubles as a result.

Change-Id: I8b41b46511ebd4760d5021ea2fe2011842450998
Reviewed-on: http://gerrit.openafs.org/9381
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/viced/afsfileprocs.c

index 6b72bf3..62652b3 100644 (file)
@@ -343,7 +343,10 @@ CallPreamble(struct rx_call *acall, int activecall,
   retry:
     tclient = h_FindClient_r(*tconn);
     if (!tclient) {
-       ViceLog(0, ("CallPreamble: Couldn't get client.\n"));
+       ViceLog(0, ("CallPreamble: Couldn't get client struct for host "
+                   "%s:%d, sending busy signal\n",
+                   afs_inet_ntoa_r(rx_HostOf(rx_PeerOf(*tconn)), hoststr),
+                   (int)ntohs(rx_PortOf(rx_PeerOf(*tconn)))));
        H_UNLOCK;
        return VBUSY;
     }
@@ -352,7 +355,10 @@ CallPreamble(struct rx_call *acall, int activecall,
        if (!retry_flag) {
            h_ReleaseClient_r(tclient);
            h_Release_r(thost);
-           ViceLog(0, ("CallPreamble: Couldn't get CPS. Fail\n"));
+           ViceLog(0, ("CallPreamble: Couldn't get CPS for client from host "
+                       "%s:%d, failing request\n",
+                       afs_inet_ntoa_r(thost->host, hoststr),
+                       (int)ntohs(thost->port)));
            H_UNLOCK;
            return -1001;
        }
@@ -380,7 +386,10 @@ CallPreamble(struct rx_call *acall, int activecall,
            h_ReleaseClient_r(tclient);
            h_Release_r(thost);
            H_UNLOCK;
-           ViceLog(0, ("CallPreamble: couldn't reconnect to ptserver\n"));
+           ViceLog(0, ("CallPreamble: couldn't reconnect to ptserver while "
+                       "handling request for %s:%d\n",
+                       afs_inet_ntoa_r(thost->host, hoststr),
+                       (int)ntohs(thost->port)));
            return -1001;
        }