Print "waiting for job termination" at most once.
authorKarl Ramm <kcr@1ts.org>
Sun, 4 Dec 2011 18:56:29 +0000 (13:56 -0500)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Fri, 9 Dec 2011 04:30:22 +0000 (20:30 -0800)
This message is useless, annoying, and is the UI equivalent of littering... but
it does explain why your backup command is just sitting there.

Change-Id: Ied49d0bf9f81b0e10804133c6f05814321d80438
Reviewed-on: http://gerrit.openafs.org/6223
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>

src/bucoord/commands.c

index 4521700..46e8dd6 100644 (file)
@@ -914,11 +914,10 @@ bc_WaitForNoJobs(void)
 {
     int i;
     int usefulJobRunning = 1;
+    int printWaiting = 1;
 
     extern dlqlinkT statusHead;
 
-    afs_com_err(whoami, 0, "waiting for job termination");
-
     while (usefulJobRunning) {
        usefulJobRunning = (dlqEmpty(&statusHead) ? 0 : 1);
        if (dispatchLock.excl_locked)
@@ -929,8 +928,13 @@ bc_WaitForNoJobs(void)
        }
 
        /* Wait 5 seconds and check again */
-       if (usefulJobRunning)
+       if (usefulJobRunning) {
+            if (printWaiting) {
+                afs_com_err(whoami, 0, "waiting for job termination");
+                printWaiting = 0;
+            }
            IOMGR_Sleep(5);
+        }
     }
     return (lastTaskCode);
 }