viced: disable hot threads

Turn off the rx hot threads feature in the file server.  This feature
was an old optimization intended to reduce context switching, however
generally makes performance worse on modern hardware.

Performance improvements from disabling hot threads was identified by
Simon Wilkinson (YFS) at the European AFS and Kerberos Conference (EAKC)
2014 at CERN.

Change-Id: Id3053a61ebdb2d49d2bf36ebe07a35cc07b5d65c
Reviewed-on: http://gerrit.openafs.org/10957
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: D Brashear <shadow@your-file-system.com>

diff --git a/src/viced/viced.c b/src/viced/viced.c
index b2f3f04..bab39f9 100644 (file)
--- a/src/viced/viced.c
+++ b/src/viced/viced.c
@@ -2055,13 +2055,6 @@ main(int argc, char *argv[])
     rx_SetMinProcs(tservice, 2);
     rx_SetMaxProcs(tservice, 4);
 
-    /*
-     * Enable RX hot threads, which allows the listener thread to trade
-     * places with an idle thread and moves the context switch from listener
-     * to worker out of the critical path.
-     */
-    rx_EnableHotThread();
-
     /* Some rx debugging */
     if (rxlog || eventlog) {
        debugFile = afs_fopen("rx_dbg", "w");