ubik-uninitialized-var-20081018

LICENSE MIT

'pass' must be initialized.  do so.

diff --git a/src/ubik/recovery.c b/src/ubik/recovery.c
index 9b76e0d..ae3a7ee 100644 (file)
--- a/src/ubik/recovery.c
+++ b/src/ubik/recovery.c
@@ -605,6 +605,7 @@ urecovery_Interact(void *dummy)
            }
 #endif
 
+           pass = 0;
            while (length > 0) {
                tlen = (length > sizeof(tbuffer) ? sizeof(tbuffer) : length);
 #ifndef AFS_PTHREAD_ENV

diff --git a/src/ubik/remote.c b/src/ubik/remote.c
index 2ed2a29..c30bb0c 100644 (file)
--- a/src/ubik/remote.c
+++ b/src/ubik/remote.c
@@ -560,7 +560,6 @@ SDISK_SendFile(rxcall, file, length, avers)
        close(fd);
        goto failed;
     }
-#else
     pass = 0;
 #endif
     memcpy(&ubik_dbase->version, &tversion, sizeof(struct ubik_version));