butc: Remove dead assignment
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 24 Feb 2013 10:45:41 +0000 (10:45 +0000)
committerDerrick Brashear <shadow@your-file-system.com>
Mon, 25 Feb 2013 16:38:11 +0000 (08:38 -0800)
We never use the value of mvFlag once the string has been restored,
so don't bother reseting it.

Caught by clang-analyzer

Change-Id: I12db6957c9b8ec3bb9c43f10d9e9754d4afa3ed7
Reviewed-on: http://gerrit.openafs.org/9248
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/butc/tcmain.c

index 885d44c..f5f1e94 100644 (file)
@@ -288,10 +288,9 @@ stringNowReplace(char *logFile, char *deviceName)
        *pos = '_';
     strcat(logFile, deviceName);
     /* now put back deviceName to the way it was */
-    if (mvFlag) {
-       mvFlag = 0;
+    if (mvFlag)
        deviceName -= devPrefLen;
-    }
+
     strcpy(deviceName, storeDevice);
 
     return (0);