volserver: Exit on arg parsing failure
authorAndrew Deason <adeason@sinenomine.net>
Wed, 30 Oct 2013 02:22:02 +0000 (21:22 -0500)
committerDerrick Brashear <shadow@your-file-system.com>
Thu, 7 Nov 2013 12:19:26 +0000 (04:19 -0800)
If ParseArgs returns an error, argument parsing failed. Currently we
keep going anyway, ignoring the error. Exit instead.

Change-Id: I2f9e4e06d6c3fab8e29921bdb0ea30d714c794b1
Reviewed-on: http://gerrit.openafs.org/10422
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/volser/volmain.c

index 367a8a8..3b7dfc6 100644 (file)
@@ -445,7 +445,9 @@ main(int argc, char **argv)
     configDir = strdup(AFSDIR_SERVER_ETC_DIRPATH);
     logFile = strdup(AFSDIR_SERVER_VOLSERLOG_FILEPATH);
 
-    ParseArgs(argc, argv);
+    if (ParseArgs(argc, argv)) {
+       exit(1);
+    }
 
     if (auditFileName) {
        osi_audit_file(auditFileName);