include-errno-dont-declare-it-20030111

include errno.h instead of extern int errno ourselves

diff --git a/src/afsmonitor/afsmonitor.c b/src/afsmonitor/afsmonitor.c
index 6470952..8c3c8e3 100644 (file)
--- a/src/afsmonitor/afsmonitor.c
+++ b/src/afsmonitor/afsmonitor.c
@@ -209,7 +209,7 @@ struct cm_Display_Data *prev_cmData = (struct cm_Display_Data *)0;
 /* EXTERN DEFINITIONS */
 
 extern struct hostent *hostutil_GetHostByName(); 
-extern int errno;
+
 
 
 /* routines from afsmon-output.c */

diff --git a/src/butm/butm_test.c b/src/butm/butm_test.c
index 04b5544..86a0599 100644 (file)
--- a/src/butm/butm_test.c
+++ b/src/butm/butm_test.c
@@ -12,6 +12,7 @@
 
 RCSID("$Header$");
 
+#include <errno.h>
 #include <sys/types.h>
 #include <sys/file.h>
 #include <sys/stat.h>
@@ -23,7 +24,7 @@ RCSID("$Header$");
 #include <afs/butm.h>
 #include "AFS_component_version_number.c"
 
-extern int errno;
+
 
 static char *whoami = "TEST FAIL";
 

diff --git a/src/export/cfgafs.c b/src/export/cfgafs.c
index b48afd7..b7357fa 100644 (file)
--- a/src/export/cfgafs.c
+++ b/src/export/cfgafs.c
@@ -15,6 +15,7 @@
 
 RCSID("$Header$");
 
+#include <errno.h>
 #include <stdio.h>
 #include <fcntl.h>
 #include <sys/types.h>
@@ -26,7 +27,7 @@ RCSID("$Header$");
 #include <signal.h>
 
 extern char    *malloc(), *optarg;
-extern int     errno;
+
 extern int     sysconfig(int cmd, void *arg, int len);
 
 #include "AFS_component_version_number.c"

diff --git a/src/export/cfgexport.c b/src/export/cfgexport.c
index 059f35b..d13503d 100644 (file)
--- a/src/export/cfgexport.c
+++ b/src/export/cfgexport.c
@@ -15,6 +15,7 @@
 
 RCSID("$Header$");
 
+#include <errno.h>
 #include <stdio.h>
 #include <fcntl.h>
 #include <sys/types.h>
@@ -29,7 +30,6 @@ RCSID("$Header$");
 #include "sym.h"
 
 extern char    *malloc(), *optarg;
-extern int     errno;
 extern int     sysconfig(int cmd, void *arg, int len);
 
 int debug = 0 ;

diff --git a/src/gtx/curseswindows.c b/src/gtx/curseswindows.c
index f37a6c8..8b8d96e 100644 (file)
--- a/src/gtx/curseswindows.c
+++ b/src/gtx/curseswindows.c
@@ -50,7 +50,7 @@ RCSID("$Header$");
 #include "gtxobjects.h"
 #include "gtxframe.h"
 
-extern int errno;               /* everybody else puts it in errno.h */
+
 
 int curses_debug;                          /*Is debugging turned on?*/
 static char mn[] = "gator_curseswindows";   /*Module name*/

diff --git a/src/gtx/dumbwindows.c b/src/gtx/dumbwindows.c
index 56c37f0..6a5ae99 100644 (file)
--- a/src/gtx/dumbwindows.c
+++ b/src/gtx/dumbwindows.c
@@ -20,10 +20,8 @@ RCSID("$Header$");
 
 #include "gtxdumbwin.h"                        /*Interface definition*/
 #include <stdio.h>                     /*Standard I/O package*/
+#include <errno.h>
 
-#if    !defined(NeXT)
-extern int errno;                      /*System error number*/
-#endif /* NeXT */
 int dumb_debug;                                /*Is debugging turned on?*/
 static char mn[] = "gator_dumbwindows";        /*Module name*/
 

diff --git a/src/gtx/object_test.c b/src/gtx/object_test.c
index 207f43c..66d524f 100644 (file)
--- a/src/gtx/object_test.c
+++ b/src/gtx/object_test.c
@@ -23,10 +23,10 @@ RCSID("$Header$");
 #include "gtxcurseswin.h"    /*Gator curses window package*/
 #include "gtxdumbwin.h"      /*Gator dumb terminal window package*/
 #include "gtxX11win.h"       /*Gator X11 window package*/
+#include <errno.h>
 #include <stdio.h>                  /*Standard I/O stuff*/
 #include <cmd.h>                   /*Command interpretation library*/
 
-extern int errno;
 
 /*
  * Command line parameter indicies.

diff --git a/src/gtx/screen_test.c b/src/gtx/screen_test.c
index 555ebf6..a914be3 100644 (file)
--- a/src/gtx/screen_test.c
+++ b/src/gtx/screen_test.c
@@ -21,8 +21,8 @@ RCSID("$Header$");
 #include "gtxdumbwin.h"            /*Dumb terminal window interface*/
 #include "gtxX11win.h"     /*X11 window interface*/
 #include <cmd.h>                   /*Command interpretation library*/
+#include <errno.h>
 
-extern int errno;
 
 /*
  * Command line parameter indicies.

diff --git a/src/package/fileops.c b/src/package/fileops.c
index d71d370..491c774 100644 (file)
--- a/src/package/fileops.c
+++ b/src/package/fileops.c
@@ -27,6 +27,13 @@
 #include <sys/stat.h>
 #include <sys/file.h>
 #include <dirent.h>
+#ifdef HAVE_STRING_H
+#include <string.h>
+#else
+#ifdef HAVE_STRINGS_H
+#include <strings.h>
+#endif
+#endif
 #include <errno.h>
 #ifdef AFS_SUN5_ENV
 #include <sys/fcntl.h>
@@ -34,8 +41,6 @@
 #include "globals.h"
 #include "package.h"
 
-extern char *strcpy();
-extern int errno;
 
 int mv(from,to)
 register char *from;

diff --git a/src/package/messages.c b/src/package/messages.c
index 14f0973..9664b28 100644 (file)
--- a/src/package/messages.c
+++ b/src/package/messages.c
@@ -29,6 +29,8 @@
 #endif
 #include <varargs.h>
 #include "package.h"
+#include <errno.h>
+
 
 static char *putnum(dp, n, b)
     register char *dp;
@@ -98,7 +100,6 @@ static char *putformat(dp, fp, ap)
          }
        case 'm':
          {
-           extern int errno;
            extern int sys_nerr;
            extern char *sys_errlist[];
 

diff --git a/src/pinstall/install.c b/src/pinstall/install.c
index aeece2d..c7408f5 100644 (file)
--- a/src/pinstall/install.c
+++ b/src/pinstall/install.c
@@ -90,7 +90,6 @@ RCSID("$Header$");
 static struct stat istat, ostat;
 static int stripcalled = 0;
 
-extern int errno;
 #if !defined(AFS_DARWIN60_ENV)
 extern int sys_nerr;
 #endif

diff --git a/src/ptserver/db_verify.c b/src/ptserver/db_verify.c
index 56df576..9081475 100644 (file)
--- a/src/ptserver/db_verify.c
+++ b/src/ptserver/db_verify.c
@@ -7,7 +7,6 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
-extern int errno;
 
 #include <afsconfig.h>
 #include <afs/param.h>

diff --git a/src/ptserver/pt_util.c b/src/ptserver/pt_util.c
index f57d6dd..a231974 100644 (file)
--- a/src/ptserver/pt_util.c
+++ b/src/ptserver/pt_util.c
@@ -24,6 +24,7 @@
 
 RCSID("$Header$");
 
+#include <errno.h>
 #include <lock.h>
 #include <netinet/in.h>
 #define UBIK_INTERNALS
@@ -40,7 +41,6 @@ RCSID("$Header$");
 
 extern char *optarg;
 extern int optind;
-extern int errno;
 
 int display_entry();
 void add_group();

diff --git a/src/scout/scout.c b/src/scout/scout.c
index 5a00923..6636c42 100644 (file)
--- a/src/scout/scout.c
+++ b/src/scout/scout.c
@@ -39,8 +39,9 @@ RCSID("$Header$");
 #include <stdio.h>             /*Standard I/O stuff*/
 #include <cmd.h>               /*Command interpretation library*/
 #include <fsprobe.h>           /*Interface for fsprobe module*/
+#include <errno.h>
+
 
-extern int errno;
 extern struct hostent *hostutil_GetHostByName();
 extern int gtx_InputServer();
 extern int gethostname();

diff --git a/src/sys/afssyscalls.c b/src/sys/afssyscalls.c
index 7b008cb..76a838b 100644 (file)
--- a/src/sys/afssyscalls.c
+++ b/src/sys/afssyscalls.c
@@ -27,6 +27,7 @@ RCSID("$Header$");
 #ifdef AFS_SGI_XFS_IOPS_ENV
 #include "xfsattrs.h"
 #endif
+#include <errno.h>
 #include "afssyscalls.h"
 
 #ifdef AFS_DEBUG_IOPS
@@ -223,8 +224,7 @@ struct iparam {
 
 int icreate(int dev, int near_inode, int param1, int param2, int param3, int param4)
 {
-    extern int errno;
-    int errcode;
+  int errcode;
     struct iparam iparams;
 
     iparams.param1 = param1;
@@ -239,7 +239,6 @@ int icreate(int dev, int near_inode, int param1, int param2, int param3, int par
 
 int iopen(int dev, int inode, int usrmod)
 {
-    extern int errno;
     int errcode;
 
     errcode = syscall(AFS_SYSCALL, AFSCALL_IOPEN, dev, inode, usrmod);
@@ -249,7 +248,6 @@ int iopen(int dev, int inode, int usrmod)
 
 int iinc(int dev, int inode, int inode_p1)
 {
-    extern int errno;
     int errcode;
 
     errcode = syscall(AFS_SYSCALL, AFSCALL_IINC, dev, inode, inode_p1);
@@ -259,7 +257,6 @@ int iinc(int dev, int inode, int inode_p1)
 
 int idec(int dev, int inode, int inode_p1)
 {
-    extern int errno;
     int errcode;
 
     errcode = syscall(AFS_SYSCALL, AFSCALL_IDEC, dev, inode, inode_p1);
@@ -270,7 +267,6 @@ int idec(int dev, int inode, int inode_p1)
 #ifdef notdef
 int iread(int dev, int inode, int inode_p1, unsigned int offset, char *cbuf, unsigned int count)
 {
-    extern int errno;
     int errcode;
     struct iparam iparams;
 
@@ -285,7 +281,6 @@ int iread(int dev, int inode, int inode_p1, unsigned int offset, char *cbuf, uns
 
 iwrite(int dev, int inode, int inode_p1, unsigned int offset, char *cbuf, unsigned int count)
 {
-    extern int errno;
     int errcode;
     struct iparam iparams;
 
@@ -303,7 +298,6 @@ iwrite(int dev, int inode, int inode_p1, unsigned int offset, char *cbuf, unsign
 
 int lsetpag(void)
 {
-    extern int errno;
     int errcode;
 
     errcode = syscall(AFS_SYSCALL, AFSCALL_SETPAG);
@@ -312,7 +306,6 @@ int lsetpag(void)
 
 int lpioctl(char *path, int cmd, char *cmarg, int follow)
 {
-    extern int errno;
     int errcode;
 
     errcode = syscall(AFS_SYSCALL, AFSCALL_PIOCTL, path, cmd, cmarg, follow);

diff --git a/src/sys/rmtsysd.c b/src/sys/rmtsysd.c
index ea9739f..a6a0e13 100644 (file)
--- a/src/sys/rmtsysd.c
+++ b/src/sys/rmtsysd.c
@@ -28,11 +28,12 @@ RCSID("$Header$");
 #include <netinet/in.h>
 #include <sys/stat.h>
 #include <sys/file.h>
+#include <errno.h>
 #include <stdio.h>
 #include <rx/xdr.h>
 #include "rmtsys.h"
 
-extern int errno;   /* We ship this over the net if needed */
+
 extern RMTSYS_ExecuteRequest();
 
 #define N_SECURITY_OBJECTS 1   /* No real security yet */

diff --git a/src/sys/rmtsyss.c b/src/sys/rmtsyss.c
index 65e1815..ff4386b 100644 (file)
--- a/src/sys/rmtsyss.c
+++ b/src/sys/rmtsyss.c
@@ -25,6 +25,7 @@ RCSID("$Header$");
 #include <sys/stat.h>
 #include <sys/file.h>
 #include <stdio.h>
+#include <errno.h>
 #include <rx/xdr.h>
 #include <errno.h>
 #include <signal.h>
@@ -34,7 +35,6 @@ RCSID("$Header$");
 /*#include <afs/cellconfig.h>*/
 #include "rmtsys.h"
 
-extern int errno;   /* We ship this over the net if needed */
 extern RMTSYS_ExecuteRequest();
 
 #define        NFS_EXPORTER        1   /* To probably handle more later */

diff --git a/src/uss/uss_fs.c b/src/uss/uss_fs.c
index 679ccce..5462c3d 100644 (file)
--- a/src/uss/uss_fs.c
+++ b/src/uss/uss_fs.c
@@ -22,9 +22,8 @@ RCSID("$Header$");
 
 #include "uss_fs.h"            /*Interface to this module*/
 #include <sys/types.h>
-#include <sys/errno.h>
+#include <errno.h>
 #include <sys/socket.h>
-#include <sys/errno.h>
 #ifdef AFS_SUN5_ENV
 #include <sys/ioccom.h>
 #endif
@@ -40,7 +39,6 @@ RCSID("$Header$");
 
 #include <afs/venus.h>
 #include "uss_common.h"
-extern int errno;
 
 
 /*

diff --git a/src/uss/uss_kauth.c b/src/uss/uss_kauth.c
index 05062a6..2f29bfe 100644 (file)
--- a/src/uss/uss_kauth.c
+++ b/src/uss/uss_kauth.c
@@ -37,8 +37,6 @@ RCSID("$Header$");
 #include <afs/kautils.h>       /*MAXKTCREALMLEN*/
 #include <afs/kaport.h>         /* pack_long */
 
-extern int errno;
-
 #define uss_kauth_MAX_SIZE     2048
 
 #undef USS_KAUTH_DB

diff --git a/src/uss/uss_procs.c b/src/uss/uss_procs.c
index 71eb5ea..60695c0 100644 (file)
--- a/src/uss/uss_procs.c
+++ b/src/uss/uss_procs.c
@@ -42,7 +42,6 @@ RCSID("$Header$");
 
 #include <afs/kautils.h>       /*MAXKTCREALMLEN*/
 
-extern int errno;
 
 #undef USS_PROCS_DB
 #undef USS_PROCS_DB_INSTANCE

diff --git a/src/uss/uss_ptserver.c b/src/uss/uss_ptserver.c
index 530b115..1747f0d 100644 (file)
--- a/src/uss/uss_ptserver.c
+++ b/src/uss/uss_ptserver.c
@@ -25,7 +25,6 @@ RCSID("$Header$");
 #include <afs/pterror.h>       /*Protection Server error codes*/
 #include <afs/com_err.h>       /*Error code xlation*/
 
-extern int errno;
 
 #undef USS_PTSERVER_DB
 

diff --git a/src/uss/uss_vol.c b/src/uss/uss_vol.c
index d9964e9..e033e73 100644 (file)
--- a/src/uss/uss_vol.c
+++ b/src/uss/uss_vol.c
@@ -27,7 +27,7 @@ RCSID("$Header$");
 #include <sys/stat.h>
 #include <pwd.h>
 #include <netdb.h>
-#include <sys/errno.h>
+#include <errno.h>
 
 #ifdef HAVE_STRING_H
 #include <string.h>
@@ -47,7 +47,6 @@ RCSID("$Header$");
 #include <afs/keys.h>
 #include <ubik.h>
 
-extern int errno;
 extern struct rx_connection *UV_Bind();
 extern int line;
 extern int VL_GetEntryByID();

diff --git a/src/venus/fs.c b/src/venus/fs.c
index 1953569..18ac2a1 100644 (file)
--- a/src/venus/fs.c
+++ b/src/venus/fs.c
@@ -73,7 +73,7 @@ static int RxStatProcCmd(), RxStatPeerCmd();
 extern char *hostutil_GetNameByINet();
 extern struct hostent *hostutil_GetHostByName();
 
-extern int errno;
+
 extern struct cmd_syndesc *cmd_CreateSyntax();
 static char pn[] = "fs";
 static int rxInitDone = 0;

diff --git a/src/venus/kdump.c b/src/venus/kdump.c
index 4dfaeef..c7e9b29 100644 (file)
--- a/src/venus/kdump.c
+++ b/src/venus/kdump.c
@@ -13,6 +13,7 @@
 RCSID("$Header$");
 
 #include <stdio.h>
+#include <errno.h>
 #include <stdlib.h>    /* for malloc() */
 
 #ifdef AFS_LINUX24_ENV
@@ -518,7 +519,6 @@ void print_cmstats();
 #ifndef AFS_KDUMP_LIB
 extern struct cmd_syndesc *cmd_CreateSyntax();
 #endif
-extern int errno;
 int opencore();
 
 #if    defined(AFS_HPUX_ENV) && defined(__LP64__)

diff --git a/src/venus/twiddle.c b/src/venus/twiddle.c
index 6e5b6c2..4d580ef 100644 (file)
--- a/src/venus/twiddle.c
+++ b/src/venus/twiddle.c
@@ -30,7 +30,8 @@ RCSID("$Header$");
 #undef VICE
 #include "afs/prs_fs.h"
 #include <afs/afsint.h>
-#include <afs/auth.h>
+#include <afs/auth.h>>
+#include <errno.h
 #include <afs/cellconfig.h>
 #include <afs/cmd.h>
 #include <strings.h>
@@ -44,7 +45,7 @@ static char space[MAXSIZE];
 static char tspace[1024];
 static struct ubik_client *uclient;
 
-extern int errno;
+
 extern struct cmd_syndesc *cmd_CreateSyntax();
 static char pn[] = "fs";
 static int rxInitDone = 0;

diff --git a/src/vlserver/cnvldb.c b/src/vlserver/cnvldb.c
index 4ee584d..ede8d45 100644 (file)
--- a/src/vlserver/cnvldb.c
+++ b/src/vlserver/cnvldb.c
@@ -38,7 +38,7 @@ RCSID("$Header$");
 #define MAXSIZE 2048 /* most I'll get back from PIOCTL */
 #define        BADSERVERID     255     /* XXX */
 
-extern int errno;
+
 extern struct cmd_syndesc *cmd_CreateSyntax();
 static char pn[] = "cnvldb";
 static char tempname[] = "XXnewvldb";

diff --git a/src/vlserver/sascnvldb.c b/src/vlserver/sascnvldb.c
index 08a3667..c6cf2d6 100644 (file)
--- a/src/vlserver/sascnvldb.c
+++ b/src/vlserver/sascnvldb.c
@@ -35,7 +35,7 @@ RCSID("$Header$");
 
 #define MAXSIZE 2048 /* most I'll get back from PIOCTL */
 
-extern int errno;
+
 extern struct cmd_syndesc *cmd_CreateSyntax();
 static char pn[] = "cnvldb";
 static char tempname[] = "XXnewvldb";

diff --git a/src/vol/fs_conv_411.c b/src/vol/fs_conv_411.c
index 14c0d49..8faa496 100644 (file)
--- a/src/vol/fs_conv_411.c
+++ b/src/vol/fs_conv_411.c
@@ -84,7 +84,6 @@ RCSID("$Header$");
 int icount=0, iarraysize=0, *iarray;
 
 char *rawname(),  *unrawname(), *vol_DevName(), *blockcheck();
-extern int errno;
 #define ROOTINODE      2       
 int force = 0,  verbose = 0,  unconv = 0;
 

diff --git a/src/vol/partition.c b/src/vol/partition.c
index 6edd46b..18b790a 100644 (file)
--- a/src/vol/partition.c
+++ b/src/vol/partition.c
@@ -59,7 +59,7 @@ RCSID("$Header$");
 #endif
 #endif /* AFS_VFSINCL_ENV */
 #endif /* AFS_OSF_ENV */
-#include <sys/errno.h>
+#include <errno.h>
 #include <sys/stat.h>
 #include <stdio.h>
 #include <sys/file.h>
@@ -840,7 +840,6 @@ void VSetPartitionDiskUsage_r(register struct DiskPartition *dp)
 #else
 void VSetPartitionDiskUsage_r(register struct DiskPartition *dp)
 {
-    extern int errno;
     int fd, totalblks, free, used, availblks, bsize, code;
     int reserved;
 #if AFS_HAVE_STATVFS