Make UAFS builds stop the main build
authorSimon Wilkinson <sxw@inf.ed.ac.uk>
Mon, 13 Jul 2009 22:00:44 +0000 (23:00 +0100)
committerDerrick Brashear <shadow@dementia.org>
Thu, 16 Jul 2009 15:04:16 +0000 (09:04 -0600)
The sub-make invocations in libuafs ignored the return code of the make,
which allowed the libuafs build to appear to succeed even if files had
failed to build. Fix this.

Reviewed-on: http://gerrit.openafs.org/74
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

src/libuafs/Makefile.common.in

index d80127a..e918785 100644 (file)
@@ -1454,23 +1454,23 @@ setup_nsafs: AFSWEB setup_common
        ln -s ../Makefile.common AFSWEB/Makefile.common
 
 UAFS/$(LIBUAFS): setup_uafs
-       cd UAFS; \
-       $(MAKE) $(LIBUAFS) DESTDIR=${DESTDIR} LIBJUAFS_FLAGS=; \
+       cd UAFS && \
+       $(MAKE) $(LIBUAFS) DESTDIR=${DESTDIR} LIBJUAFS_FLAGS=&& \
        $(RANLIB) $(LIBUAFS)
 
 JUAFS/$(LIBJUAFS): setup_juafs
-       cd JUAFS; \
-       $(MAKE) $(LIBJUAFS) DESTDIR=${DESTDIR} LIBJUAFS_FLAGS=-DAFS_WEB_ENHANCEMENTS; \
+       cd JUAFS && \
+       $(MAKE) $(LIBJUAFS) DESTDIR=${DESTDIR} LIBJUAFS_FLAGS=-DAFS_WEB_ENHANCEMENTS && \
        $(RANLIB) $(LIBJUAFS)
 
 AFSWEB/$(LIBAFSWEB): setup_nsafs
-       cd AFSWEB; \
-       $(MAKE) $(LIBAFSWEB) DESTDIR=${DESTDIR}; \
+       cd AFSWEB && \
+       $(MAKE) $(LIBAFSWEB) DESTDIR=${DESTDIR} && \
        $(RANLIB) $(LIBAFSWEB)
 
 AFSWEB/$(LIBAFSWEBKRB): setup_nsafs
-       cd AFSWEB; \
-       $(MAKE) $(LIBAFSWEBKRB) DESTDIR=${DESTDIR}; \
+       cd AFSWEB && \
+       $(MAKE) $(LIBAFSWEBKRB) DESTDIR=${DESTDIR} && \
        $(RANLIB) $(LIBAFSWEBKRB)
 
 include ${TOP_OBJDIR}/src/config/Makefile.version