ubik: Don't record result of select()
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 19 Feb 2013 16:13:34 +0000 (16:13 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Sun, 24 Feb 2013 19:08:47 +0000 (11:08 -0800)
We never do anything with the return value from select(), so don't
bother storing it into code.

Caught by clang-analyzer

Change-Id: I6e0352b74f0e90b62ad32a3ef1a9d0173bf307ee
Reviewed-on: http://gerrit.openafs.org/9181
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

src/ubik/beacon.c

index 91a2b29..a3a48d6 100644 (file)
@@ -421,12 +421,11 @@ ubeacon_Interact(void *dummy)
            tt.tv_sec = temp;
            tt.tv_usec = 0;
 #ifdef AFS_PTHREAD_ENV
-           code = select(0, 0, 0, 0, &tt);
+           select(0, 0, 0, 0, &tt);
 #else
-           code = IOMGR_Select(0, 0, 0, 0, &tt);
+           IOMGR_Select(0, 0, 0, 0, &tt);
 #endif
-       } else
-           code = 0;
+       }
 
        lastWakeupTime = FT_ApproxTime();       /* started a new collection phase */