bosserver: Don't store result when renaming core file
authorSimon Wilkinson <sxw@your-file-system.com>
Thu, 21 Feb 2013 21:57:56 +0000 (21:57 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Sun, 24 Feb 2013 19:31:28 +0000 (11:31 -0800)
The bosserver doesn't do anything if the core file rename fails, so
don't bother storing the result code.

Caught by clang-analyzer

Change-Id: I9b1b7d77404b0fd560c7735646e5afe1fbcc0752
Reviewed-on: http://gerrit.openafs.org/9232
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

src/bozo/bnode.c

index 32d3f2d..6f8f99b 100644 (file)
@@ -151,7 +151,7 @@ SaveCore(struct bnode *abnode, struct bnode_proc
            TimeFields->tm_hour, TimeFields->tm_min, TimeFields->tm_sec);
     strcpy(tbuffer, FileName);
 #endif
-    code = rk_rename(corefile, tbuffer);
+    rk_rename(corefile, tbuffer);
     free(corefile);
 }