salvageserver: segfault in DoSalvageVolume 82/12282/2
authorMark Vitale <mvitale@sinenomine.net>
Wed, 11 May 2016 02:51:38 +0000 (22:51 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Wed, 11 May 2016 03:42:22 +0000 (23:42 -0400)
A typo in the recent logging changes for salvageserver
ad455347bc99d1bd499535995958b5f77c2388ff
caused a bad address to be passed to memset.

Correctly memset the log options as intended.

Change-Id: Ifef46defcc6da56df4e58f8ed9029717a77c0b39
Reviewed-on: https://gerrit.openafs.org/12282
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

src/vol/salvaged.c

index 6e4c87a..f513ce3 100644 (file)
@@ -621,7 +621,7 @@ DoSalvageVolume(struct SalvageQueueNode * node, int slot)
      * another thread may have held the lock when fork was
      * called!
      */
-    memset(&memset, 0, sizeof(logopts));
+    memset(&logopts, 0, sizeof(logopts));
     logopts.lopt_dest = logDest_file;
     logopts.lopt_rotateStyle = logRotate_none;
     if (asprintf(&filename, "%s.%d",