callbacks-later-remove-lhs-cast-20030915

FIXES 2100

lhs cast illegal, some compilers barf, remove it.

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
FIXES 2100

lhs cast illegal, some compilers barf, remove it.
this time commit the correct patch

diff --git a/src/viced/callback.c b/src/viced/callback.c
index f4d8c5a..ed83da2 100644 (file)
--- a/src/viced/callback.c
+++ b/src/viced/callback.c
@@ -1415,13 +1415,16 @@ BreakLaterCallBacks(void)
        for (feip = &HashTable[hash]; fe = itofe(*feip);) {
            if (fe && (fe->status & FE_LATER)
                && (fid.Volume == 0 || fid.Volume == fe->volid)) {
+               /* Ugly, but used to avoid left side casting */
+               struct object *tmpfe;
                ViceLog(125,
                        ("Unchaining for %u:%u:%u\n", fe->vnode, fe->unique,
                         fe->volid));
                fid.Volume = fe->volid;
                *feip = fe->fnext;
                /* Works since volid is deeper than the largest pointer */
-               ((struct object *)fe)->next = (struct object *)myfe;
+               tmpfe = (struct object *)fe;
+               tmpfe->next = (struct object *)myfe;
                myfe = fe;
            } else
                feip = &fe->fnext;