vlserver - Don't overflow buffer with backup pattern
authorDerrick Brashear <shadow@dementia.org>
Wed, 21 Jul 2010 16:06:39 +0000 (12:06 -0400)
committerDerrick Brashear <shadow@dementia.org>
Wed, 21 Jul 2010 18:34:49 +0000 (11:34 -0700)
based on a report from Hans-Werner Paulsen

avoid adding regex anchors to a buffer which is already full
when copying it to a like sized buffer. instead, leave extra space.

Change-Id: I486c51779da285888fe38ed2aa5f30dd2d008a9a
Reviewed-on: http://gerrit.openafs.org/2456
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

src/vlserver/vlprocs.c

index 0bd0c01..4668faf 100644 (file)
@@ -1421,7 +1421,7 @@ SVL_ListAttributesN2(struct rx_call *rxcall,
     int pollcount = 0;
     int namematchRWBK, namematchRO, thismatch;
     int matchtype = 0;
-    char volumename[VL_MAXNAMELEN];
+    char volumename[VL_MAXNAMELEN+2]; /* regex anchors */
     char rxstr[AFS_RXINFO_LEN];
 #ifdef HAVE_POSIX_REGEX
     regex_t re;