libcmd: Don't store values that we don't need

Don't store the results from cmd_CreateSyntax unless we actually
need to use them for something.

Caught by clang-analyzer

Change-Id: I581dcc00a886245a8d117f78c74590111c75e3b0
Reviewed-on: http://gerrit.openafs.org/5077
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

diff --git a/src/cmd/cmd.c b/src/cmd/cmd.c
index d67a816..1ead1ca 100644 (file)
--- a/src/cmd/cmd.c
+++ b/src/cmd/cmd.c
@@ -771,16 +771,17 @@ initSyntax(void)
        ts = cmd_CreateSyntax("apropos", AproposProc, NULL,
                              "search by help text");
        cmd_AddParm(ts, "-topic", CMD_SINGLE, CMD_REQUIRED, "help string");
-       ts = cmd_CreateSyntax("version", VersionProc, NULL,
-                             (char *)CMD_HIDDEN);
-       ts = cmd_CreateSyntax("-version", VersionProc, NULL,
-                             (char *)CMD_HIDDEN);
-       ts = cmd_CreateSyntax("-help", HelpProc, NULL,
-                             (char *)CMD_HIDDEN);
-       ts = cmd_CreateSyntax("--version", VersionProc, NULL,
-                             (char *)CMD_HIDDEN);
-       ts = cmd_CreateSyntax("--help", HelpProc, NULL,
-                             (char *)CMD_HIDDEN);
+
+       cmd_CreateSyntax("version", VersionProc, NULL,
+                        (char *)CMD_HIDDEN);
+       cmd_CreateSyntax("-version", VersionProc, NULL,
+                        (char *)CMD_HIDDEN);
+       cmd_CreateSyntax("-help", HelpProc, NULL,
+                        (char *)CMD_HIDDEN);
+       cmd_CreateSyntax("--version", VersionProc, NULL,
+                        (char *)CMD_HIDDEN);
+       cmd_CreateSyntax("--help", HelpProc, NULL,
+                        (char *)CMD_HIDDEN);
     }
 }