rxdebug: Remove rxdumptrace.c 48/14748/2
authorAndrew Deason <adeason@sinenomine.net>
Sun, 8 Aug 2021 20:13:14 +0000 (15:13 -0500)
committerBenjamin Kaduk <kaduk@mit.edu>
Thu, 26 Aug 2021 16:55:55 +0000 (12:55 -0400)
Ever since it was introduced in commit 8bc58a3d
(macos-10-6-support-20090216), rxdumptrace.c appears to have been
unused. While we do build a binary called rxdumptrace, we build it
from src/rx/rx_trace.c, not from rxdumptrace.c (which appears to be a
copy of the relevant portions of rx_trace.c).

Also remove rxdumptrace from src/rx/.gitignore, since the binary is
built in src/rxdebug/, not in src/rx/. While we're here, remove the
other entries in src/rx/.gitignore (rxperf and rxdebug), since those
are also built in different directories.

Change-Id: Ide816979168dcf70358f39db035ce16ef6c1dd17
Reviewed-on: https://gerrit.openafs.org/14748
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

src/rx/.gitignore [deleted file]
src/rxdebug/rxdumptrace.c [deleted file]

diff --git a/src/rx/.gitignore b/src/rx/.gitignore
deleted file mode 100644 (file)
index e2d9bf7..0000000
+++ /dev/null
@@ -1,7 +0,0 @@
-# After changing this file, please run
-#     git ls-files -i --exclude-standard
-# to check that you haven't inadvertently ignored any tracked files.
-
-/rxdebug
-/rxdumptrace
-/rxperf
diff --git a/src/rxdebug/rxdumptrace.c b/src/rxdebug/rxdumptrace.c
deleted file mode 100644 (file)
index 69f95b2..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
-/*
- * Copyright 2000, International Business Machines Corporation and others.
- * All Rights Reserved.
- *
- * This software has been released under the terms of the IBM Public
- * License.  For details, see the LICENSE file in the top-level source
- * directory or online at http://www.openafs.org/dl/license10.html
- */
-
-#include <afsconfig.h>
-#include <afs/param.h>
-
-
-#ifdef RXDEBUG
-
-#include <roken.h>
-
-#include <afs/afsutil.h>
-
-#include "rx.h"
-#include "rx_globals.h"
-#include "rx_trace.h"
-
-extern char *rxi_tracename;
-extern int rxi_logfd;
-
-struct rx_trace {
-    afs_uint32 cid;
-    unsigned short call;
-    unsigned short qlen;
-    afs_uint32 now;
-    afs_uint32 waittime;
-    afs_uint32 servicetime;
-    afs_uint32 event;
-};
-
-int
-main(int argc, char **argv)
-{
-    struct rx_trace ip;
-    int err = 0;
-
-    setlinebuf(stdout);
-    argv++;
-    argc--;
-    while (argc && **argv == '-') {
-       if (strcmp(*argv, "-trace") == 0) {
-           strcpy(rxi_tracename, *(++argv));
-           argc--;
-       } else {
-           err++;
-           break;
-       }
-       argv++, argc--;
-    }
-    if (err || argc != 0) {
-       printf("usage: dumptrace [-trace pathname]");
-       exit(1);
-    }
-
-    rxi_logfd = open(rxi_tracename, O_RDONLY);
-    if (rxi_logfd < 0) {
-       perror("");
-       exit(errno);
-    }
-
-    while (read(rxi_logfd, &ip, sizeof(struct rx_trace))) {
-       printf("%9u ", ip.now);
-       switch (ip.event) {
-       case RX_CALL_END:
-           putchar('E');
-           break;
-       case RX_CALL_START:
-           putchar('S');
-           break;
-       case RX_CALL_ARRIVAL:
-           putchar('A');
-           break;
-       case RX_TRACE_DROP:
-           putchar('D');
-           break;
-       default:
-           putchar('U');
-           break;
-       }
-       printf(" %3u %7u %7u      %x.%x\n", ip.qlen, ip.servicetime,
-              ip.waittime, ip.cid, ip.call);
-    }
-    return 0;
-}
-
-#endif