rxkad: Remove redundant checkCksum initialisation
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 19 Feb 2013 16:31:28 +0000 (16:31 +0000)
committerJeffrey Altman <jaltman@your-file-system.com>
Sun, 24 Feb 2013 19:10:07 +0000 (11:10 -0800)
checkCksum is assigned to by both sides of the if() expression, so
there's no need to initialise it to 0.

Caught by clang-analyzer

Change-Id: Id0e286943e11b6948231577085cdb0ce96bb0b97
Reviewed-on: http://gerrit.openafs.org/9183
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>

src/rxkad/rxkad_common.c

index 484909d..3133d29 100644 (file)
@@ -430,7 +430,6 @@ rxkad_CheckPacket(struct rx_securityClass *aobj, struct rx_call *acall,
 
     tconn = rx_ConnectionOf(acall);
     len = rx_GetDataSize(apacket);
-    checkCksum = 0;            /* init */
     if (rx_IsServerConn(tconn)) {
        struct rxkad_sconn *sconn;
        sconn = rx_GetSecurityData(tconn);