From: Ben Kaduk Date: Sat, 23 Jul 2011 18:58:54 +0000 (-0400) Subject: FBSD: cast lkmnosys appropriately X-Git-Tag: openafs-devel-1_7_1~233 X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=46b897bbaff9e7ea8ff88766ce2b3e047feeee6b FBSD: cast lkmnosys appropriately lkmnosys is a function, and as such has its own prototype which includes a named struct specific to it (struct nosys_args). When comparing its address to an entry in the syscall table, we must cast it to a sy_call_t to correctly do the comparison, lest gcc warn us about comparing distinct pointer types without a cast. This warning recently became an error due to bsd.kmod.mk, so it causes the build to fail on 8.1 and earlier, which do not use syscall_register() due to a conflicting entry for our syscall in syscalls.master. Change-Id: I606aaf73e433a50ea41adaab842d61ee69653bd5 Reported-by: Garrett Wollman Reviewed-on: http://gerrit.openafs.org/5087 Tested-by: BuildBot Reviewed-by: Garrett Wollman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/afs/FBSD/osi_vfsops.c b/src/afs/FBSD/osi_vfsops.c index b300ff4..35b6fca 100644 --- a/src/afs/FBSD/osi_vfsops.c +++ b/src/afs/FBSD/osi_vfsops.c @@ -56,7 +56,7 @@ afs_init(struct vfsconf *vfc) } #else if (sysent[AFS_SYSCALL].sy_call != nosys - && sysent[AFS_SYSCALL].sy_call != lkmnosys) { + && sysent[AFS_SYSCALL].sy_call != (sy_call_t *)lkmnosys) { printf("AFS_SYSCALL in use. aborting\n"); return EBUSY; }