From: Mark Vitale Date: Wed, 20 Nov 2013 20:05:21 +0000 (-0500) Subject: fssync-debug: close test connection X-Git-Tag: openafs-stable-1_8_0pre1~412 X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=4b648925603a50d2a248304a954308e8fa902df4;hp=ffe0757a5610d1fe6cf7e513d62ccc570d559206 fssync-debug: close test connection A valid fssync-debug query command issued against a DAFS fileserver will produce the following error messages in FileLog: SYNC_getCom: error receiving command FSYNC_com: read failed; dropping connection (cnt=1) Routine dafs_prolog() issues a tentative FSYNC_VOL_LISTVOLUMES operation to test for the presence of a DAFS fileserver. If DAFS is detected, we then call dafssync-debug for the original requested operation. However, the FSYNC connection for the tentative LISTVOLUMES operation is never closed. This results in the errors when the command completes. Close the test connection. Change-Id: I3c987289408407ba38cd184b7518e72ee1ae9cfc Reviewed-on: http://gerrit.openafs.org/10476 Reviewed-by: Daria Brashear Reviewed-by: Mark Vitale Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- diff --git a/src/vol/fssync-debug.c b/src/vol/fssync-debug.c index 27380fc..ddc83fc 100644 --- a/src/vol/fssync-debug.c +++ b/src/vol/fssync-debug.c @@ -274,6 +274,7 @@ dafs_prolog(void) /* LISTVOLUMES is a no-op; we just want to get the response header flags * to see if the server reports itself as DAFS or not */ code = FSYNC_VolOp(0, NULL, FSYNC_VOL_LISTVOLUMES, FSYNC_WHATEVER, &res); + VDisconnectFS(); /* disconnect before continuing */ if (code) { /* probably failed to contact the fileserver; later code will provide * some warning/error indication */