From: Benjamin Kaduk <kaduk@mit.edu>
Date: Wed, 17 Sep 2014 16:07:02 +0000 (-0400)
Subject: Fix disk name initialization in scout
X-Git-Tag: openafs-stable-1_8_0pre1~539
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=57ca77786eb6c04519f9358f1456fdf5b8006757

Fix disk name initialization in scout

Scout needs to initialize names in scout_disk structures to prevent
the use of uninitialized data.  However, '\0' is a NUL character
constant, i.e., the integer value 0, which is interpreted as NULL
(the pointer constant) in a pointer context, such as when assigned to
a variable of type char*.  Since the name field in these structs is
passed to printing routines, the safe initialization value is the
empty string constant "", not a zero value.

Change-Id: Ie0530fc4fc090b226c0e54201b4a74158efddebd
Reviewed-on: http://gerrit.openafs.org/11469
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/scout/scout.c b/src/scout/scout.c
index 663edbf..5f61e4b 100644
--- a/src/scout/scout.c
+++ b/src/scout/scout.c
@@ -397,7 +397,7 @@ scout_initDiskLightObjects(struct mini_line *a_line, struct gwin *a_win)
 	curr_disk->prev = i - 1;
 	curr_disk->next = i + 1;
 	curr_disk->active = 0;
-	curr_disk->name = '\0';
+	curr_disk->name = "";
 
 	/*
 	 * Bump up to the next disk structure.